From: "Jesper Juhl" <jesper.juhl@gmail.com>
To: "David Miller" <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org, kkeil@suse.de,
kai.germaschewski@gmx.de, isdn4linux@listserv.isdn4linux.de
Subject: Re: [PATCH] ISDN: fix double free bug in isdn_net
Date: Tue, 15 Aug 2006 12:42:07 +0200 [thread overview]
Message-ID: <9a8748490608150342i1e546484kb66ff57ab78ebb05@mail.gmail.com> (raw)
In-Reply-To: <20060815.021503.71555009.davem@davemloft.net>
On 15/08/06, David Miller <davem@davemloft.net> wrote:
> From: "Jesper Juhl" <jesper.juhl@gmail.com>
> Date: Tue, 15 Aug 2006 11:08:35 +0200
>
> > Hmm, perhaps I made a mistake and missed a path. Maybe it would be
> > better to fix if by making isdn_writebuf_skb_stub() always set the skb
> > to NULL when it does free it. That would add a few more assignments
> > but should ensure the right result always.
> > What do you say?
>
> Do we know if the ->writebuf_skb() method ever frees the skb? If it
> never does, then yes your suggestion would be one way to handle this.
>
I'll look at it tonight and if writebuf_skb() method never frees the
skb I'll send a patch.
--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
next prev parent reply other threads:[~2006-08-15 10:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-12 20:48 Jesper Juhl
2006-08-15 9:00 ` David Miller
2006-08-15 9:08 ` Jesper Juhl
2006-08-15 9:15 ` David Miller
2006-08-15 10:42 ` Jesper Juhl [this message]
2006-08-15 16:06 ` Karsten Keil
2006-08-16 20:22 ` Jesper Juhl
2006-08-16 20:39 ` Karsten Keil
2006-08-16 20:44 ` David Miller
2006-08-16 20:48 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a8748490608150342i1e546484kb66ff57ab78ebb05@mail.gmail.com \
--to=jesper.juhl@gmail.com \
--cc=davem@davemloft.net \
--cc=isdn4linux@listserv.isdn4linux.de \
--cc=kai.germaschewski@gmx.de \
--cc=kkeil@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®