From: Ingo Oeser <ioe-lkml@rameria.de>
To: "Randy.Dunlap" <rdunlap@xenotime.net>
Cc: Pavel Machek <pavel@ucw.cz>, Takashi Iwai <tiwai@suse.de>,
Andrew Morton <akpm@osdl.org>,
kernel list <linux-kernel@vger.kernel.org>,
perex@suse.cz, alsa-devel@alsa-project.org, pshou@realtek.com.tw
Subject: Re: CodingStyle (was: Re: sound/pci/hda/intel_hda: small cleanups)
Date: Wed, 6 Sep 2006 09:23:19 +0200 [thread overview]
Message-ID: <200609060923.22459.ioe-lkml@rameria.de> (raw)
In-Reply-To: <20060905084352.1ced999e.rdunlap@xenotime.net>
Hi,
On Tuesday, 5. September 2006 17:43, Randy.Dunlap wrote:
> Is there an acceptable way to leave source code in a file but
> render it unused? Like #if 0/#endif or #if BOGUS_SYMBOL/#endif ?
They are to reading like gaps in a road.
If you really need to keep unused code for reference
just do it in your LOCAL repository.
There are exceptions where you remove the last user of code
in one patch and a different developer just needs this code
for his new stuff in another patch.
In this case an #if 0/#endif is quite common to reduce merging
conflicts.
Regards
Ingo Oeser
next prev parent reply other threads:[~2006-09-06 7:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-31 12:37 sound/pci/hda/intel_hda: small cleanups Pavel Machek
2006-08-31 13:01 ` Takashi Iwai
2006-08-31 13:39 ` Pavel Machek
2006-08-31 14:53 ` Takashi Iwai
2006-08-31 22:29 ` Pavel Machek
2006-08-31 18:04 ` CodingStyle (was: Re: sound/pci/hda/intel_hda: small cleanups) Randy.Dunlap
2006-09-02 23:15 ` Pavel Machek
2006-09-03 4:30 ` Randy.Dunlap
2006-09-05 8:08 ` Pavel Machek
2006-09-05 15:26 ` Takashi Iwai
2006-09-05 15:43 ` Randy.Dunlap
2006-09-06 7:23 ` Ingo Oeser [this message]
2006-09-06 13:51 ` Pavel Machek
2006-09-06 22:22 ` Chase Venters
2006-09-05 16:40 ` CodingStyle Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200609060923.22459.ioe-lkml@rameria.de \
--to=ioe-lkml@rameria.de \
--cc=akpm@osdl.org \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=perex@suse.cz \
--cc=pshou@realtek.com.tw \
--cc=rdunlap@xenotime.net \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®