set power state of firewire host during suspend

set power state of firewire host during suspend

[Pavel Machek]

Put firewire host controller in PCI Dx state for system suspend.
(I was not able to measure any power savings, but it sounds like right
thing to do, anyway.)

Signed-off-by: Pavel Machek <pavel@suse.cz>

---
commit 099774f95904ca16463b9383d812d20621553555
tree 9173983914ccf142ce948dc03f7ae493b489c28f
parent c0aceb8cda90a681ee8028e22b45c00e98b7c33c
author <pavel@amd.ucw.cz> Tue, 05 Sep 2006 10:13:37 +0200
committer <pavel@amd.ucw.cz> Tue, 05 Sep 2006 10:13:37 +0200

 drivers/ieee1394/ohci1394.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/ieee1394/ohci1394.c b/drivers/ieee1394/ohci1394.c
index 448df27..12b6dfa 100644
--- a/drivers/ieee1394/ohci1394.c
+++ b/drivers/ieee1394/ohci1394.c
@@ -3565,6 +3565,7 @@ static int ohci1394_pci_suspend (struct 
 	}
 #endif
 
+	pci_set_power_state(pdev, pci_choose_state(pdev, state));
 	return 0;
 }
 

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: set power state of firewire host during suspend

[Stefan Richter]

Pavel Machek wrote:
> --- a/drivers/ieee1394/ohci1394.c
> +++ b/drivers/ieee1394/ohci1394.c
> @@ -3565,6 +3565,7 @@ static int ohci1394_pci_suspend (struct 
>  	}
>  #endif
>  
> +	pci_set_power_state(pdev, pci_choose_state(pdev, state));
>  	return 0;
>  }
>  
> 

Does this work on PPC_PMAC? Note the platform code before #endif.
http://www.linux-m32r.org/lxr/http/source/drivers/ieee1394/ohci1394.c?v=2.6.18-rc5-mm1#L3554
-- 
Stefan Richter
-=====-=-==- =--= --=-=
http://arcgraph.de/sr/

Re: set power state of firewire host during suspend

[Pavel Machek]

Hi!

> Pavel Machek wrote:
> > --- a/drivers/ieee1394/ohci1394.c
> > +++ b/drivers/ieee1394/ohci1394.c
> > @@ -3565,6 +3565,7 @@ static int ohci1394_pci_suspend (struct 
> >  	}
> >  #endif
> >  
> > +	pci_set_power_state(pdev, pci_choose_state(pdev, state));
> >  	return 0;
> >  }
> >  
> > 
> 
> Does this work on PPC_PMAC? Note the platform code before #endif.
> http://www.linux-m32r.org/lxr/http/source/drivers/ieee1394/ohci1394.c?v=2.6.18-rc5-mm1#L3554


No idea, I know very little about PMACs. They still have PCI, right?
Why does it need hooks into drivers like this?
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: set power state of firewire host during suspend

[Stefan Richter]

Pavel Machek wrote:
> Put firewire host controller in PCI Dx state for system suspend.
> (I was not able to measure any power savings, but it sounds like right
> thing to do, anyway.)
> 
> Signed-off-by: Pavel Machek <pavel@suse.cz>
[...]
> --- a/drivers/ieee1394/ohci1394.c
> +++ b/drivers/ieee1394/ohci1394.c
> @@ -3565,6 +3565,7 @@ static int ohci1394_pci_suspend (struct 
>  	}
>  #endif
>  
> +	pci_set_power_state(pdev, pci_choose_state(pdev, state));
>  	return 0;
>  }

The order with existing PPC_PMAC code needs to be swapped. And the
resume hook should set the power state too, right? I will post an update
patch soon.
-- 
Stefan Richter
-=====-=-==- =--= --===
http://arcgraph.de/sr/