mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* Re: [PATCH] avr32 architecture
       [not found] <200609261601.k8QG1Txd005700@hera.kernel.org>
@ 2006-09-26 21:02 ` David Woodhouse
  2006-09-26 21:17   ` Haavard Skinnemoen
  0 siblings, 1 reply; 3+ messages in thread
From: David Woodhouse @ 2006-09-26 21:02 UTC (permalink / raw)
  To: Linux Kernel Mailing List; +Cc: Håvard Skinnemoen, akpm

On Tue, 2006-09-26 at 16:01 +0000, Linux Kernel Mailing List wrote:
> [PATCH] avr32 architecture 

pmac /pmac/git/linux-2.6 $ make ARCH=avr32 headers_check
  CHK     include/linux/version.h
make[1]: `scripts/unifdef' is up to date.
  CHECK   include/asm/user.h
  CHECK   include/asm/unistd.h
/pmac/git/linux-2.6/usr/include/asm/unistd.h requires linux/linkage.h, which does not exist in exported headers
make[2]: *** [/pmac/git/linux-2.6/usr/include/asm/.check.unistd.h] Error 1

-- 
dwmw2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] avr32 architecture
  2006-09-26 21:02 ` [PATCH] avr32 architecture David Woodhouse
@ 2006-09-26 21:17   ` Haavard Skinnemoen
  2006-09-26 23:40     ` Andrew Morton
  0 siblings, 1 reply; 3+ messages in thread
From: Haavard Skinnemoen @ 2006-09-26 21:17 UTC (permalink / raw)
  To: David Woodhouse; +Cc: Linux Kernel Mailing List, Håvard Skinnemoen, akpm

On 9/26/06, David Woodhouse <dwmw2@infradead.org> wrote:
> On Tue, 2006-09-26 at 16:01 +0000, Linux Kernel Mailing List wrote:
> > [PATCH] avr32 architecture
>
> pmac /pmac/git/linux-2.6 $ make ARCH=avr32 headers_check
>   CHK     include/linux/version.h
> make[1]: `scripts/unifdef' is up to date.
>   CHECK   include/asm/user.h
>   CHECK   include/asm/unistd.h
> /pmac/git/linux-2.6/usr/include/asm/unistd.h requires linux/linkage.h, which does not exist in exported headers

Right. avr32-implement-kernel_execve.patch, which was flagged as "Will
merge" by Andrew, fixes it by moving the #ifdef __KERNEL__ guard to
cover everything but the __NR_foo definitions. So as long as that
one's still scheduled for inclusion, I think sending a separate patch
to fix this problem will do more harm than good.

But thanks for testing :)

Håvard

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] avr32 architecture
  2006-09-26 21:17   ` Haavard Skinnemoen
@ 2006-09-26 23:40     ` Andrew Morton
  0 siblings, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2006-09-26 23:40 UTC (permalink / raw)
  To: Haavard Skinnemoen
  Cc: David Woodhouse, Linux Kernel Mailing List,  Håvard Skinnemoen

On Tue, 26 Sep 2006 23:17:29 +0200
"Haavard Skinnemoen" <hskinnemoen@gmail.com> wrote:

> On 9/26/06, David Woodhouse <dwmw2@infradead.org> wrote:
> > On Tue, 2006-09-26 at 16:01 +0000, Linux Kernel Mailing List wrote:
> > > [PATCH] avr32 architecture
> >
> > pmac /pmac/git/linux-2.6 $ make ARCH=avr32 headers_check
> >   CHK     include/linux/version.h
> > make[1]: `scripts/unifdef' is up to date.
> >   CHECK   include/asm/user.h
> >   CHECK   include/asm/unistd.h
> > /pmac/git/linux-2.6/usr/include/asm/unistd.h requires linux/linkage.h, which does not exist in exported headers
> 
> Right. avr32-implement-kernel_execve.patch, which was flagged as "Will
> merge" by Andrew, fixes it by moving the #ifdef __KERNEL__ guard to
> cover everything but the __NR_foo definitions.

Ho hum, such leakage happens sometimes.

> So as long as that
> one's still scheduled for inclusion, I think sending a separate patch
> to fix this problem will do more harm than good.
> 

Yes, I'm planning on merging the execve cleanups for 2.6.19.  It's probably
a week away yet.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2006-09-26 23:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <200609261601.k8QG1Txd005700@hera.kernel.org>
2006-09-26 21:02 ` [PATCH] avr32 architecture David Woodhouse
2006-09-26 21:17   ` Haavard Skinnemoen
2006-09-26 23:40     ` Andrew Morton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®