* [PATCH] MD: conditionalize some code
@ 2006-10-10 23:16 Jeff Garzik
2006-10-10 23:53 ` Neil Brown
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Garzik @ 2006-10-10 23:16 UTC (permalink / raw)
To: neilb, Andrew Morton, LKML
The autorun code is only used if this module is built into the static
kernel image. Adjust #ifdefs accordingly.
Signed-off-by: Jeff Garzik <jeff@garzik.org>
---
drivers/md/md.c | 4 +++-
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 57fa64f..c75cdf9 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -3368,6 +3368,7 @@ out:
return err;
}
+#ifndef MODULE
static void autorun_array(mddev_t *mddev)
{
mdk_rdev_t *rdev;
@@ -3482,6 +3483,7 @@ static void autorun_devices(int part)
}
printk(KERN_INFO "md: ... autorun DONE.\n");
}
+#endif /* !MODULE */
static int get_version(void __user * arg)
{
@@ -5592,7 +5594,7 @@ static void autostart_arrays(int part)
autorun_devices(part);
}
-#endif
+#endif /* !MODULE */
static __exit void md_exit(void)
{
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MD: conditionalize some code
2006-10-10 23:16 [PATCH] MD: conditionalize some code Jeff Garzik
@ 2006-10-10 23:53 ` Neil Brown
2006-10-11 15:46 ` Steve Hindle
0 siblings, 1 reply; 3+ messages in thread
From: Neil Brown @ 2006-10-10 23:53 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Andrew Morton, LKML
On Tuesday October 10, jeff@garzik.org wrote:
>
> The autorun code is only used if this module is built into the static
> kernel image. Adjust #ifdefs accordingly.
>
> Signed-off-by: Jeff Garzik <jeff@garzik.org>
Acked-by: NeilBrown <neilb@suse.de>
Thanks,
NeilBrown
>
> ---
>
> drivers/md/md.c | 4 +++-
>
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 57fa64f..c75cdf9 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -3368,6 +3368,7 @@ out:
> return err;
> }
>
> +#ifndef MODULE
> static void autorun_array(mddev_t *mddev)
> {
> mdk_rdev_t *rdev;
> @@ -3482,6 +3483,7 @@ static void autorun_devices(int part)
> }
> printk(KERN_INFO "md: ... autorun DONE.\n");
> }
> +#endif /* !MODULE */
>
> static int get_version(void __user * arg)
> {
> @@ -5592,7 +5594,7 @@ static void autostart_arrays(int part)
> autorun_devices(part);
> }
>
> -#endif
> +#endif /* !MODULE */
>
> static __exit void md_exit(void)
> {
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MD: conditionalize some code
2006-10-10 23:53 ` Neil Brown
@ 2006-10-11 15:46 ` Steve Hindle
0 siblings, 0 replies; 3+ messages in thread
From: Steve Hindle @ 2006-10-11 15:46 UTC (permalink / raw)
To: Neil Brown; +Cc: Jeff Garzik, Andrew Morton, LKML
On 10/10/06, Neil Brown <neilb@suse.de> wrote:
> On Tuesday October 10, jeff@garzik.org wrote:
> >
> > The autorun code is only used if this module is built into the static
> > kernel image. Adjust #ifdefs accordingly.
> >
Greatt - thanks! I wondered why my debian boxes weren't starting the
arrays unless I used mdadm
to 'poke' them. I think I filed a bug with Debian regarding this -
I'll see if I can find/update it.
Steve
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-10-11 15:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-10-10 23:16 [PATCH] MD: conditionalize some code Jeff Garzik
2006-10-10 23:53 ` Neil Brown
2006-10-11 15:46 ` Steve Hindle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®