From: David Miller <davem@davemloft.net>
To: jeremy@goop.org
Cc: magnus.damm@gmail.com, horms@verge.net.au, ebiederm@xmission.com,
magnus@valinux.co.jp, linux-kernel@vger.kernel.org,
vgoyal@in.ibm.com, ak@muc.de, fastboot@lists.osdl.org,
anderson@redhat.com
Subject: Re: [PATCH 02/02] Elf: Align elf notes properly
Date: Fri, 10 Nov 2006 15:39:30 -0800 (PST) [thread overview]
Message-ID: <20061110.153930.23011358.davem@davemloft.net> (raw)
In-Reply-To: <45550D2F.2070004@goop.org>
From: Jeremy Fitzhardinge <jeremy@goop.org>
Date: Fri, 10 Nov 2006 15:37:19 -0800
> Magnus Damm wrote:
> > I see no point in aligning to 32-bit boundaries on 64-bit platforms.
> > Their intention was most likely to align to the word size IMO, so this
> > is most likely a "thinko" left over from whoever ported the code from
> > 32-bit to 64-bit.
>
> I don't think so. Since Elf64 notes still have 32-bit values in them,
> 32-bit alignment seems the most sensible. It would certainly be an
> irritation to have Elf32 and Elf64 Notes with basically the same
> definition, but with different alignments.
I think Elf64 notes very much would need 64-bit alignment, especially
if there are u64 objects in there. Otherwise it would not be possible
to directly dereference such objects without taking unaligned faults
on several types of RISC cpus.
next prev parent reply other threads:[~2006-11-10 23:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-02 10:19 [PATCH 01/02] Elf: Always define elf_addr_t in linux/elf.h Magnus Damm
2006-11-02 10:19 ` [PATCH 02/02] Elf: Align elf notes properly Magnus Damm
2006-11-09 14:00 ` Eric W. Biederman
2006-11-10 0:50 ` Horms
2006-11-10 4:00 ` Magnus Damm
2006-11-10 23:37 ` Jeremy Fitzhardinge
2006-11-10 23:39 ` David Miller [this message]
2006-11-11 0:26 ` Jeremy Fitzhardinge
2006-11-11 0:43 ` David Miller
2006-11-11 1:20 ` Jeremy Fitzhardinge
2006-11-13 2:16 ` Magnus Damm
2006-11-13 3:03 ` Eric W. Biederman
2006-11-13 0:23 ` Horms
2006-11-13 1:47 ` David Miller
2006-11-10 3:52 ` Magnus Damm
2006-11-10 5:09 ` Eric W. Biederman
2006-11-10 6:53 ` Magnus Damm
2006-11-10 14:49 ` Vivek Goyal
2006-11-10 16:04 ` Dave Anderson
2006-11-10 16:10 ` Eric W. Biederman
2006-11-10 23:39 ` Jeremy Fitzhardinge
2006-11-02 10:43 ` [PATCH 01/02] Elf: Always define elf_addr_t in linux/elf.h Jakub Jelinek
2006-11-02 10:51 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061110.153930.23011358.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ak@muc.de \
--cc=anderson@redhat.com \
--cc=ebiederm@xmission.com \
--cc=fastboot@lists.osdl.org \
--cc=horms@verge.net.au \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=magnus@valinux.co.jp \
--cc=vgoyal@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®