mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Magnus Damm" <magnus.damm@gmail.com>
To: "Jakub Jelinek" <jakub@redhat.com>
Cc: "Magnus Damm" <magnus@valinux.co.jp>,
	linux-kernel@vger.kernel.org, "Vivek Goyal" <vgoyal@in.ibm.com>,
	"Andi Kleen" <ak@muc.de>,
	fastboot@lists.osdl.org, Horms <horms@verge.net.au>,
	"Dave Anderson" <anderson@redhat.com>,
	ebiederm@xmission.com
Subject: Re: [PATCH 01/02] Elf: Always define elf_addr_t in linux/elf.h
Date: Thu, 2 Nov 2006 19:51:02 +0900	[thread overview]
Message-ID: <aec7e5c30611020251p7375fb39ne1f5aba8ea14a3a2@mail.gmail.com> (raw)
In-Reply-To: <20061102104305.GD24872@devserv.devel.redhat.com>

On 11/2/06, Jakub Jelinek <jakub@redhat.com> wrote:
> On Thu, Nov 02, 2006 at 07:19:42PM +0900, Magnus Damm wrote:
> > --- 0001/include/linux/elf.h
> > +++ work/include/linux/elf.h  2006-11-02 15:44:10.000000000 +0900
> > @@ -352,12 +352,16 @@ typedef struct elf64_note {
> >    Elf64_Word n_type; /* Content type */
> >  } Elf64_Nhdr;
> >
> > +typedef Elf64_Off elf64_addr;
> > +typedef Elf32_Off elf32_addr;
> > +
>
> What are these typedefs useful for?  Isn't it better just to
> use Elf32_Addr and Elf64_Addr in the #defines below?

Sure, good idea. I just added them to follow the "style" of the rest
of the file.

Thanks,

/ magnus

      reply	other threads:[~2006-11-02 10:51 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-02 10:19 Magnus Damm
2006-11-02 10:19 ` [PATCH 02/02] Elf: Align elf notes properly Magnus Damm
2006-11-09 14:00   ` Eric W. Biederman
2006-11-10  0:50     ` Horms
2006-11-10  4:00       ` Magnus Damm
2006-11-10 23:37         ` Jeremy Fitzhardinge
2006-11-10 23:39           ` David Miller
2006-11-11  0:26             ` Jeremy Fitzhardinge
2006-11-11  0:43               ` David Miller
2006-11-11  1:20                 ` Jeremy Fitzhardinge
2006-11-13  2:16                   ` Magnus Damm
2006-11-13  3:03                     ` Eric W. Biederman
2006-11-13  0:23                 ` Horms
2006-11-13  1:47                   ` David Miller
2006-11-10  3:52     ` Magnus Damm
2006-11-10  5:09       ` Eric W. Biederman
2006-11-10  6:53         ` Magnus Damm
2006-11-10 14:49           ` Vivek Goyal
2006-11-10 16:04             ` Dave Anderson
2006-11-10 16:10             ` Eric W. Biederman
2006-11-10 23:39         ` Jeremy Fitzhardinge
2006-11-02 10:43 ` [PATCH 01/02] Elf: Always define elf_addr_t in linux/elf.h Jakub Jelinek
2006-11-02 10:51   ` Magnus Damm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aec7e5c30611020251p7375fb39ne1f5aba8ea14a3a2@mail.gmail.com \
    --to=magnus.damm@gmail.com \
    --cc=ak@muc.de \
    --cc=anderson@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=fastboot@lists.osdl.org \
    --cc=horms@verge.net.au \
    --cc=jakub@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=magnus@valinux.co.jp \
    --cc=vgoyal@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®