mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: vgoyal@in.ibm.com
Cc: Magnus Damm <magnus.damm@gmail.com>,
	Magnus Damm <magnus@valinux.co.jp>,
	linux-kernel@vger.kernel.org, Andi Kleen <ak@muc.de>,
	fastboot@lists.osdl.org, Horms <horms@verge.net.au>,
	Dave Anderson <anderson@redhat.com>
Subject: Re: [PATCH 02/02] Elf: Align elf notes properly
Date: Fri, 10 Nov 2006 09:10:42 -0700	[thread overview]
Message-ID: <m1fycrjn99.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20061110144922.GA8155@in.ibm.com> (Vivek Goyal's message of "Fri, 10 Nov 2006 09:49:22 -0500")

Vivek Goyal <vgoyal@in.ibm.com> writes:
>
> IMHO, I think we should go by the specs (8byte boundary alignment on 64bit
> platforms) until and unless it can be proven that specs are wrong. This
> probably will mean that we will break things for sometime (until and unless
> it is fixed in tool chain and probably will also break the capability to use
> an older kernel for capturing dump). But that's unavoidable if we want to be
> compliant to specs.

I just looked a little more, and the notes gcc generates on x86_64 are only 4
byte aligned. (.note.ABI-tag)

The linux kernel gcc, gdb.  I think that is enough to say that notes need to
be 4 byte aligned on Linux.   The core ELF spec also calls out 4 byte alignment
(although it does not mention ELFCLASS64).

I think the evidence is that someone intended to the alignment to go to 8 bytes
with the move to 64bits but it did not catch on in the real world.

So yes I believe the evidence is quite strong that the spec is wrong. 
(Not on some rare platforms certainly but in general).

Eric

  parent reply	other threads:[~2006-11-10 16:13 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-02 10:19 [PATCH 01/02] Elf: Always define elf_addr_t in linux/elf.h Magnus Damm
2006-11-02 10:19 ` [PATCH 02/02] Elf: Align elf notes properly Magnus Damm
2006-11-09 14:00   ` Eric W. Biederman
2006-11-10  0:50     ` Horms
2006-11-10  4:00       ` Magnus Damm
2006-11-10 23:37         ` Jeremy Fitzhardinge
2006-11-10 23:39           ` David Miller
2006-11-11  0:26             ` Jeremy Fitzhardinge
2006-11-11  0:43               ` David Miller
2006-11-11  1:20                 ` Jeremy Fitzhardinge
2006-11-13  2:16                   ` Magnus Damm
2006-11-13  3:03                     ` Eric W. Biederman
2006-11-13  0:23                 ` Horms
2006-11-13  1:47                   ` David Miller
2006-11-10  3:52     ` Magnus Damm
2006-11-10  5:09       ` Eric W. Biederman
2006-11-10  6:53         ` Magnus Damm
2006-11-10 14:49           ` Vivek Goyal
2006-11-10 16:04             ` Dave Anderson
2006-11-10 16:10             ` Eric W. Biederman [this message]
2006-11-10 23:39         ` Jeremy Fitzhardinge
2006-11-02 10:43 ` [PATCH 01/02] Elf: Always define elf_addr_t in linux/elf.h Jakub Jelinek
2006-11-02 10:51   ` Magnus Damm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1fycrjn99.fsf@ebiederm.dsl.xmission.com \
    --to=ebiederm@xmission.com \
    --cc=ak@muc.de \
    --cc=anderson@redhat.com \
    --cc=fastboot@lists.osdl.org \
    --cc=horms@verge.net.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=magnus@valinux.co.jp \
    --cc=vgoyal@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome