mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Christoph Lameter <clameter@sgi.com>
Cc: "Chen, Kenneth W" <kenneth.w.chen@intel.com>,
	"Siddha, Suresh B" <suresh.b.siddha@intel.com>,
	akpm@osdl.org, mm-commits@vger.kernel.org,
	nickpiggin@yahoo.com.au, linux-kernel@vger.kernel.org
Subject: Re: + sched-use-tasklet-to-call-balancing.patch added to -mm tree
Date: Fri, 10 Nov 2006 22:42:08 +0100	[thread overview]
Message-ID: <20061110214208.GA23456@elte.hu> (raw)
In-Reply-To: <Pine.LNX.4.64.0611101027100.25459@schroedinger.engr.sgi.com>


* Christoph Lameter <clameter@sgi.com> wrote:

> On a 8p system:
> 
> I) Percent of ticks where load balancing was found to be required
> 
> II) Percent of ticks where we attempted load balancing
>    but we found that we need to try again due to load balancing
>    in progress elsewhere (This increases (I) since we found that
>    load balancing was required but we decided to defer. Tasklet
>    was not invoked).
> 
>     	I)	II) 
> Boot:	70%	~1%
> AIM7:	30%	2%
> Idle:	50%	 <0.5%
> 
> 256p:
> 	I)	II)
> Boot:	80%	30%
> AIM7:	90%	30%
> Idle: 	95%	30%

nice measurements and interesting results.

note that with a tasklet a 'retry' will often be done on the /same/ CPU 
that was running the tasklet when we tried to schedule it. I.e. such a 
'collision' will result not only in the 'loss' of the local rebalance 
event, but also causes /another/ rebalance event on the remote CPU.

so a better model would be the trylock model i suggested in the previous 
mail: to just lose the rebalance events upon collision and not cause 
extra work on the remote CPU. I'd also suggest to keep the rebalancing 
code under the irqs-off section, like it is currently - only do it 
conditional on trylock success. Do you think that would work?

	Ingo

  parent reply	other threads:[~2006-11-10 21:42 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200611032205.kA3M5wmJ003178@shell0.pdx.osdl.net>
2006-11-07  7:32 ` Ingo Molnar
2006-11-07 17:44   ` Christoph Lameter
2006-11-07 17:31     ` Siddha, Suresh B
2006-11-07 17:55       ` Christoph Lameter
2006-11-07 17:50         ` Siddha, Suresh B
2006-11-07 18:18           ` Christoph Lameter
2006-11-07 19:17           ` Christoph Lameter
2006-11-07 20:31             ` Ingo Molnar
2006-11-07 20:59               ` Christoph Lameter
2006-11-07 21:35                 ` Chen, Kenneth W
2006-11-07 21:49                   ` Christoph Lameter
2006-11-10  6:18                     ` Chen, Kenneth W
2006-11-10 18:50                       ` Christoph Lameter
2006-11-10 21:38                         ` Ingo Molnar
2006-11-11  1:01                           ` Christoph Lameter
2006-11-11  2:05                             ` Chen, Kenneth W
2006-11-11  2:51                               ` Christoph Lameter
2006-11-13  4:03                                 ` Chen, Kenneth W
2006-11-13  5:44                                   ` Christoph Lameter
2006-11-13  6:40                                     ` Chen, Kenneth W
2006-11-14  1:06                                       ` [patch] sched domain: move sched group allocations to percpu area Siddha, Suresh B
2006-11-14  8:23                                         ` Ingo Molnar
2006-11-14 16:57                                         ` Christoph Lameter
2006-11-10 21:42                         ` Ingo Molnar [this message]
2006-11-10 22:32                         ` + sched-use-tasklet-to-call-balancing.patch added to -mm tree Siddha, Suresh B
2006-11-11  1:14                           ` Christoph Lameter
2006-11-07 19:22           ` Christoph Lameter
2006-11-07 20:29         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061110214208.GA23456@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@osdl.org \
    --cc=clameter@sgi.com \
    --cc=kenneth.w.chen@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mm-commits@vger.kernel.org \
    --cc=nickpiggin@yahoo.com.au \
    --cc=suresh.b.siddha@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome