[PATCH 2.6.19] net/wanrouter/wanmain.c: check kmalloc() return value.

[PATCH 2.6.19] net/wanrouter/wanmain.c: check kmalloc() return value.

[Amit Choudhary]

Description: Check the return value of kmalloc() in function dbg_kmalloc(), in file net/wanrouter/wanmain.c.

Signed-off-by: Amit Choudhary <amit2030@gmail.com>

diff --git a/net/wanrouter/wanmain.c b/net/wanrouter/wanmain.c
index 316211d..263450c 100644
--- a/net/wanrouter/wanmain.c
+++ b/net/wanrouter/wanmain.c
@@ -67,6 +67,8 @@ static void * dbg_kmalloc(unsigned int s
 	int i = 0;
 	void * v = kmalloc(size+sizeof(unsigned int)+2*KMEM_SAFETYZONE*8,prio);
 	char * c1 = v;
+	if (!v)
+		return NULL;
 	c1 += sizeof(unsigned int);
 	*((unsigned int *)v) = size;
 

Re: [PATCH 2.6.19] net/wanrouter/wanmain.c: check kmalloc() return value.

[David Miller]

From: Amit Choudhary <amit2030@gmail.com>
Date: Wed, 6 Dec 2006 23:04:58 -0800

> Description: Check the return value of kmalloc() in function dbg_kmalloc(), in file net/wanrouter/wanmain.c.
> 
> Signed-off-by: Amit Choudhary <amit2030@gmail.com>

Better to just delete this code altogether, there is no need
for any subsystem to duplicate the already implemented
SLAB debugging functionality.

And that's how I'll fix this, thanks for pointing out the
problem :)