* [PATCH 2.6.19] net/wanrouter/wanmain.c: check kmalloc() return value.
@ 2006-12-07 7:04 Amit Choudhary
2006-12-07 8:16 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Amit Choudhary @ 2006-12-07 7:04 UTC (permalink / raw)
To: Linux Kernel
Description: Check the return value of kmalloc() in function dbg_kmalloc(), in file net/wanrouter/wanmain.c.
Signed-off-by: Amit Choudhary <amit2030@gmail.com>
diff --git a/net/wanrouter/wanmain.c b/net/wanrouter/wanmain.c
index 316211d..263450c 100644
--- a/net/wanrouter/wanmain.c
+++ b/net/wanrouter/wanmain.c
@@ -67,6 +67,8 @@ static void * dbg_kmalloc(unsigned int s
int i = 0;
void * v = kmalloc(size+sizeof(unsigned int)+2*KMEM_SAFETYZONE*8,prio);
char * c1 = v;
+ if (!v)
+ return NULL;
c1 += sizeof(unsigned int);
*((unsigned int *)v) = size;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2.6.19] net/wanrouter/wanmain.c: check kmalloc() return value.
2006-12-07 7:04 [PATCH 2.6.19] net/wanrouter/wanmain.c: check kmalloc() return value Amit Choudhary
@ 2006-12-07 8:16 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2006-12-07 8:16 UTC (permalink / raw)
To: amit2030; +Cc: linux-kernel
From: Amit Choudhary <amit2030@gmail.com>
Date: Wed, 6 Dec 2006 23:04:58 -0800
> Description: Check the return value of kmalloc() in function dbg_kmalloc(), in file net/wanrouter/wanmain.c.
>
> Signed-off-by: Amit Choudhary <amit2030@gmail.com>
Better to just delete this code altogether, there is no need
for any subsystem to duplicate the already implemented
SLAB debugging functionality.
And that's how I'll fix this, thanks for pointing out the
problem :)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-12-07 8:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-12-07 7:04 [PATCH 2.6.19] net/wanrouter/wanmain.c: check kmalloc() return value Amit Choudhary
2006-12-07 8:16 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®