* [PATCH] x86 smp: export smp_num_siblings for oprofile
@ 2006-12-09 8:34 Randy Dunlap
2006-12-09 8:49 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2006-12-09 8:34 UTC (permalink / raw)
To: lkml; +Cc: phil.el, akpm, ak
From: Randy Dunlap <randy.dunlap@oracle.com>
oprofile uses smp_num_siblings without testing for CONFIG_X86_HT.
I looked at modifying oprofile, but this way is cleaner & simpler
and I didn't see a good reason not to just export it when CONFIG_SMP.
WARNING: "smp_num_siblings" [arch/i386/oprofile/oprofile.ko] undefined!
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
arch/i386/kernel/smpboot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.19-git13.orig/arch/i386/kernel/smpboot.c
+++ linux-2.6.19-git13/arch/i386/kernel/smpboot.c
@@ -69,7 +69,7 @@ static int __devinitdata smp_b_stepping;
/* Number of siblings per CPU package */
int smp_num_siblings = 1;
-#ifdef CONFIG_X86_HT
+#ifdef CONFIG_SMP
EXPORT_SYMBOL(smp_num_siblings);
#endif
---
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] x86 smp: export smp_num_siblings for oprofile
2006-12-09 8:34 [PATCH] x86 smp: export smp_num_siblings for oprofile Randy Dunlap
@ 2006-12-09 8:49 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2006-12-09 8:49 UTC (permalink / raw)
To: Randy Dunlap; +Cc: lkml, phil.el, ak
On Sat, 9 Dec 2006 00:34:24 -0800
Randy Dunlap <randy.dunlap@oracle.com> wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> oprofile uses smp_num_siblings without testing for CONFIG_X86_HT.
> I looked at modifying oprofile, but this way is cleaner & simpler
> and I didn't see a good reason not to just export it when CONFIG_SMP.
>
> WARNING: "smp_num_siblings" [arch/i386/oprofile/oprofile.ko] undefined!
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> arch/i386/kernel/smpboot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2.6.19-git13.orig/arch/i386/kernel/smpboot.c
> +++ linux-2.6.19-git13/arch/i386/kernel/smpboot.c
> @@ -69,7 +69,7 @@ static int __devinitdata smp_b_stepping;
>
> /* Number of siblings per CPU package */
> int smp_num_siblings = 1;
> -#ifdef CONFIG_X86_HT
> +#ifdef CONFIG_SMP
> EXPORT_SYMBOL(smp_num_siblings);
> #endif
smpboot.c isn't compiled if CONFIG_SMP=n, so I'll just remove the ifdef,
thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-12-09 8:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-12-09 8:34 [PATCH] x86 smp: export smp_num_siblings for oprofile Randy Dunlap
2006-12-09 8:49 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®