From: Andrew Morton <akpm@osdl.org>
To: Alon Bar-Lev <alon.barlev@gmail.com>
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
"H. Peter Anvin" <hpa@zytor.com>, Bernhard Walle <bwalle@suse.de>
Subject: Re: [PATCH 10/26] Dynamic kernel command-line - ia64
Date: Sat, 27 Jan 2007 00:24:53 -0800 [thread overview]
Message-ID: <20070127002453.57b1e071.akpm@osdl.org> (raw)
In-Reply-To: <200701230014.06793.alon.barlev@gmail.com>
On Tue, 23 Jan 2007 00:14:06 +0200
Alon Bar-Lev <alon.barlev@gmail.com> wrote:
>
> 1. Rename saved_command_line into boot_command_line.
> 2. Set command_line as __initdata.
>
> Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
>
> ---
>
> diff -urNp linux-2.6.20-rc4-mm1.org/arch/ia64/kernel/efi.c linux-2.6.20-rc4-mm1/arch/ia64/kernel/efi.c
> --- linux-2.6.20-rc4-mm1.org/arch/ia64/kernel/efi.c 2007-01-07 07:45:51.000000000 +0200
> +++ linux-2.6.20-rc4-mm1/arch/ia64/kernel/efi.c 2007-01-22 23:32:30.000000000 +0200
> @@ -413,11 +413,11 @@ efi_init (void)
> efi_char16_t *c16;
> u64 efi_desc_size;
> char *cp, vendor[100] = "unknown";
> - extern char saved_command_line[];
> + extern char __initdata boot_command_line[];
> int i;
>
> chk_nointroute_opt(void)
> {
> char *cp;
> - extern char saved_command_line[];
> + extern char __initdata boot_command_line[];
no no no no no no no. Just because some whacked-out weenie went and put
extern declarations in .c files doesn't mean that we should copy them.
It doesn't even compile.
arch/ia64/kernel/efi.c: In function `efi_init':
arch/ia64/kernel/efi.c:416: error: section attribute cannot be specified for local variables
Please. Go through the entire patchset, yank all those wrong private
declarations of boot_command_line[] and put a *single, kernel-wide*
declaration into a single, shared header file.
Thanks.
next parent reply other threads:[~2007-01-27 8:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200701230010.34323.alon.barlev@gmail.com>
[not found] ` <200701230014.06793.alon.barlev@gmail.com>
2007-01-27 8:24 ` Andrew Morton [this message]
2007-01-27 8:34 ` Alon Bar-Lev
2007-01-27 8:44 ` Andrew Morton
2007-01-27 20:49 ` [PATCH] Dynamic kernel command-line - fixups Alon Bar-Lev
2007-01-18 12:58 [patch 00/26] Dynamic kernel command-line Bernhard Walle
2007-01-18 12:58 ` [patch 10/26] Dynamic kernel command-line - ia64 Bernhard Walle
-- strict thread matches above, loose matches on Subject: below --
2006-12-02 10:47 [PATCH 00/26] Dynamic kernel command-line Alon Bar-Lev
2006-12-02 10:51 ` [PATCH 10/26] Dynamic kernel command-line - ia64 Alon Bar-Lev
2006-09-03 22:15 [PATCH 00/26] Dynamic kernel command-line - Resend please ignore last Alon Bar-Lev
2006-09-03 22:19 ` [PATCH 10/26] Dynamic kernel command-line - ia64 Alon Bar-Lev
2006-09-03 21:50 [PATCH 00/26] Dynamic kernel command-line Alon Bar-Lev
2006-09-03 21:56 ` [PATCH 10/26] Dynamic kernel command-line - ia64 Alon Bar-Lev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070127002453.57b1e071.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=alon.barlev@gmail.com \
--cc=bwalle@suse.de \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome