mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: "Alon Bar-Lev" <alon.barlev@gmail.com>
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	"Bernhard Walle" <bwalle@suse.de>
Subject: Re: [PATCH 10/26] Dynamic kernel command-line - ia64
Date: Sat, 27 Jan 2007 00:44:11 -0800	[thread overview]
Message-ID: <20070127004411.b0d5872e.akpm@osdl.org> (raw)
In-Reply-To: <9e0cf0bf0701270034w491ff69dnb6019b4dd30f6d54@mail.gmail.com>

On Sat, 27 Jan 2007 10:34:27 +0200
"Alon Bar-Lev" <alon.barlev@gmail.com> wrote:

> > Please.  Go through the entire patchset, yank all those wrong private
> > declarations of boot_command_line[] and put a *single, kernel-wide*
> > declaration into a single, shared header file.
> 
> I thought of this, while I was making the patch, I could not understand why
> the maintainer did not simply #include <linux/init.h>

"ooh, I'll get in trouble if I edit a non-arch file, and it's a hassle to
add another file to my changeset and I can't be assed testing other
architectures and nobody's looking so I'll just sneak it in there".

> I can add this to any module which declares this by-itself but because
> I cannot test all arch, I am afraid it will cause more problems.
> 
> Preparing a patch... :)

Against next -mm, please.

  reply	other threads:[~2007-01-27  8:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200701230010.34323.alon.barlev@gmail.com>
     [not found] ` <200701230014.06793.alon.barlev@gmail.com>
2007-01-27  8:24   ` Andrew Morton
2007-01-27  8:34     ` Alon Bar-Lev
2007-01-27  8:44       ` Andrew Morton [this message]
2007-01-27 20:49         ` [PATCH] Dynamic kernel command-line - fixups Alon Bar-Lev
2007-01-18 12:58 [patch 00/26] Dynamic kernel command-line Bernhard Walle
2007-01-18 12:58 ` [patch 10/26] Dynamic kernel command-line - ia64 Bernhard Walle
  -- strict thread matches above, loose matches on Subject: below --
2006-12-02 10:47 [PATCH 00/26] Dynamic kernel command-line Alon Bar-Lev
2006-12-02 10:51 ` [PATCH 10/26] Dynamic kernel command-line - ia64 Alon Bar-Lev
2006-09-03 22:15 [PATCH 00/26] Dynamic kernel command-line - Resend please ignore last Alon Bar-Lev
2006-09-03 22:19 ` [PATCH 10/26] Dynamic kernel command-line - ia64 Alon Bar-Lev
2006-09-03 21:50 [PATCH 00/26] Dynamic kernel command-line Alon Bar-Lev
2006-09-03 21:56 ` [PATCH 10/26] Dynamic kernel command-line - ia64 Alon Bar-Lev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070127004411.b0d5872e.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=alon.barlev@gmail.com \
    --cc=bwalle@suse.de \
    --cc=hpa@zytor.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome