From: "Alon Bar-Lev" <alon.barlev@gmail.com>
To: "Andrew Morton" <akpm@osdl.org>
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
"H. Peter Anvin" <hpa@zytor.com>,
"Bernhard Walle" <bwalle@suse.de>
Subject: Re: [PATCH 10/26] Dynamic kernel command-line - ia64
Date: Sat, 27 Jan 2007 10:34:27 +0200 [thread overview]
Message-ID: <9e0cf0bf0701270034w491ff69dnb6019b4dd30f6d54@mail.gmail.com> (raw)
In-Reply-To: <20070127002453.57b1e071.akpm@osdl.org>
On 1/27/07, Andrew Morton <akpm@osdl.org> wrote:
> no no no no no no no. Just because some whacked-out weenie went and put
> extern declarations in .c files doesn't mean that we should copy them.
>
> It doesn't even compile.
Sorry... I don't have all environments.
> Please. Go through the entire patchset, yank all those wrong private
> declarations of boot_command_line[] and put a *single, kernel-wide*
> declaration into a single, shared header file.
I thought of this, while I was making the patch, I could not understand why
the maintainer did not simply #include <linux/init.h>
I can add this to any module which declares this by-itself but because
I cannot test all arch, I am afraid it will cause more problems.
Preparing a patch... :)
Best Regards,
Alon Bar-Lev.
next prev parent reply other threads:[~2007-01-27 8:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200701230010.34323.alon.barlev@gmail.com>
[not found] ` <200701230014.06793.alon.barlev@gmail.com>
2007-01-27 8:24 ` Andrew Morton
2007-01-27 8:34 ` Alon Bar-Lev [this message]
2007-01-27 8:44 ` Andrew Morton
2007-01-27 20:49 ` [PATCH] Dynamic kernel command-line - fixups Alon Bar-Lev
2007-01-18 12:58 [patch 00/26] Dynamic kernel command-line Bernhard Walle
2007-01-18 12:58 ` [patch 10/26] Dynamic kernel command-line - ia64 Bernhard Walle
-- strict thread matches above, loose matches on Subject: below --
2006-12-02 10:47 [PATCH 00/26] Dynamic kernel command-line Alon Bar-Lev
2006-12-02 10:51 ` [PATCH 10/26] Dynamic kernel command-line - ia64 Alon Bar-Lev
2006-09-03 22:15 [PATCH 00/26] Dynamic kernel command-line - Resend please ignore last Alon Bar-Lev
2006-09-03 22:19 ` [PATCH 10/26] Dynamic kernel command-line - ia64 Alon Bar-Lev
2006-09-03 21:50 [PATCH 00/26] Dynamic kernel command-line Alon Bar-Lev
2006-09-03 21:56 ` [PATCH 10/26] Dynamic kernel command-line - ia64 Alon Bar-Lev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e0cf0bf0701270034w491ff69dnb6019b4dd30f6d54@mail.gmail.com \
--to=alon.barlev@gmail.com \
--cc=akpm@osdl.org \
--cc=bwalle@suse.de \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®