[PATCH] Replace misspelled "PRINTK" with "CONFIG_PRINTK".

[PATCH] Replace misspelled "PRINTK" with "CONFIG_PRINTK".

[Robert P. J. Day]

  Replace the apparently misspelled preprocessor variable "PRINTK"
with "CONFIG_PRINTK".

Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>

---

  not sure who the official maintainer here is, sorry.

diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c
index 5554ada..0c09772 100644
--- a/drivers/md/bitmap.c
+++ b/drivers/md/bitmap.c
@@ -53,7 +53,7 @@
 //#define DPRINTK PRINTK /* set this NULL to avoid verbose debug output */
 #define DPRINTK(x...) do { } while(0)

-#ifndef PRINTK
+#ifndef CONFIG_PRINTK
 #  if DEBUG > 0
 #    define PRINTK(x...) printk(KERN_DEBUG x)
 #  else

-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================

Re: [PATCH] Replace misspelled "PRINTK" with "CONFIG_PRINTK".

[Dave Jones]

On Wed, Mar 07, 2007 at 06:38:32PM -0500, Robert P. J. Day wrote:
 > 
 >   Replace the apparently misspelled preprocessor variable "PRINTK"
 > with "CONFIG_PRINTK".

this looks wrong.
 
 > diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c
 > index 5554ada..0c09772 100644
 > --- a/drivers/md/bitmap.c
 > +++ b/drivers/md/bitmap.c
 > @@ -53,7 +53,7 @@
 >  //#define DPRINTK PRINTK /* set this NULL to avoid verbose debug output */
 >  #define DPRINTK(x...) do { } while(0)
 > 
 > -#ifndef PRINTK
 > +#ifndef CONFIG_PRINTK
 >  #  if DEBUG > 0
 >  #    define PRINTK(x...) printk(KERN_DEBUG x)
 >  #  else

the intention here is to only define 'PRINTK' if no-one else
has defined it already.

	Dave

-- 
http://www.codemonkey.org.uk

Re: [PATCH] Replace misspelled "PRINTK" with "CONFIG_PRINTK".

[Robert P. J. Day]

On Wed, 7 Mar 2007, Dave Jones wrote:

> On Wed, Mar 07, 2007 at 06:38:32PM -0500, Robert P. J. Day wrote:
>  >
>  >   Replace the apparently misspelled preprocessor variable "PRINTK"
>  > with "CONFIG_PRINTK".
>
> this looks wrong.
>
>  > diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c
>  > index 5554ada..0c09772 100644
>  > --- a/drivers/md/bitmap.c
>  > +++ b/drivers/md/bitmap.c
>  > @@ -53,7 +53,7 @@
>  >  //#define DPRINTK PRINTK /* set this NULL to avoid verbose debug output */
>  >  #define DPRINTK(x...) do { } while(0)
>  >
>  > -#ifndef PRINTK
>  > +#ifndef CONFIG_PRINTK
>  >  #  if DEBUG > 0
>  >  #    define PRINTK(x...) printk(KERN_DEBUG x)
>  >  #  else
>
> the intention here is to only define 'PRINTK' if no-one else
> has defined it already.

oops, sorry, i misread that.

rday
-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================

Re: [PATCH] Replace misspelled "PRINTK" with "CONFIG_PRINTK".

[Neil Brown]

On Wednesday March 7, rpjday@mindspring.com wrote:
> 
>   Replace the apparently misspelled preprocessor variable "PRINTK"
> with "CONFIG_PRINTK".

No, it is meant to be "PRINTK".
It dates way way back before my time, but presumably the idea was you
could -DPRINTK=something and if you didn't do that, it would figure
out what it thought you wanted.

Definitely not meant to be CONFIG_PRINTK.

NeilBrown


> 
> Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
> 
> ---
> 
>   not sure who the official maintainer here is, sorry.
> 
> diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c
> index 5554ada..0c09772 100644
> --- a/drivers/md/bitmap.c
> +++ b/drivers/md/bitmap.c
> @@ -53,7 +53,7 @@
>  //#define DPRINTK PRINTK /* set this NULL to avoid verbose debug output */
>  #define DPRINTK(x...) do { } while(0)
> 
> -#ifndef PRINTK
> +#ifndef CONFIG_PRINTK
>  #  if DEBUG > 0
>  #    define PRINTK(x...) printk(KERN_DEBUG x)
>  #  else
> 
> -- 
> ========================================================================
> Robert P. J. Day
> Linux Consulting, Training and Annoying Kernel Pedantry
> Waterloo, Ontario, CANADA
> 
> http://fsdev.net/wiki/index.php?title=Main_Page
> ========================================================================
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/