mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yasunori Goto <y-goto@jp.fujitsu.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Mel Gorman <mel@csn.ul.ie>
Subject: [PATCH] fix BUG_ON check at move_freepages() (Re: 2.6.21-rc3-mm2)
Date: Thu, 08 Mar 2007 16:39:43 +0900	[thread overview]
Message-ID: <20070308162944.FB7F.Y-GOTO@jp.fujitsu.com> (raw)
In-Reply-To: <20070307201915.4d579113.akpm@linux-foundation.org>


Hello.

The BUG_ON() check at move_freepages() is wrong.
Its end_page is start_page + MAX_ORDER_NR_PAGES. So, it can be 
next zone. BUG_ON() should check "end_page - 1".

This is fix of 2.6.21-rc3-mm2 for it.

Signed-off-by: Yasunori Goto <y-goto@jp.fujitsu.com>

---
 mm/page_alloc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: current_test/mm/page_alloc.c
===================================================================
--- current_test.orig/mm/page_alloc.c	2007-03-08 15:44:10.000000000 +0900
+++ current_test/mm/page_alloc.c	2007-03-08 16:17:29.000000000 +0900
@@ -707,7 +707,7 @@ int move_freepages(struct zone *zone,
 	unsigned long order;
 	int blocks_moved = 0;
 
-	BUG_ON(page_zone(start_page) != page_zone(end_page));
+	BUG_ON(page_zone(start_page) != page_zone(end_page - 1));
 
 	for (page = start_page; page < end_page;) {
 		if (!PageBuddy(page)) {

-- 
Yasunori Goto 



  reply	other threads:[~2007-03-08  7:41 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-08  4:19 2.6.21-rc3-mm2 Andrew Morton
2007-03-08  7:39 ` Yasunori Goto [this message]
2007-03-08 11:01   ` [PATCH] fix BUG_ON check at move_freepages() (Re: 2.6.21-rc3-mm2) Mel Gorman
2007-03-08 14:52 ` 2.6.21-rc3-mm2 Con Kolivas
2007-03-08 21:04   ` 2.6.21-rc3-mm2 Con Kolivas
2007-03-08 21:56   ` 2.6.21-rc3: /proc broken Con Kolivas
2007-03-09  8:53     ` Russell King
2007-03-09  9:59       ` Con Kolivas
2007-03-12 12:56 ` 2.6.21-rc3-mm2 hangs my opteron during bootup, ACPI? Helge Hafting
2007-03-12 13:25   ` Luming Yu
2007-03-12 19:56     ` Len Brown
2007-03-17  0:10       ` Helge Hafting
2007-03-14  3:52 ` 2.6.21-rc3-mm2 (oops in move_freepages) Bjorn Helgaas
2007-03-14  9:44   ` Mel Gorman
2007-03-14 15:11     ` Bjorn Helgaas
2007-03-14 16:13       ` Mel Gorman
2007-03-14 16:52         ` Bjorn Helgaas
2007-03-14 17:21           ` Mel Gorman
2007-03-14 18:36             ` Bjorn Helgaas
2007-03-14 18:59               ` Mel Gorman
2007-03-14 20:46                 ` Bjorn Helgaas
2007-03-14 20:55                   ` Mel Gorman
2007-03-14 19:10               ` [PATCH] Avoid unsafe use of struct pages in move_freepages when CONFIG_HOLES_IN_ZONE is set Mel Gorman
     [not found] ` <200703141457.06489.bjorn.helgaas@hp.com>
2007-03-15  1:14   ` 2.6.21-rc3-mm2 (BUG in pci_restore_state()) Eric W. Biederman
2007-03-19 19:17 ` 2.6.21-rc3-mm2 Randy Dunlap
2007-03-19 19:55   ` 2.6.21-rc3-mm2 Andrew Morton
2007-03-19 23:01     ` 2.6.21-rc3-mm2 Kay Sievers
2007-03-19 19:40 ` 2.6.21-rc3-mm2 Randy Dunlap
2007-03-19 22:26   ` [PATCH] ptrace needs PROC_FS Randy Dunlap
2007-03-19 22:48     ` Roland McGrath
2007-03-20 11:18       ` Pavel Machek
2007-03-20  0:27 ` 2.6.21-rc3-mm2 Randy Dunlap
2007-03-20  0:39   ` 2.6.21-rc3-mm2 Andrew Morton
2007-03-20  0:51     ` 2.6.21-rc3-mm2 Randy Dunlap
2007-03-20 18:51     ` 2.6.21-rc3-mm2 Roland McGrath
2007-03-20 12:14   ` 2.6.21-rc3-mm2 Sam Ravnborg
2007-03-20 15:43     ` 2.6.21-rc3-mm2 Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070308162944.FB7F.Y-GOTO@jp.fujitsu.com \
    --to=y-goto@jp.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mel@csn.ul.ie \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome