mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: 2.6.21-rc3-mm2 (BUG in pci_restore_state())
Date: Wed, 14 Mar 2007 19:14:24 -0600	[thread overview]
Message-ID: <m1k5xjpatr.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <200703141457.06489.bjorn.helgaas@hp.com> (Bjorn Helgaas's message of "Wed, 14 Mar 2007 14:57:06 -0600")

Bjorn Helgaas <bjorn.helgaas@hp.com> writes:

> In 2.6.21-rc3-mm2 (plus some move_freepages() bugfixes), I hit one
> of the warnings added by Eric's msi-debug-code.patch.  This is on an
> ia64 box, an HP rx2600.  Let me know if I can collect more information.

I think we are good. How pci_save_state and pci_restore_state were
implemented and how they were used were out of sync.  tg3 was one
of the drivers where pci_save_state and pci_restore_state were used
as part of the reset routine and were not used in pairs.

Which when combined with a pci-x or a pci-express capability
resulted in a memory leak, (that I was warning about).  This
has now been corrected upstream.

And the condition I was warning about non paired pci_save_state and
pci_restore_state is no longer a problem.

Eric

  parent reply	other threads:[~2007-03-15  1:14 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-08  4:19 2.6.21-rc3-mm2 Andrew Morton
2007-03-08  7:39 ` [PATCH] fix BUG_ON check at move_freepages() (Re: 2.6.21-rc3-mm2) Yasunori Goto
2007-03-08 11:01   ` Mel Gorman
2007-03-08 14:52 ` 2.6.21-rc3-mm2 Con Kolivas
2007-03-08 21:04   ` 2.6.21-rc3-mm2 Con Kolivas
2007-03-08 21:56   ` 2.6.21-rc3: /proc broken Con Kolivas
2007-03-09  8:53     ` Russell King
2007-03-09  9:59       ` Con Kolivas
2007-03-12 12:56 ` 2.6.21-rc3-mm2 hangs my opteron during bootup, ACPI? Helge Hafting
2007-03-12 13:25   ` Luming Yu
2007-03-12 19:56     ` Len Brown
2007-03-17  0:10       ` Helge Hafting
2007-03-14  3:52 ` 2.6.21-rc3-mm2 (oops in move_freepages) Bjorn Helgaas
2007-03-14  9:44   ` Mel Gorman
2007-03-14 15:11     ` Bjorn Helgaas
2007-03-14 16:13       ` Mel Gorman
2007-03-14 16:52         ` Bjorn Helgaas
2007-03-14 17:21           ` Mel Gorman
2007-03-14 18:36             ` Bjorn Helgaas
2007-03-14 18:59               ` Mel Gorman
2007-03-14 20:46                 ` Bjorn Helgaas
2007-03-14 20:55                   ` Mel Gorman
2007-03-14 19:10               ` [PATCH] Avoid unsafe use of struct pages in move_freepages when CONFIG_HOLES_IN_ZONE is set Mel Gorman
     [not found] ` <200703141457.06489.bjorn.helgaas@hp.com>
2007-03-15  1:14   ` Eric W. Biederman [this message]
2007-03-19 19:17 ` 2.6.21-rc3-mm2 Randy Dunlap
2007-03-19 19:55   ` 2.6.21-rc3-mm2 Andrew Morton
2007-03-19 23:01     ` 2.6.21-rc3-mm2 Kay Sievers
2007-03-19 19:40 ` 2.6.21-rc3-mm2 Randy Dunlap
2007-03-19 22:26   ` [PATCH] ptrace needs PROC_FS Randy Dunlap
2007-03-19 22:48     ` Roland McGrath
2007-03-20 11:18       ` Pavel Machek
2007-03-20  0:27 ` 2.6.21-rc3-mm2 Randy Dunlap
2007-03-20  0:39   ` 2.6.21-rc3-mm2 Andrew Morton
2007-03-20  0:51     ` 2.6.21-rc3-mm2 Randy Dunlap
2007-03-20 18:51     ` 2.6.21-rc3-mm2 Roland McGrath
2007-03-20 12:14   ` 2.6.21-rc3-mm2 Sam Ravnborg
2007-03-20 15:43     ` 2.6.21-rc3-mm2 Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1k5xjpatr.fsf@ebiederm.dsl.xmission.com \
    --to=ebiederm@xmission.com \
    --cc=akpm@linux-foundation.org \
    --cc=bjorn.helgaas@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®