[PATCH] DVB: Delete unused header file linux/dvb/version.h.

[PATCH] DVB: Delete unused header file linux/dvb/version.h.

[Robert P. J. Day]

Delete the unreferenced header file include/linux/dvb/version.h.

Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>

---

diff --git a/include/linux/dvb/version.h b/include/linux/dvb/version.h
deleted file mode 100644
index 6183c9c..0000000
--- a/include/linux/dvb/version.h
+++ /dev/null
@@ -1,29 +0,0 @@
-/*
- * version.h
- *
- * Copyright (C) 2000 Holger Waechtler <holger@convergence.de>
- *                    for convergence integrated media GmbH
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public License
- * as published by the Free Software Foundation; either version 2.1
- * of the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
- *
- */
-
-#ifndef _DVBVERSION_H_
-#define _DVBVERSION_H_
-
-#define DVB_API_VERSION 3
-#define DVB_API_VERSION_MINOR 1
-
-#endif /*_DVBVERSION_H_*/
-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================

Re: [v4l-dvb-maintainer] [PATCH] DVB: Delete unused header file linux/dvb/version.h.

[Marcel Siegert]

On Friday 23 March 2007, Robert P. J. Day wrote:
> 
> Delete the unreferenced header file include/linux/dvb/version.h.
> 
> Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
> 
NACK
this header is unreferenced in kernel, but used for applications that compile for userspace
to determine the api version.

regards 
marcel

> ---
> 
> diff --git a/include/linux/dvb/version.h b/include/linux/dvb/version.h
> deleted file mode 100644
> index 6183c9c..0000000
> --- a/include/linux/dvb/version.h
> +++ /dev/null
> @@ -1,29 +0,0 @@
> -/*
> - * version.h
> - *
> - * Copyright (C) 2000 Holger Waechtler <holger@convergence.de>
> - *                    for convergence integrated media GmbH
> - *
> - * This program is free software; you can redistribute it and/or
> - * modify it under the terms of the GNU Lesser General Public License
> - * as published by the Free Software Foundation; either version 2.1
> - * of the License, or (at your option) any later version.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> - * GNU General Public License for more details.
> - *
> - * You should have received a copy of the GNU Lesser General Public License
> - * along with this program; if not, write to the Free Software
> - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
> - *
> - */
> -
> -#ifndef _DVBVERSION_H_
> -#define _DVBVERSION_H_
> -
> -#define DVB_API_VERSION 3
> -#define DVB_API_VERSION_MINOR 1
> -
> -#endif /*_DVBVERSION_H_*/

Re: [v4l-dvb-maintainer] [PATCH] DVB: Delete unused header file linux/dvb/version.h.

[Robert P. J. Day]

On Fri, 23 Mar 2007, Marcel Siegert wrote:

> On Friday 23 March 2007, Robert P. J. Day wrote:
> >
> > Delete the unreferenced header file include/linux/dvb/version.h.
> >
> > Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
> >
> NACK
> this header is unreferenced in kernel, but used for applications that compile for userspace
> to determine the api version.

ah.  i didn't notice that that file was being exported to userspace.
my fault.

rday
-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================

Re: [v4l-dvb-maintainer] [PATCH] DVB: Delete unused header file linux/dvb/version.h.

[Arjan van de Ven]

On Fri, 2007-03-23 at 16:47 +0100, Marcel Siegert wrote:
> On Friday 23 March 2007, Robert P. J. Day wrote:
> > 
> > Delete the unreferenced header file include/linux/dvb/version.h.
> > 
> > Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
> > 
> NACK
> this header is unreferenced in kernel, but used for applications that compile for userspace
> to determine the api version.


btw that is something extremely evil to do. Either you have varying apis
between kernels (which is naughty, but I suppose you can go up in
capabilities) or it's fully static. 

If it's dynamic, doing it compiletime is BAD. The same binaries should
run on multiple kernels after all. An ioctl or a sysfs thing or
something is a lot better than a compile time constant.

If it's entirely static exposing a "version" doesn't mean anything and
it might as well be killed...

Greetings,
   Arjan van de Ven

Re: [v4l-dvb-maintainer] [PATCH] DVB: Delete unused header file linux/dvb/version.h.

[Marcel Siegert]

On Friday 23 March 2007, Arjan van de Ven wrote:
> On Fri, 2007-03-23 at 16:47 +0100, Marcel Siegert wrote:
> > On Friday 23 March 2007, Robert P. J. Day wrote:
> > > 
> > > Delete the unreferenced header file include/linux/dvb/version.h.
> > > 
> > > Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
> > > 
> > NACK
> > this header is unreferenced in kernel, but used for applications that compile for userspace
> > to determine the api version.
> 
> 
> btw that is something extremely evil to do. Either you have varying apis
> between kernels (which is naughty, but I suppose you can go up in
> capabilities) or it's fully static. 
> 
> If it's dynamic, doing it compiletime is BAD. The same binaries should
> run on multiple kernels after all. An ioctl or a sysfs thing or
> something is a lot better than a compile time constant.
> 
> If it's entirely static exposing a "version" doesn't mean anything and
> it might as well be killed...
> 
> Greetings,
>    Arjan van de Ven
 
hi arjan, 

we discussed that topic - an IOCTL to determine the api version - on dvb ml in nov.2005 and
got no result. so this is still there and will stay imho, until we will find a solution.

regards
marcel

Re: [v4l-dvb-maintainer] [PATCH] DVB: Delete unused header file linux/dvb/version.h.

[Manu Abraham]

On 3/23/07, Arjan van de Ven <arjan@infradead.org> wrote:
> On Fri, 2007-03-23 at 16:47 +0100, Marcel Siegert wrote:
> > On Friday 23 March 2007, Robert P. J. Day wrote:
> > >
> > > Delete the unreferenced header file include/linux/dvb/version.h.
> > >
> > > Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
> > >
> > NACK
> > this header is unreferenced in kernel, but used for applications that compile for userspace
> > to determine the api version.
>
>
> btw that is something extremely evil to do. Either you have varying apis
> between kernels (which is naughty, but I suppose you can go up in
> capabilities) or it's fully static.
>


There are cases where we need an API update since newer systems do show up.
In such a case, the only way is to provide backward compatibility
while adding in newer stuff.

Currently we use the version major/minor for the userspace to identify
the in kernel API, while the userspace apps can remain binary
compatible



Regards,
Manu

Re: [v4l-dvb-maintainer] [PATCH] DVB: Delete unused header file linux/dvb/version.h.

[Arjan van de Ven]

> There are cases where we need an API update since newer systems do show up.
> In such a case, the only way is to provide backward compatibility
> while adding in newer stuff.
> 
> Currently we use the version major/minor for the userspace to identify
> the in kernel API, while the userspace apps can remain binary
> compatible

this is the problem exactly! Your userspace binary knows about the
kernel headers it was compiled against, not about the actual running
kernel! They are very likely not the same.

-- 
if you want to mail me at work (you don't), use arjan (at) linux.intel.com
Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org

Re: [v4l-dvb-maintainer] [PATCH] DVB: Delete unused header file linux/dvb/version.h.

[Manu Abraham]

On 3/25/07, Arjan van de Ven <arjan@infradead.org> wrote:
>
>
> > There are cases where we need an API update since newer systems do show up.
> > In such a case, the only way is to provide backward compatibility
> > while adding in newer stuff.
> >
> > Currently we use the version major/minor for the userspace to identify
> > the in kernel API, while the userspace apps can remain binary
> > compatible
>
> this is the problem exactly! Your userspace binary knows about the
> kernel headers it was compiled against, not about the actual running
> kernel! They are very likely not the same.

Well, we could go for an IOCTL in such a case to avoid the unpleasant scenario.


Manu