[patch 0/7] Add IRQF_IRQPOLL_IRQ flag to allow irqpoll

[patch 0/7] Add IRQF_IRQPOLL_IRQ flag to allow irqpoll

[Bernhard Walle]

irqpoll is broken on some architectures that don't use the IRQ 0 for the timer
interrupt like IA64. This patch adds a IRQF_IRQPOLL_IRQ flag.

Each architecture is handled in a separate pach. As I left the irq == 0 as
condition, this should not break existing architectures that use timer_irq == 0
and that I did't address with that patch (because I don't know).


Signed-off-by: Bernhard Walle <bwalle@suse.de>

[patch 1/7] Add IRQF_IRQPOLL_IRQ flag (common code)

[Bernhard Walle]

[-- Attachment #1: IRQF_IRQPOLL_IRQ --]
[-- Type: text/plain, Size: 2761 bytes --]

This patch adds a IRQF_IRQPOLL_IRQ flag that the interrupt registration code
could use for the interrupt it wants to use for IRQ polling.

Because this must not be the timer interrupt, an additional flag was added
instead of re-using the IRQF_TIMER constant. Until all architectures will have
an IRQF_IRQPOLL_IRQ interrupt, irq == 0 will stay as alternative as it should
not break anything.

Also, note_interrupt() is called on CPU-specific interrupts to be used as
interrupt source for IRQ polling.


Signed-off-by: Bernhard Walle <bwalle@suse.de>
---
 include/linux/interrupt.h |    4 ++++
 kernel/irq/handle.c       |    2 ++
 kernel/irq/spurious.c     |    4 +++-
 3 files changed, 9 insertions(+), 1 deletion(-)

Index: linux-2.6.21-rc4-mm1/include/linux/interrupt.h
===================================================================
--- linux-2.6.21-rc4-mm1.orig/include/linux/interrupt.h
+++ linux-2.6.21-rc4-mm1/include/linux/interrupt.h
@@ -44,6 +44,9 @@
  * IRQF_TIMER - Flag to mark this interrupt as timer interrupt
  * IRQF_PERCPU - Interrupt is per cpu
  * IRQF_NOBALANCING - Flag to exclude this interrupt from irq balancing
+ * IRQF_IRQPOLL_IRQ - Interrupt is used for polling (only the interrupt that is
+ *                    registered first in an shared interrupt is considered for
+ *                    performance reasons)
  */
 #define IRQF_DISABLED		0x00000020
 #define IRQF_SAMPLE_RANDOM	0x00000040
@@ -52,6 +55,7 @@
 #define IRQF_TIMER		0x00000200
 #define IRQF_PERCPU		0x00000400
 #define IRQF_NOBALANCING	0x00000800
+#define IRQF_IRQPOLL_IRQ	0x00001000
 
 /*
  * Migration helpers. Scheduled for removal in 1/2007
Index: linux-2.6.21-rc4-mm1/kernel/irq/handle.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/kernel/irq/handle.c
+++ linux-2.6.21-rc4-mm1/kernel/irq/handle.c
@@ -180,6 +180,8 @@ fastcall unsigned int __do_IRQ(unsigned 
 		if (desc->chip->ack)
 			desc->chip->ack(irq);
 		action_ret = handle_IRQ_event(irq, desc->action);
+		if (!noirqdebug)
+			note_interrupt(irq, desc, action_ret);
 		desc->chip->end(irq);
 		return 1;
 	}
Index: linux-2.6.21-rc4-mm1/kernel/irq/spurious.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/kernel/irq/spurious.c
+++ linux-2.6.21-rc4-mm1/kernel/irq/spurious.c
@@ -146,7 +146,9 @@ void note_interrupt(unsigned int irq, st
 
 	if (unlikely(irqfixup)) {
 		/* Don't punish working computers */
-		if ((irqfixup == 2 && irq == 0) || action_ret == IRQ_NONE) {
+		if ((irqfixup == 2 && ((irq == 0) ||
+				(desc->action->flags & IRQF_IRQPOLL_IRQ))) ||
+				action_ret == IRQ_NONE) {
 			int ok = misrouted_irq(irq);
 			if (action_ret == IRQ_NONE)
 				desc->irqs_unhandled -= ok;

-- 

[patch 2/7] Add IRQF_IRQPOLL_IRQ flag on IA64

[Bernhard Walle]

[-- Attachment #1: IRQF_IRQPOLL_IRQ-IA64 --]
[-- Type: text/plain, Size: 631 bytes --]

Add IRQF_IRQPOLL_IRQ for the timer interrupt on IA64.

Signed-off-by: Bernhard Walle <bwalle@suse.de>
---
 arch/ia64/kernel/time.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.21-rc4-mm1/arch/ia64/kernel/time.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/arch/ia64/kernel/time.c
+++ linux-2.6.21-rc4-mm1/arch/ia64/kernel/time.c
@@ -235,7 +235,7 @@ ia64_init_itm (void)
 
 static struct irqaction timer_irqaction = {
 	.handler =	timer_interrupt,
-	.flags =	IRQF_DISABLED,
+	.flags =	IRQF_DISABLED | IRQF_IRQPOLL_IRQ,
 	.name =		"timer"
 };
 

-- 

[patch 3/7] Add IRQF_IRQPOLL_IRQ flag on x86_64

[Bernhard Walle]

[-- Attachment #1: IRQF_IRQPOLL_IRQ-x86_64 --]
[-- Type: text/plain, Size: 784 bytes --]

Add IRQF_IRQPOLL_IRQ for the timer interrupt on x86_64.

Signed-off-by: Bernhard Walle <bwalle@suse.de>
Cc: Andi Kleen <ak@suse.de>
---
 arch/x86_64/kernel/time.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Index: linux-2.6.21-rc4-mm1/arch/x86_64/kernel/time.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/arch/x86_64/kernel/time.c
+++ linux-2.6.21-rc4-mm1/arch/x86_64/kernel/time.c
@@ -317,7 +317,10 @@ void __init stop_timer_interrupt(void)
 }
 
 static struct irqaction irq0 = {
-	timer_interrupt, IRQF_DISABLED, CPU_MASK_NONE, "timer", NULL, NULL
+	.handler	= timer_interrupt,
+	.flags		= IRQF_DISABLED | IRQF_IRQPOLL_IRQ,
+	.mask		= CPU_MASK_NONE,
+	.name 		= "timer"
 };
 
 void __init time_init(void)

-- 

[patch 4/7] Add IRQF_IRQPOLL_IRQ flag on arm

[Bernhard Walle]

[-- Attachment #1: IRQF_IRQPOLL_IRQ-arm --]
[-- Type: text/plain, Size: 18196 bytes --]

Add IRQF_IRQPOLL_IRQ for each timer interrupt.

Signed-off-by: Bernhard Walle <bwalle@suse.de>
---
 arch/arm/mach-aaec2000/core.c            |    2 +-
 arch/arm/mach-at91/at91rm9200_time.c     |    2 +-
 arch/arm/mach-at91/at91sam926x_time.c    |    2 +-
 arch/arm/mach-clps711x/time.c            |    2 +-
 arch/arm/mach-clps7500/core.c            |    2 +-
 arch/arm/mach-ebsa110/core.c             |    2 +-
 arch/arm/mach-ep93xx/core.c              |    2 +-
 arch/arm/mach-footbridge/dc21285-timer.c |    2 +-
 arch/arm/mach-footbridge/isa-timer.c     |    2 +-
 arch/arm/mach-h720x/cpu-h7201.c          |    2 +-
 arch/arm/mach-h720x/cpu-h7202.c          |    2 +-
 arch/arm/mach-imx/time.c                 |    2 +-
 arch/arm/mach-integrator/core.c          |    2 +-
 arch/arm/mach-ixp2000/core.c             |    2 +-
 arch/arm/mach-ixp23xx/core.c             |    2 +-
 arch/arm/mach-ixp4xx/common.c            |    2 +-
 arch/arm/mach-lh7a40x/time.c             |    2 +-
 arch/arm/mach-netx/time.c                |    2 +-
 arch/arm/mach-ns9xxx/time.c              |    2 +-
 arch/arm/mach-omap1/time.c               |    2 +-
 arch/arm/mach-omap2/timer-gp.c           |    2 +-
 arch/arm/mach-pnx4008/time.c             |    2 +-
 arch/arm/mach-pxa/time.c                 |    2 +-
 arch/arm/mach-realview/core.c            |    2 +-
 arch/arm/mach-sa1100/h3600.c             |    2 +-
 arch/arm/mach-sa1100/time.c              |    2 +-
 arch/arm/mach-shark/core.c               |    2 +-
 arch/arm/mach-versatile/core.c           |    2 +-
 arch/arm/plat-iop/time.c                 |    2 +-
 arch/arm/plat-omap/timer32k.c            |    2 +-
 arch/arm/plat-s3c24xx/time.c             |    2 +-
 31 files changed, 31 insertions(+), 31 deletions(-)

Index: linux-2.6.21-rc4-mm1/arch/arm/mach-aaec2000/core.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/arch/arm/mach-aaec2000/core.c
+++ linux-2.6.21-rc4-mm1/arch/arm/mach-aaec2000/core.c
@@ -142,7 +142,7 @@ aaec2000_timer_interrupt(int irq, void *
 
 static struct irqaction aaec2000_timer_irq = {
 	.name		= "AAEC-2000 Timer Tick",
-	.flags		= IRQF_DISABLED | IRQF_TIMER,
+	.flags		= IRQF_DISABLED | IRQF_TIMER | IRQF_IRQPOLL_IRQ,
 	.handler	= aaec2000_timer_interrupt,
 };
 
Index: linux-2.6.21-rc4-mm1/arch/arm/mach-at91/at91rm9200_time.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/arch/arm/mach-at91/at91rm9200_time.c
+++ linux-2.6.21-rc4-mm1/arch/arm/mach-at91/at91rm9200_time.c
@@ -87,7 +87,7 @@ static irqreturn_t at91rm9200_timer_inte
 
 static struct irqaction at91rm9200_timer_irq = {
 	.name		= "at91_tick",
-	.flags		= IRQF_SHARED | IRQF_DISABLED | IRQF_TIMER,
+	.flags		= IRQF_SHARED | IRQF_DISABLED | IRQF_TIMER | IRQF_IRQPOLL_IRQ,
 	.handler	= at91rm9200_timer_interrupt
 };
 
Index: linux-2.6.21-rc4-mm1/arch/arm/mach-at91/at91sam926x_time.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/arch/arm/mach-at91/at91sam926x_time.c
+++ linux-2.6.21-rc4-mm1/arch/arm/mach-at91/at91sam926x_time.c
@@ -66,7 +66,7 @@ static irqreturn_t at91sam926x_timer_int
 
 static struct irqaction at91sam926x_timer_irq = {
 	.name		= "at91_tick",
-	.flags		= IRQF_SHARED | IRQF_DISABLED | IRQF_TIMER,
+	.flags		= IRQF_SHARED | IRQF_DISABLED | IRQF_TIMER | IRQF_IRQPOLL_IRQ,
 	.handler	= at91sam926x_timer_interrupt
 };
 
Index: linux-2.6.21-rc4-mm1/arch/arm/mach-clps711x/time.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/arch/arm/mach-clps711x/time.c
+++ linux-2.6.21-rc4-mm1/arch/arm/mach-clps711x/time.c
@@ -58,7 +58,7 @@ p720t_timer_interrupt(int irq, void *dev
 
 static struct irqaction clps711x_timer_irq = {
 	.name		= "CLPS711x Timer Tick",
-	.flags		= IRQF_DISABLED | IRQF_TIMER,
+	.flags		= IRQF_DISABLED | IRQF_TIMER | IRQF_IRQPOLL_IRQ,
 	.handler	= p720t_timer_interrupt,
 };
 
Index: linux-2.6.21-rc4-mm1/arch/arm/mach-clps7500/core.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/arch/arm/mach-clps7500/core.c
+++ linux-2.6.21-rc4-mm1/arch/arm/mach-clps7500/core.c
@@ -316,7 +316,7 @@ clps7500_timer_interrupt(int irq, void *
 
 static struct irqaction clps7500_timer_irq = {
 	.name		= "CLPS7500 Timer Tick",
-	.flags		= IRQF_DISABLED | IRQF_TIMER,
+	.flags		= IRQF_DISABLED | IRQF_TIMER | IRQF_IRQPOLL_IRQ,
 	.handler	= clps7500_timer_interrupt,
 };
 
Index: linux-2.6.21-rc4-mm1/arch/arm/mach-ebsa110/core.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/arch/arm/mach-ebsa110/core.c
+++ linux-2.6.21-rc4-mm1/arch/arm/mach-ebsa110/core.c
@@ -199,7 +199,7 @@ ebsa110_timer_interrupt(int irq, void *d
 
 static struct irqaction ebsa110_timer_irq = {
 	.name		= "EBSA110 Timer Tick",
-	.flags		= IRQF_DISABLED | IRQF_TIMER,
+	.flags		= IRQF_DISABLED | IRQF_TIMER | IRQF_IRQPOLL_IRQ,
 	.handler	= ebsa110_timer_interrupt,
 };
 
Index: linux-2.6.21-rc4-mm1/arch/arm/mach-ep93xx/core.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/arch/arm/mach-ep93xx/core.c
+++ linux-2.6.21-rc4-mm1/arch/arm/mach-ep93xx/core.c
@@ -116,7 +116,7 @@ static int ep93xx_timer_interrupt(int ir
 
 static struct irqaction ep93xx_timer_irq = {
 	.name		= "ep93xx timer",
-	.flags		= IRQF_DISABLED | IRQF_TIMER,
+	.flags		= IRQF_DISABLED | IRQF_TIMER | IRQF_IRQPOLL_IRQ,
 	.handler	= ep93xx_timer_interrupt,
 };
 
Index: linux-2.6.21-rc4-mm1/arch/arm/mach-footbridge/dc21285-timer.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/arch/arm/mach-footbridge/dc21285-timer.c
+++ linux-2.6.21-rc4-mm1/arch/arm/mach-footbridge/dc21285-timer.c
@@ -44,7 +44,7 @@ timer1_interrupt(int irq, void *dev_id)
 static struct irqaction footbridge_timer_irq = {
 	.name		= "Timer1 timer tick",
 	.handler	= timer1_interrupt,
-	.flags		= IRQF_DISABLED | IRQF_TIMER,
+	.flags		= IRQF_DISABLED | IRQF_TIMER | IRQF_IRQPOLL_IRQ,
 };
 
 /*
Index: linux-2.6.21-rc4-mm1/arch/arm/mach-footbridge/isa-timer.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/arch/arm/mach-footbridge/isa-timer.c
+++ linux-2.6.21-rc4-mm1/arch/arm/mach-footbridge/isa-timer.c
@@ -73,7 +73,7 @@ isa_timer_interrupt(int irq, void *dev_i
 static struct irqaction isa_timer_irq = {
 	.name		= "ISA timer tick",
 	.handler	= isa_timer_interrupt,
-	.flags		= IRQF_DISABLED | IRQF_TIMER,
+	.flags		= IRQF_DISABLED | IRQF_TIMER | IRQF_IRQPOLL_IRQ,
 };
 
 static void __init isa_timer_init(void)
Index: linux-2.6.21-rc4-mm1/arch/arm/mach-h720x/cpu-h7201.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/arch/arm/mach-h720x/cpu-h7201.c
+++ linux-2.6.21-rc4-mm1/arch/arm/mach-h720x/cpu-h7201.c
@@ -41,7 +41,7 @@ h7201_timer_interrupt(int irq, void *dev
 
 static struct irqaction h7201_timer_irq = {
 	.name		= "h7201 Timer Tick",
-	.flags		= IRQF_DISABLED | IRQF_TIMER,
+	.flags		= IRQF_DISABLED | IRQF_TIMER | IRQF_IRQPOLL_IRQ,
 	.handler	= h7201_timer_interrupt,
 };
 
Index: linux-2.6.21-rc4-mm1/arch/arm/mach-h720x/cpu-h7202.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/arch/arm/mach-h720x/cpu-h7202.c
+++ linux-2.6.21-rc4-mm1/arch/arm/mach-h720x/cpu-h7202.c
@@ -170,7 +170,7 @@ static struct irq_chip h7202_timerx_chip
 
 static struct irqaction h7202_timer_irq = {
 	.name		= "h7202 Timer Tick",
-	.flags		= IRQF_DISABLED | IRQF_TIMER,
+	.flags		= IRQF_DISABLED | IRQF_TIMER | IRQF_IRQPOLL_IRQ,
 	.handler	= h7202_timer_interrupt,
 };
 
Index: linux-2.6.21-rc4-mm1/arch/arm/mach-imx/time.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/arch/arm/mach-imx/time.c
+++ linux-2.6.21-rc4-mm1/arch/arm/mach-imx/time.c
@@ -56,7 +56,7 @@ imx_timer_interrupt(int irq, void *dev_i
 
 static struct irqaction imx_timer_irq = {
 	.name		= "i.MX Timer Tick",
-	.flags		= IRQF_DISABLED | IRQF_TIMER,
+	.flags		= IRQF_DISABLED | IRQF_TIMER | IRQF_IRQPOLL_IRQ,
 	.handler	= imx_timer_interrupt,
 };
 
Index: linux-2.6.21-rc4-mm1/arch/arm/mach-integrator/core.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/arch/arm/mach-integrator/core.c
+++ linux-2.6.21-rc4-mm1/arch/arm/mach-integrator/core.c
@@ -282,7 +282,7 @@ integrator_timer_interrupt(int irq, void
 
 static struct irqaction integrator_timer_irq = {
 	.name		= "Integrator Timer Tick",
-	.flags		= IRQF_DISABLED | IRQF_TIMER,
+	.flags		= IRQF_DISABLED | IRQF_TIMER | IRQF_IRQPOLL_IRQ,
 	.handler	= integrator_timer_interrupt,
 };
 
Index: linux-2.6.21-rc4-mm1/arch/arm/mach-ixp2000/core.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/arch/arm/mach-ixp2000/core.c
+++ linux-2.6.21-rc4-mm1/arch/arm/mach-ixp2000/core.c
@@ -224,7 +224,7 @@ static int ixp2000_timer_interrupt(int i
 
 static struct irqaction ixp2000_timer_irq = {
 	.name		= "IXP2000 Timer Tick",
-	.flags		= IRQF_DISABLED | IRQF_TIMER,
+	.flags		= IRQF_DISABLED | IRQF_TIMER | IRQF_IRQPOLL_IRQ,
 	.handler	= ixp2000_timer_interrupt,
 };
 
Index: linux-2.6.21-rc4-mm1/arch/arm/mach-ixp23xx/core.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/arch/arm/mach-ixp23xx/core.c
+++ linux-2.6.21-rc4-mm1/arch/arm/mach-ixp23xx/core.c
@@ -363,7 +363,7 @@ ixp23xx_timer_interrupt(int irq, void *d
 static struct irqaction ixp23xx_timer_irq = {
 	.name		= "IXP23xx Timer Tick",
 	.handler	= ixp23xx_timer_interrupt,
-	.flags		= IRQF_DISABLED | IRQF_TIMER,
+	.flags		= IRQF_DISABLED | IRQF_TIMER | IRQF_IRQPOLL_IRQ,
 };
 
 void __init ixp23xx_init_timer(void)
Index: linux-2.6.21-rc4-mm1/arch/arm/mach-ixp4xx/common.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/arch/arm/mach-ixp4xx/common.c
+++ linux-2.6.21-rc4-mm1/arch/arm/mach-ixp4xx/common.c
@@ -265,7 +265,7 @@ static irqreturn_t ixp4xx_timer_interrup
 
 static struct irqaction ixp4xx_timer_irq = {
 	.name		= "IXP4xx Timer Tick",
-	.flags		= IRQF_DISABLED | IRQF_TIMER,
+	.flags		= IRQF_DISABLED | IRQF_TIMER | IRQF_IRQPOLL_IRQ,
 	.handler	= ixp4xx_timer_interrupt,
 };
 
Index: linux-2.6.21-rc4-mm1/arch/arm/mach-lh7a40x/time.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/arch/arm/mach-lh7a40x/time.c
+++ linux-2.6.21-rc4-mm1/arch/arm/mach-lh7a40x/time.c
@@ -53,7 +53,7 @@ lh7a40x_timer_interrupt(int irq, void *d
 
 static struct irqaction lh7a40x_timer_irq = {
 	.name		= "LHA740x Timer Tick",
-	.flags		= IRQF_DISABLED | IRQF_TIMER,
+	.flags		= IRQF_DISABLED | IRQF_TIMER | IRQF_IRQPOLL_IRQ,
 	.handler	= lh7a40x_timer_interrupt,
 };
 
Index: linux-2.6.21-rc4-mm1/arch/arm/mach-netx/time.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/arch/arm/mach-netx/time.c
+++ linux-2.6.21-rc4-mm1/arch/arm/mach-netx/time.c
@@ -47,7 +47,7 @@ netx_timer_interrupt(int irq, void *dev_
 
 static struct irqaction netx_timer_irq = {
 	.name           = "NetX Timer Tick",
-	.flags          = IRQF_DISABLED | IRQF_TIMER,
+	.flags          = IRQF_DISABLED | IRQF_TIMER | IRQF_IRQPOLL_IRQ,
 	.handler        = netx_timer_interrupt,
 };
 
Index: linux-2.6.21-rc4-mm1/arch/arm/mach-ns9xxx/time.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/arch/arm/mach-ns9xxx/time.c
+++ linux-2.6.21-rc4-mm1/arch/arm/mach-ns9xxx/time.c
@@ -53,7 +53,7 @@ static unsigned long ns9xxx_timer_gettim
 
 static struct irqaction ns9xxx_timer_irq = {
 	.name = "NS9xxx Timer Tick",
-	.flags = IRQF_DISABLED | IRQF_TIMER,
+	.flags = IRQF_DISABLED | IRQF_TIMER | IRQF_IRQPOLL_IRQ,
 	.handler = ns9xxx_timer_interrupt,
 };
 
Index: linux-2.6.21-rc4-mm1/arch/arm/mach-omap1/time.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/arch/arm/mach-omap1/time.c
+++ linux-2.6.21-rc4-mm1/arch/arm/mach-omap1/time.c
@@ -176,7 +176,7 @@ static irqreturn_t omap_mpu_timer_interr
 
 static struct irqaction omap_mpu_timer_irq = {
 	.name		= "mpu timer",
-	.flags		= IRQF_DISABLED | IRQF_TIMER,
+	.flags		= IRQF_DISABLED | IRQF_TIMER | IRQF_IRQPOLL_IRQ,
 	.handler	= omap_mpu_timer_interrupt,
 };
 
Index: linux-2.6.21-rc4-mm1/arch/arm/mach-omap2/timer-gp.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/arch/arm/mach-omap2/timer-gp.c
+++ linux-2.6.21-rc4-mm1/arch/arm/mach-omap2/timer-gp.c
@@ -52,7 +52,7 @@ static irqreturn_t omap2_gp_timer_interr
 
 static struct irqaction omap2_gp_timer_irq = {
 	.name		= "gp timer",
-	.flags		= IRQF_DISABLED | IRQF_TIMER,
+	.flags		= IRQF_DISABLED | IRQF_TIMER | IRQF_IRQPOLL_IRQ,
 	.handler	= omap2_gp_timer_interrupt,
 };
 
Index: linux-2.6.21-rc4-mm1/arch/arm/mach-pnx4008/time.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/arch/arm/mach-pnx4008/time.c
+++ linux-2.6.21-rc4-mm1/arch/arm/mach-pnx4008/time.c
@@ -82,7 +82,7 @@ static irqreturn_t pnx4008_timer_interru
 
 static struct irqaction pnx4008_timer_irq = {
 	.name = "PNX4008 Tick Timer",
-	.flags = IRQF_DISABLED | IRQF_TIMER,
+	.flags = IRQF_DISABLED | IRQF_TIMER | IRQF_IRQPOLL_IRQ,
 	.handler = pnx4008_timer_interrupt
 };
 
Index: linux-2.6.21-rc4-mm1/arch/arm/mach-pxa/time.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/arch/arm/mach-pxa/time.c
+++ linux-2.6.21-rc4-mm1/arch/arm/mach-pxa/time.c
@@ -97,7 +97,7 @@ pxa_timer_interrupt(int irq, void *dev_i
 
 static struct irqaction pxa_timer_irq = {
 	.name		= "PXA Timer Tick",
-	.flags		= IRQF_DISABLED | IRQF_TIMER,
+	.flags		= IRQF_DISABLED | IRQF_TIMER | IRQF_IRQPOLL_IRQ,
 	.handler	= pxa_timer_interrupt,
 };
 
Index: linux-2.6.21-rc4-mm1/arch/arm/mach-realview/core.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/arch/arm/mach-realview/core.c
+++ linux-2.6.21-rc4-mm1/arch/arm/mach-realview/core.c
@@ -549,7 +549,7 @@ static irqreturn_t realview_timer_interr
 
 static struct irqaction realview_timer_irq = {
 	.name		= "RealView Timer Tick",
-	.flags		= IRQF_DISABLED | IRQF_TIMER,
+	.flags		= IRQF_DISABLED | IRQF_TIMER | IRQF_IRQPOLL_IRQ,
 	.handler	= realview_timer_interrupt,
 };
 
Index: linux-2.6.21-rc4-mm1/arch/arm/mach-sa1100/h3600.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/arch/arm/mach-sa1100/h3600.c
+++ linux-2.6.21-rc4-mm1/arch/arm/mach-sa1100/h3600.c
@@ -740,7 +740,7 @@ static void h3800_IRQ_demux(unsigned int
 static struct irqaction h3800_irq = {
 	.name		= "h3800_asic",
 	.handler	= h3800_IRQ_demux,
-	.flags		= IRQF_DISABLED | IRQF_TIMER,
+	.flags		= IRQF_DISABLED | IRQF_TIMER | IRQF_IRQPOLL_IRQ,
 };
 
 u32 kpio_int_shadow = 0;
Index: linux-2.6.21-rc4-mm1/arch/arm/mach-sa1100/time.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/arch/arm/mach-sa1100/time.c
+++ linux-2.6.21-rc4-mm1/arch/arm/mach-sa1100/time.c
@@ -111,7 +111,7 @@ sa1100_timer_interrupt(int irq, void *de
 
 static struct irqaction sa1100_timer_irq = {
 	.name		= "SA11xx Timer Tick",
-	.flags		= IRQF_DISABLED | IRQF_TIMER,
+	.flags		= IRQF_DISABLED | IRQF_TIMER | IRQF_IRQPOLL_IRQ,
 	.handler	= sa1100_timer_interrupt,
 };
 
Index: linux-2.6.21-rc4-mm1/arch/arm/mach-shark/core.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/arch/arm/mach-shark/core.c
+++ linux-2.6.21-rc4-mm1/arch/arm/mach-shark/core.c
@@ -90,7 +90,7 @@ shark_timer_interrupt(int irq, void *dev
 
 static struct irqaction shark_timer_irq = {
 	.name		= "Shark Timer Tick",
-	.flags		= IRQF_DISABLED | IRQF_TIMER,
+	.flags		= IRQF_DISABLED | IRQF_TIMER | IRQF_IRQPOLL_IRQ,
 	.handler	= shark_timer_interrupt,
 };
 
Index: linux-2.6.21-rc4-mm1/arch/arm/mach-versatile/core.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/arch/arm/mach-versatile/core.c
+++ linux-2.6.21-rc4-mm1/arch/arm/mach-versatile/core.c
@@ -887,7 +887,7 @@ static irqreturn_t versatile_timer_inter
 
 static struct irqaction versatile_timer_irq = {
 	.name		= "Versatile Timer Tick",
-	.flags		= IRQF_DISABLED | IRQF_TIMER,
+	.flags		= IRQF_DISABLED | IRQF_TIMER | IRQF_IRQPOLL_IRQ,
 	.handler	= versatile_timer_interrupt,
 };
 
Index: linux-2.6.21-rc4-mm1/arch/arm/plat-iop/time.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/arch/arm/plat-iop/time.c
+++ linux-2.6.21-rc4-mm1/arch/arm/plat-iop/time.c
@@ -75,7 +75,7 @@ iop_timer_interrupt(int irq, void *dev_i
 static struct irqaction iop_timer_irq = {
 	.name		= "IOP Timer Tick",
 	.handler	= iop_timer_interrupt,
-	.flags		= IRQF_DISABLED | IRQF_TIMER,
+	.flags		= IRQF_DISABLED | IRQF_TIMER | IRQF_IRQPOLL_IRQ,
 };
 
 void __init iop_init_time(unsigned long tick_rate)
Index: linux-2.6.21-rc4-mm1/arch/arm/plat-omap/timer32k.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/arch/arm/plat-omap/timer32k.c
+++ linux-2.6.21-rc4-mm1/arch/arm/plat-omap/timer32k.c
@@ -279,7 +279,7 @@ static struct dyn_tick_timer omap_dyn_ti
 
 static struct irqaction omap_32k_timer_irq = {
 	.name		= "32KHz timer",
-	.flags		= IRQF_DISABLED | IRQF_TIMER,
+	.flags		= IRQF_DISABLED | IRQF_TIMER | IRQF_IRQPOLL_IRQ,
 	.handler	= omap_32k_timer_interrupt,
 };
 
Index: linux-2.6.21-rc4-mm1/arch/arm/plat-s3c24xx/time.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/arch/arm/plat-s3c24xx/time.c
+++ linux-2.6.21-rc4-mm1/arch/arm/plat-s3c24xx/time.c
@@ -138,7 +138,7 @@ s3c2410_timer_interrupt(int irq, void *d
 
 static struct irqaction s3c2410_timer_irq = {
 	.name		= "S3C2410 Timer Tick",
-	.flags		= IRQF_DISABLED | IRQF_TIMER,
+	.flags		= IRQF_DISABLED | IRQF_TIMER | IRQF_IRQPOLL_IRQ,
 	.handler	= s3c2410_timer_interrupt,
 };
 

-- 

[patch 5/7] Add IRQF_IRQPOLL_IRQ flag on sh

[Bernhard Walle]

[-- Attachment #1: IRQF_IRQPOLL_IRQ-sh --]
[-- Type: text/plain, Size: 1910 bytes --]

Add IRQF_IRQPOLL_IRQ on each timer interrupt on SH2.

Signed-off-by: Bernhard Walle <bwalle@suse.de>
---
 arch/sh/kernel/timers/timer-cmt.c  |    2 +-
 arch/sh/kernel/timers/timer-mtu2.c |    2 +-
 arch/sh/kernel/timers/timer-tmu.c  |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

Index: linux-2.6.21-rc4-mm1/arch/sh/kernel/timers/timer-cmt.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/arch/sh/kernel/timers/timer-cmt.c
+++ linux-2.6.21-rc4-mm1/arch/sh/kernel/timers/timer-cmt.c
@@ -115,7 +115,7 @@ static irqreturn_t cmt_timer_interrupt(i
 static struct irqaction cmt_irq = {
 	.name		= "timer",
 	.handler	= cmt_timer_interrupt,
-	.flags		= IRQF_DISABLED | IRQF_TIMER,
+	.flags		= IRQF_DISABLED | IRQF_TIMER | IRQF_IRQPOLL_IRQ,
 	.mask		= CPU_MASK_NONE,
 };
 
Index: linux-2.6.21-rc4-mm1/arch/sh/kernel/timers/timer-mtu2.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/arch/sh/kernel/timers/timer-mtu2.c
+++ linux-2.6.21-rc4-mm1/arch/sh/kernel/timers/timer-mtu2.c
@@ -110,7 +110,7 @@ static irqreturn_t mtu2_timer_interrupt(
 static struct irqaction mtu2_irq = {
 	.name		= "timer",
 	.handler	= mtu2_timer_interrupt,
-	.flags		= IRQF_DISABLED | IRQF_TIMER,
+	.flags		= IRQF_DISABLED | IRQF_TIMER | IRQF_IRQPOLL_IRQ,
 	.mask		= CPU_MASK_NONE,
 };
 
Index: linux-2.6.21-rc4-mm1/arch/sh/kernel/timers/timer-tmu.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/arch/sh/kernel/timers/timer-tmu.c
+++ linux-2.6.21-rc4-mm1/arch/sh/kernel/timers/timer-tmu.c
@@ -99,7 +99,7 @@ static irqreturn_t tmu_timer_interrupt(i
 static struct irqaction tmu_irq = {
 	.name		= "timer",
 	.handler	= tmu_timer_interrupt,
-	.flags		= IRQF_DISABLED | IRQF_TIMER,
+	.flags		= IRQF_DISABLED | IRQF_TIMER | IRQF_IRQPOLL_IRQ,
 	.mask		= CPU_MASK_NONE,
 };
 

-- 

[patch 6/7] Add IRQF_IRQPOLL_IRQ flag on parisc

[Bernhard Walle]

[-- Attachment #1: IRQF_IRQPOLL_IRQ-parisc --]
[-- Type: text/plain, Size: 724 bytes --]

Add IRQF_IRQPOLL_IRQ to the timer interrupt on parisc.

Signed-off-by: Bernhard Walle <bwalle@suse.de>
---
 arch/parisc/kernel/irq.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.21-rc4-mm1/arch/parisc/kernel/irq.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/arch/parisc/kernel/irq.c
+++ linux-2.6.21-rc4-mm1/arch/parisc/kernel/irq.c
@@ -388,7 +388,7 @@ void do_cpu_irq_mask(struct pt_regs *reg
 static struct irqaction timer_action = {
 	.handler = timer_interrupt,
 	.name = "timer",
-	.flags = IRQF_DISABLED | IRQF_TIMER | IRQF_PERCPU,
+	.flags = IRQF_DISABLED | IRQF_TIMER | IRQF_PERCPU | IRQF_IRQPOLL_IRQ,
 };
 
 #ifdef CONFIG_SMP

-- 

[patch 7/7] Add IRQF_IRQPOLL_IRQ flag on i386

[Bernhard Walle]

[-- Attachment #1: IRQF_IRQPOLL_IRQ-i386 --]
[-- Type: text/plain, Size: 1898 bytes --]

Add IRQF_IRQPOLL_IRQ to timer interrupts on i386.

Signed-off-by: Bernhard Walle <bwalle@suse.de>
Cc: Andi Kleen <ak@suse.de>
---
 arch/i386/mach-default/setup.c |    2 +-
 arch/i386/mach-visws/setup.c   |    2 +-
 arch/i386/mach-voyager/setup.c |    7 ++++++-
 3 files changed, 8 insertions(+), 3 deletions(-)

Index: linux-2.6.21-rc4-mm1/arch/i386/mach-default/setup.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/arch/i386/mach-default/setup.c
+++ linux-2.6.21-rc4-mm1/arch/i386/mach-default/setup.c
@@ -81,7 +81,7 @@ void __init trap_init_hook(void)
 
 static struct irqaction irq0  = {
 	.handler = timer_interrupt,
-	.flags = IRQF_DISABLED | IRQF_NOBALANCING,
+	.flags = IRQF_DISABLED | IRQF_NOBALANCING | IRQF_IRQPOLL_IRQ,
 	.mask = CPU_MASK_NONE,
 	.name = "timer"
 };
Index: linux-2.6.21-rc4-mm1/arch/i386/mach-visws/setup.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/arch/i386/mach-visws/setup.c
+++ linux-2.6.21-rc4-mm1/arch/i386/mach-visws/setup.c
@@ -116,7 +116,7 @@ void __init pre_setup_arch_hook()
 
 static struct irqaction irq0 = {
 	.handler =	timer_interrupt,
-	.flags =	IRQF_DISABLED,
+	.flags =	IRQF_DISABLED | IRQF_IRQPOLL_IRQ,
 	.name =		"timer",
 };
 
Index: linux-2.6.21-rc4-mm1/arch/i386/mach-voyager/setup.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/arch/i386/mach-voyager/setup.c
+++ linux-2.6.21-rc4-mm1/arch/i386/mach-voyager/setup.c
@@ -40,7 +40,12 @@ void __init trap_init_hook(void)
 {
 }
 
-static struct irqaction irq0  = { timer_interrupt, IRQF_DISABLED, CPU_MASK_NONE, "timer", NULL, NULL};
+static struct irqaction irq0  = {
+	.handler	= timer_interrupt,
+	.flags		= IRQF_DISABLED | IRQF_IRQPOLL_IRQ,
+	.mask		= CPU_MASK_NONE,
+	.name 		= "timer"
+};
 
 void __init time_init_hook(void)
 {

-- 

Re: [patch 0/7] Add IRQF_IRQPOLL_IRQ flag to allow irqpoll

[Guennadi Liakhovetski]

On Fri, 23 Mar 2007, Bernhard Walle wrote:

> irqpoll is broken on some architectures that don't use the IRQ 0 for the timer
> interrupt like IA64. This patch adds a IRQF_IRQPOLL_IRQ flag.

emn, please, cannot we come up with a better name - one that doesn't have 
"IRQ" 3 (!) times in it?...

Thanks
Guennadi
---
Guennadi Liakhovetski

Re: [patch 0/7] Add IRQF_IRQPOLL_IRQ flag to allow irqpoll

[Bernhard Walle]

* Guennadi Liakhovetski <g.liakhovetski@gmx.de> [2007-03-23 23:15]:
> On Fri, 23 Mar 2007, Bernhard Walle wrote:
> 
> > irqpoll is broken on some architectures that don't use the IRQ 0 for the timer
> > interrupt like IA64. This patch adds a IRQF_IRQPOLL_IRQ flag.
> 
> emn, please, cannot we come up with a better name - one that doesn't have 
> "IRQ" 3 (!) times in it?...

Well, it was suggested by Andrew. What's your suggestion?


Thanks,
   Bernhard

Re: [patch 0/7] Add IRQF_IRQPOLL_IRQ flag to allow irqpoll

[Guennadi Liakhovetski]

On Fri, 23 Mar 2007, Bernhard Walle wrote:

> * Guennadi Liakhovetski <g.liakhovetski@gmx.de> [2007-03-23 23:15]:
> > On Fri, 23 Mar 2007, Bernhard Walle wrote:
> > 
> > > irqpoll is broken on some architectures that don't use the IRQ 0 for the timer
> > > interrupt like IA64. This patch adds a IRQF_IRQPOLL_IRQ flag.
> > 
> > emn, please, cannot we come up with a better name - one that doesn't have 
> > "IRQ" 3 (!) times in it?...
> 
> Well, it was suggested by Andrew. What's your suggestion?

Purely esthetically (ehm, am I saying that?...) your original suggestion 
to use IRQF_IRQPOLL looks better to me. Or even IRQF_POLL, but, maybe, 
it's a bit too much of a simplification.

Thanks
Guennadi
---
Guennadi Liakhovetski

Re: [patch 0/7] Add IRQF_IRQPOLL_IRQ flag to allow irqpoll

[Bernhard Walle]

* Guennadi Liakhovetski <g.liakhovetski@gmx.de> [2007-03-24 00:21]:
> On Fri, 23 Mar 2007, Bernhard Walle wrote:
> 
> > * Guennadi Liakhovetski <g.liakhovetski@gmx.de> [2007-03-23 23:15]:
> > > On Fri, 23 Mar 2007, Bernhard Walle wrote:
> > > 
> > > > irqpoll is broken on some architectures that don't use the IRQ 0 for the timer
> > > > interrupt like IA64. This patch adds a IRQF_IRQPOLL_IRQ flag.
> > > 
> > > emn, please, cannot we come up with a better name - one that doesn't have 
> > > "IRQ" 3 (!) times in it?...
> > 
> > Well, it was suggested by Andrew. What's your suggestion?
> 
> Purely esthetically (ehm, am I saying that?...) your original suggestion 
> to use IRQF_IRQPOLL looks better to me. Or even IRQF_POLL, but, maybe, 
> it's a bit too much of a simplification.

I personally don't care very much about the naming. So I think it's
Andrews final decision ...


Thanks,
   Bernhard

Re: [patch 0/7] Add IRQF_IRQPOLL_IRQ flag to allow irqpoll

[Guennadi Liakhovetski]

On Sun, 25 Mar 2007, Bernhard Walle wrote:

> * Guennadi Liakhovetski <g.liakhovetski@gmx.de> [2007-03-24 00:21]:
> > On Fri, 23 Mar 2007, Bernhard Walle wrote:
> > 
> > > * Guennadi Liakhovetski <g.liakhovetski@gmx.de> [2007-03-23 23:15]:
> > > > On Fri, 23 Mar 2007, Bernhard Walle wrote:
> > > > 
> > > > > irqpoll is broken on some architectures that don't use the IRQ 0 for the timer
> > > > > interrupt like IA64. This patch adds a IRQF_IRQPOLL_IRQ flag.
> > > > 
> > > > emn, please, cannot we come up with a better name - one that doesn't have 
> > > > "IRQ" 3 (!) times in it?...
> > > 
> > > Well, it was suggested by Andrew. What's your suggestion?
> > 
> > Purely esthetically (ehm, am I saying that?...) your original suggestion 
> > to use IRQF_IRQPOLL looks better to me. Or even IRQF_POLL, but, maybe, 
> > it's a bit too much of a simplification.
> 
> I personally don't care very much about the naming. So I think it's
> Andrews final decision ...

Sure. And for him to have a better chance to do this, I'll fix his email 
address too:-)

Thanks
Guennadi
---
Guennadi Liakhovetski

Re: [patch 0/7] Add IRQF_IRQPOLL_IRQ flag to allow irqpoll

[Andrew Morton]

On Tue, 27 Mar 2007 07:01:44 +0200 (CEST) Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote:

> On Sun, 25 Mar 2007, Bernhard Walle wrote:
> 
> > * Guennadi Liakhovetski <g.liakhovetski@gmx.de> [2007-03-24 00:21]:
> > > On Fri, 23 Mar 2007, Bernhard Walle wrote:
> > > 
> > > > * Guennadi Liakhovetski <g.liakhovetski@gmx.de> [2007-03-23 23:15]:
> > > > > On Fri, 23 Mar 2007, Bernhard Walle wrote:
> > > > > 
> > > > > > irqpoll is broken on some architectures that don't use the IRQ 0 for the timer
> > > > > > interrupt like IA64. This patch adds a IRQF_IRQPOLL_IRQ flag.
> > > > > 
> > > > > emn, please, cannot we come up with a better name - one that doesn't have 
> > > > > "IRQ" 3 (!) times in it?...
> > > > 
> > > > Well, it was suggested by Andrew. What's your suggestion?
> > > 
> > > Purely esthetically (ehm, am I saying that?...) your original suggestion 
> > > to use IRQF_IRQPOLL looks better to me. Or even IRQF_POLL, but, maybe, 
> > > it's a bit too much of a simplification.
> > 
> > I personally don't care very much about the naming. So I think it's
> > Andrews final decision ...
> 
> Sure. And for him to have a better chance to do this, I'll fix his email 
> address too:-)
> 

I don't think I went as daringly far as to suggest the full name, but I
must admit that IRQF_IRQPOLL_IRQ is actually logical.