From: Eric Dumazet <dada1@cosmosbay.com>
To: Maxim Uvarov <muvarov@ru.mvista.com>
Cc: linux-kernel@vger.kernel.org, davidsen@tmr.com,
randy.dunlap@oracle.com, Valdis.Kletnieks@vt.edu,
jesper.juhl@gmail.com
Subject: Re: Performance Stats: Kernel patch
Date: Tue, 10 Apr 2007 10:21:11 +0200 [thread overview]
Message-ID: <20070410102111.923b92a9.dada1@cosmosbay.com> (raw)
In-Reply-To: <461A4C1E.3070309@ru.mvista.com>
On Mon, 09 Apr 2007 18:22:22 +0400
Maxim Uvarov <muvarov@ru.mvista.com> wrote:
> --- linux-2.6.21-rc5.orig/arch/x86_64/kernel/entry.S
> +++ linux-2.6.21-rc5/arch/x86_64/kernel/entry.S
> @@ -236,6 +236,11 @@ ENTRY(system_call)
> movq %r10,%rcx
> call *sys_call_table(,%rax,8) # XXX: rip relative
> movq %rax,RAX-ARGOFFSET(%rsp)
> +#ifdef CONFIG_THREAD_PERF_STAT_SYSC
> + GET_THREAD_INFO(%rcx)
> + addq $1, threadinfo_sysc_cnt(%rcx) # Increment syscalls counter
> +#endif /* CONFIG_THREAD_PERF_STAT_SYSC */
> +
Please reorganize the code so that you dont duplicate GET_THREAD_INFO() stuff
You can do this for example before calling the syscall, not after.
ja badsys
+#ifdef CONFIG_THREAD_PERF_STAT_SYSC
+ incq threadinfo_sysc_cnt(%rcx) # Increment syscalls counter
+#endif /* CONFIG_THREAD_PERF_STAT_SYSC */
movq %r10,%rcx
call *sys_call_table(,%rax,8) # XXX: rip relative
next prev parent reply other threads:[~2007-04-10 8:57 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-09 14:22 Maxim Uvarov
2007-04-10 8:21 ` Eric Dumazet [this message]
2007-04-11 11:59 ` Maxim Uvarov
2007-04-11 12:26 ` Eric Dumazet
2007-04-11 13:15 ` Maxim Uvarov
2007-04-11 14:15 ` Eric Dumazet
2007-04-11 15:33 ` Bill Davidsen
2007-04-11 15:57 ` Maxim Uvarov
2007-04-11 15:53 ` Maxim Uvarov
2007-04-11 19:22 ` Eric Dumazet
2007-04-12 13:46 ` Maxim Uvarov
2007-04-15 9:47 ` Pavel Machek
2007-04-15 10:21 ` William Lee Irwin III
2007-04-15 20:10 ` Pavel Machek
2007-04-16 1:04 ` William Lee Irwin III
2007-04-16 9:24 ` Maxim Uvarov
-- strict thread matches above, loose matches on Subject: below --
2007-04-03 12:54 Maxim Uvarov
2007-04-03 23:01 ` Valdis.Kletnieks
2007-04-04 13:15 ` Maxim Uvarov
2007-04-04 13:46 ` Eric Dumazet
2007-04-04 16:52 ` Maxim Uvarov
2007-04-04 18:04 ` Eric Dumazet
2007-04-04 21:54 ` Valdis.Kletnieks
2007-04-04 13:59 ` Jesper Juhl
2007-04-04 21:50 ` Valdis.Kletnieks
2007-04-04 22:03 ` Randy Dunlap
2007-04-06 21:50 ` Bill Davidsen
2007-04-08 16:58 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070410102111.923b92a9.dada1@cosmosbay.com \
--to=dada1@cosmosbay.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=davidsen@tmr.com \
--cc=jesper.juhl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=muvarov@ru.mvista.com \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®