From: Eric Dumazet <dada1@cosmosbay.com>
To: Maxim Uvarov <muvarov@ru.mvista.com>
Cc: linux-kernel@vger.kernel.org, davidsen@tmr.com,
randy.dunlap@oracle.com, Valdis.Kletnieks@vt.edu,
jesper.juhl@gmail.com
Subject: Re: Performance Stats: Kernel patch
Date: Wed, 11 Apr 2007 14:26:43 +0200 [thread overview]
Message-ID: <20070411142643.bb80522a.dada1@cosmosbay.com> (raw)
In-Reply-To: <461CCD94.6010507@ru.mvista.com>
On Wed, 11 Apr 2007 15:59:16 +0400
Maxim Uvarov <muvarov@ru.mvista.com> wrote:
> Thanks Eric, I's really better. I have done changes. Do you have any
> others objections now?
> All is in attached perf_stat.patch.
Hi Maxim
I know *nothing* about powerpc assembly, but I think there is a problem :
Index: linux-2.6.21-rc5/arch/powerpc/kernel/entry_64.S
===================================================================
--- linux-2.6.21-rc5.orig/arch/powerpc/kernel/entry_64.S
+++ linux-2.6.21-rc5/arch/powerpc/kernel/entry_64.S
@@ -115,6 +115,11 @@ END_FW_FTR_SECTION_IFSET(FW_FEATURE_ISER
addi r9,r1,STACK_FRAME_OVERHEAD
#endif
clrrdi r11,r1,THREAD_SHIFT
+#ifdef CONFIG_THREAD_PERF_STAT_SYSC
+ lwz r10,TI_SYSC_CNT(r11)
+ addi r10,r10,1
+ stw r10,TI_SYSC_CNT(r11)
+#endif /* CONFIG_THREAD_PERF_STAT_SYSC */
ld r10,TI_FLAGS(r11)
andi. r11,r10,_TIF_SYSCALL_T_OR_A
bne- syscall_dotrace
sysc_cnt being an 'unsigned long', its a 64 bits long integer...
So you probably need ld/std instructions instead of lwz/stw
next prev parent reply other threads:[~2007-04-11 12:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-09 14:22 Maxim Uvarov
2007-04-10 8:21 ` Eric Dumazet
2007-04-11 11:59 ` Maxim Uvarov
2007-04-11 12:26 ` Eric Dumazet [this message]
2007-04-11 13:15 ` Maxim Uvarov
2007-04-11 14:15 ` Eric Dumazet
2007-04-11 15:33 ` Bill Davidsen
2007-04-11 15:57 ` Maxim Uvarov
2007-04-11 15:53 ` Maxim Uvarov
2007-04-11 19:22 ` Eric Dumazet
2007-04-12 13:46 ` Maxim Uvarov
2007-04-15 9:47 ` Pavel Machek
2007-04-15 10:21 ` William Lee Irwin III
2007-04-15 20:10 ` Pavel Machek
2007-04-16 1:04 ` William Lee Irwin III
2007-04-16 9:24 ` Maxim Uvarov
-- strict thread matches above, loose matches on Subject: below --
2007-04-03 12:54 Maxim Uvarov
2007-04-03 23:01 ` Valdis.Kletnieks
2007-04-04 13:15 ` Maxim Uvarov
2007-04-04 13:46 ` Eric Dumazet
2007-04-04 16:52 ` Maxim Uvarov
2007-04-04 18:04 ` Eric Dumazet
2007-04-04 21:54 ` Valdis.Kletnieks
2007-04-04 13:59 ` Jesper Juhl
2007-04-04 21:50 ` Valdis.Kletnieks
2007-04-04 22:03 ` Randy Dunlap
2007-04-06 21:50 ` Bill Davidsen
2007-04-08 16:58 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070411142643.bb80522a.dada1@cosmosbay.com \
--to=dada1@cosmosbay.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=davidsen@tmr.com \
--cc=jesper.juhl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=muvarov@ru.mvista.com \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®