mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Valdis.Kletnieks@vt.edu
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: Maxim Uvarov <muvarov@ru.mvista.com>, linux-kernel@vger.kernel.org
Subject: Re: Performance Stats: Kernel patch
Date: Wed, 04 Apr 2007 17:54:32 -0400	[thread overview]
Message-ID: <6284.1175723672@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Wed, 04 Apr 2007 15:46:24 +0200." <20070404154624.826578b1.dada1@cosmosbay.com>

[-- Attachment #1: Type: text/plain, Size: 594 bytes --]

On Wed, 04 Apr 2007 15:46:24 +0200, Eric Dumazet said:
> On Wed, 04 Apr 2007 17:15:43 +0400
> Maxim Uvarov <muvarov@ru.mvista.com> wrote:

> > +#ifdef CONFIG_THREAD_PERF_STAT_SYSC
> > +       call inc_syscallcnt             # Increment syscalls counter 
> > current->sysc_cnt
> > +#endif /* CONFIG_THREAD_PERF_STAT_SYSC */
> 
> Please dont call a function to do one increment !
> 
> You are touching one of the most critical part of the kernel...

Obviously Eric and I looked at this looking for totally different things. :)

Thanks for spotting that, I totally failed to notice that part....


[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]

  parent reply	other threads:[~2007-04-04 21:55 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-03 12:54 Maxim Uvarov
2007-04-03 23:01 ` Valdis.Kletnieks
2007-04-04 13:15   ` Maxim Uvarov
2007-04-04 13:46     ` Eric Dumazet
2007-04-04 16:52       ` Maxim Uvarov
2007-04-04 18:04         ` Eric Dumazet
2007-04-04 21:54       ` Valdis.Kletnieks [this message]
2007-04-04 13:59     ` Jesper Juhl
2007-04-04 21:50     ` Valdis.Kletnieks
2007-04-04 22:03       ` Randy Dunlap
2007-04-06 21:50       ` Bill Davidsen
2007-04-08 16:58     ` Pavel Machek
2007-04-09 14:22 Maxim Uvarov
2007-04-10  8:21 ` Eric Dumazet
2007-04-11 11:59   ` Maxim Uvarov
2007-04-11 12:26     ` Eric Dumazet
2007-04-11 13:15       ` Maxim Uvarov
2007-04-11 14:15     ` Eric Dumazet
2007-04-11 15:33       ` Bill Davidsen
2007-04-11 15:57         ` Maxim Uvarov
2007-04-11 15:53       ` Maxim Uvarov
2007-04-11 19:22         ` Eric Dumazet
2007-04-12 13:46           ` Maxim Uvarov
2007-04-15  9:47 ` Pavel Machek
2007-04-15 10:21   ` William Lee Irwin III
2007-04-15 20:10     ` Pavel Machek
2007-04-16  1:04       ` William Lee Irwin III
2007-04-16  9:24         ` Maxim Uvarov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6284.1175723672@turing-police.cc.vt.edu \
    --to=valdis.kletnieks@vt.edu \
    --cc=dada1@cosmosbay.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=muvarov@ru.mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome