* [PATCH] usbatm_heavy_init: don't use CLONE_SIGHAND
@ 2007-04-12 23:56 Oleg Nesterov
2007-04-13 22:59 ` Duncan Sands
0 siblings, 1 reply; 2+ messages in thread
From: Oleg Nesterov @ 2007-04-12 23:56 UTC (permalink / raw)
To: Andrew Morton; +Cc: Duncan Sands, linux-kernel
usbatm_do_heavy_init() calls allow_signal() which plays with parent process's
->sighand.
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
--- 2.6.21-rc5/drivers/usb/atm/usbatm.c~usbatm 2006-11-27 21:19:30.000000000 +0300
+++ 2.6.21-rc5/drivers/usb/atm/usbatm.c 2007-04-13 03:34:56.000000000 +0400
@@ -1019,7 +1019,7 @@ static int usbatm_do_heavy_init(void *ar
static int usbatm_heavy_init(struct usbatm_data *instance)
{
- int ret = kernel_thread(usbatm_do_heavy_init, instance, CLONE_KERNEL);
+ int ret = kernel_thread(usbatm_do_heavy_init, instance, CLONE_FS | CLONE_FILES);
if (ret < 0) {
usb_err(instance, "%s: failed to create kernel_thread (%d)!\n", __func__, ret);
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] usbatm_heavy_init: don't use CLONE_SIGHAND
2007-04-12 23:56 [PATCH] usbatm_heavy_init: don't use CLONE_SIGHAND Oleg Nesterov
@ 2007-04-13 22:59 ` Duncan Sands
0 siblings, 0 replies; 2+ messages in thread
From: Duncan Sands @ 2007-04-13 22:59 UTC (permalink / raw)
To: Oleg Nesterov; +Cc: Andrew Morton, linux-kernel
On Friday 13 April 2007 01:56:31 Oleg Nesterov wrote:
> usbatm_do_heavy_init() calls allow_signal() which plays with parent process's
> ->sighand.
>
> Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Acked-by: Duncan Sands <baldrick@free.fr>
> --- 2.6.21-rc5/drivers/usb/atm/usbatm.c~usbatm 2006-11-27 21:19:30.000000000 +0300
> +++ 2.6.21-rc5/drivers/usb/atm/usbatm.c 2007-04-13 03:34:56.000000000 +0400
> @@ -1019,7 +1019,7 @@ static int usbatm_do_heavy_init(void *ar
>
> static int usbatm_heavy_init(struct usbatm_data *instance)
> {
> - int ret = kernel_thread(usbatm_do_heavy_init, instance, CLONE_KERNEL);
> + int ret = kernel_thread(usbatm_do_heavy_init, instance, CLONE_FS | CLONE_FILES);
>
> if (ret < 0) {
> usb_err(instance, "%s: failed to create kernel_thread (%d)!\n", __func__, ret);
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-04-13 22:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-04-12 23:56 [PATCH] usbatm_heavy_init: don't use CLONE_SIGHAND Oleg Nesterov
2007-04-13 22:59 ` Duncan Sands
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®