* make clean for DocBook
@ 2007-04-13 16:06 Randy Dunlap
2007-04-13 16:41 ` Sam Ravnborg
0 siblings, 1 reply; 6+ messages in thread
From: Randy Dunlap @ 2007-04-13 16:06 UTC (permalink / raw)
To: lkml; +Cc: sam
Hi Sam,
'make clean' doesn't seem to descend into Documentation/DocBook/.
At least 'make V=1 clean' doesn't show me any references in DocBook.
I guess that this is because DocBook doesn't have anything that
qualifies in obj-y/m/n and subdir-y/m/n. (?)
Do you have any recommendations for this?
Thanks,
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: make clean for DocBook
2007-04-13 16:06 make clean for DocBook Randy Dunlap
@ 2007-04-13 16:41 ` Sam Ravnborg
2007-04-13 18:23 ` Randy Dunlap
0 siblings, 1 reply; 6+ messages in thread
From: Sam Ravnborg @ 2007-04-13 16:41 UTC (permalink / raw)
To: Randy Dunlap; +Cc: lkml
On Fri, Apr 13, 2007 at 09:06:58AM -0700, Randy Dunlap wrote:
> Hi Sam,
>
> 'make clean' doesn't seem to descend into Documentation/DocBook/.
> At least 'make V=1 clean' doesn't show me any references in DocBook.
>
> I guess that this is because DocBook doesn't have anything that
> qualifies in obj-y/m/n and subdir-y/m/n. (?)
Documentation/ is handled explicit i top-level Makefile:
mrproper-dirs := $(addprefix _mrproper_,Documentation/DocBook scripts)
PHONY += $(mrproper-dirs) mrproper archmrproper
$(mrproper-dirs):
$(Q)$(MAKE) $(clean)=$(patsubst _mrproper_%,%,$@)
And we will visit DocBook with mrproper - but not clean.
I have no stron opinion when to delete generated files in DocBook.
Sam
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: make clean for DocBook
2007-04-13 16:41 ` Sam Ravnborg
@ 2007-04-13 18:23 ` Randy Dunlap
2007-04-13 19:32 ` Sam Ravnborg
0 siblings, 1 reply; 6+ messages in thread
From: Randy Dunlap @ 2007-04-13 18:23 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: lkml
On Fri, 13 Apr 2007 18:41:42 +0200 Sam Ravnborg wrote:
> On Fri, Apr 13, 2007 at 09:06:58AM -0700, Randy Dunlap wrote:
> > Hi Sam,
> >
> > 'make clean' doesn't seem to descend into Documentation/DocBook/.
> > At least 'make V=1 clean' doesn't show me any references in DocBook.
> >
> > I guess that this is because DocBook doesn't have anything that
> > qualifies in obj-y/m/n and subdir-y/m/n. (?)
>
> Documentation/ is handled explicit i top-level Makefile:
>
> mrproper-dirs := $(addprefix _mrproper_,Documentation/DocBook scripts)
>
> PHONY += $(mrproper-dirs) mrproper archmrproper
> $(mrproper-dirs):
> $(Q)$(MAKE) $(clean)=$(patsubst _mrproper_%,%,$@)
>
>
> And we will visit DocBook with mrproper - but not clean.
> I have no stron opinion when to delete generated files in DocBook.
OK, that's fine, thanks for the info...
but trying 'make mrproper' gives me:
make -f scripts/Makefile.clean obj=Documentation/DocBook
make -f scripts/Makefile.clean obj=Documentation/DocBook/man/
make[2]: execvp: /bin/sh: Argument list too long
make[2]: *** [__clean] Error 127
make[1]: *** [Documentation/DocBook/man/] Error 2
make: *** [_mrproper_Documentation/DocBook] Error 2
DocBook/man/ contains about 2000 files.
Is there some way to have scripts/Makefile.clean just do
rm -rf Documentation/DocBook/man/
? or some other solution?
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: make clean for DocBook
2007-04-13 18:23 ` Randy Dunlap
@ 2007-04-13 19:32 ` Sam Ravnborg
2007-04-13 21:03 ` Randy Dunlap
0 siblings, 1 reply; 6+ messages in thread
From: Sam Ravnborg @ 2007-04-13 19:32 UTC (permalink / raw)
To: Randy Dunlap; +Cc: lkml
> >
> >
> > And we will visit DocBook with mrproper - but not clean.
> > I have no stron opinion when to delete generated files in DocBook.
>
> OK, that's fine, thanks for the info...
> but trying 'make mrproper' gives me:
>
> make -f scripts/Makefile.clean obj=Documentation/DocBook
> make -f scripts/Makefile.clean obj=Documentation/DocBook/man/
> make[2]: execvp: /bin/sh: Argument list too long
> make[2]: *** [__clean] Error 127
> make[1]: *** [Documentation/DocBook/man/] Error 2
> make: *** [_mrproper_Documentation/DocBook] Error 2
>
> DocBook/man/ contains about 2000 files.
> Is there some way to have scripts/Makefile.clean just do
> rm -rf Documentation/DocBook/man/
> ? or some other solution?
Something like this should do it.
This deletes the man/ directory entirely so
I have to do that when I check in the patch.
Let me know if this works for you.
Sam
diff --git a/Documentation/DocBook/Makefile b/Documentation/DocBook/Makefile
index 867608a..960f402 100644
--- a/Documentation/DocBook/Makefile
+++ b/Documentation/DocBook/Makefile
@@ -152,6 +152,7 @@ quiet_cmd_db2man = MAN $@
@(which xmlto > /dev/null 2>&1) || \
(echo "*** You need to install xmlto ***"; \
exit 1)
+ $(Q)mkdir -p $(obj)/man
$(call cmd,db2man)
@touch $@
@@ -212,11 +213,7 @@ clean-files := $(DOCBOOKS) \
$(patsubst %.xml, %.9, $(DOCBOOKS)) \
$(C-procfs-example)
-clean-dirs := $(patsubst %.xml,%,$(DOCBOOKS))
-
-#man put files in man subdir - traverse down
-subdir- := man/
-
+clean-dirs := $(patsubst %.xml,%,$(DOCBOOKS)) man
# Declare the contents of the .PHONY variable as phony. We keep that
# information in a variable se we can use it in if_changed and friends.
diff --git a/Documentation/DocBook/man/Makefile b/Documentation/DocBook/man/Makefile
deleted file mode 100644
index 4fb7ea0..0000000
--- a/Documentation/DocBook/man/Makefile
+++ /dev/null
@@ -1,3 +0,0 @@
-# Rules are put in Documentation/DocBook
-
-clean-files := *.9.gz *.sgml manpage.links manpage.refs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: make clean for DocBook
2007-04-13 19:32 ` Sam Ravnborg
@ 2007-04-13 21:03 ` Randy Dunlap
2007-04-13 21:10 ` Sam Ravnborg
0 siblings, 1 reply; 6+ messages in thread
From: Randy Dunlap @ 2007-04-13 21:03 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: lkml
On Fri, 13 Apr 2007 21:32:50 +0200 Sam Ravnborg wrote:
> > >
> > >
> > > And we will visit DocBook with mrproper - but not clean.
> > > I have no stron opinion when to delete generated files in DocBook.
> >
> > OK, that's fine, thanks for the info...
> > but trying 'make mrproper' gives me:
> >
> > make -f scripts/Makefile.clean obj=Documentation/DocBook
> > make -f scripts/Makefile.clean obj=Documentation/DocBook/man/
> > make[2]: execvp: /bin/sh: Argument list too long
> > make[2]: *** [__clean] Error 127
> > make[1]: *** [Documentation/DocBook/man/] Error 2
> > make: *** [_mrproper_Documentation/DocBook] Error 2
> >
> > DocBook/man/ contains about 2000 files.
> > Is there some way to have scripts/Makefile.clean just do
> > rm -rf Documentation/DocBook/man/
> > ? or some other solution?
>
> Something like this should do it.
> This deletes the man/ directory entirely so
> I have to do that when I check in the patch.
>
> Let me know if this works for you.
Yes, thanks.
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
> Sam
>
> diff --git a/Documentation/DocBook/Makefile b/Documentation/DocBook/Makefile
> index 867608a..960f402 100644
> --- a/Documentation/DocBook/Makefile
> +++ b/Documentation/DocBook/Makefile
> @@ -152,6 +152,7 @@ quiet_cmd_db2man = MAN $@
> @(which xmlto > /dev/null 2>&1) || \
> (echo "*** You need to install xmlto ***"; \
> exit 1)
> + $(Q)mkdir -p $(obj)/man
> $(call cmd,db2man)
> @touch $@
>
> @@ -212,11 +213,7 @@ clean-files := $(DOCBOOKS) \
> $(patsubst %.xml, %.9, $(DOCBOOKS)) \
> $(C-procfs-example)
>
> -clean-dirs := $(patsubst %.xml,%,$(DOCBOOKS))
> -
> -#man put files in man subdir - traverse down
> -subdir- := man/
> -
> +clean-dirs := $(patsubst %.xml,%,$(DOCBOOKS)) man
>
> # Declare the contents of the .PHONY variable as phony. We keep that
> # information in a variable se we can use it in if_changed and friends.
> diff --git a/Documentation/DocBook/man/Makefile b/Documentation/DocBook/man/Makefile
> deleted file mode 100644
> index 4fb7ea0..0000000
> --- a/Documentation/DocBook/man/Makefile
> +++ /dev/null
> @@ -1,3 +0,0 @@
> -# Rules are put in Documentation/DocBook
> -
> -clean-files := *.9.gz *.sgml manpage.links manpage.refs
>
> -
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: make clean for DocBook
2007-04-13 21:03 ` Randy Dunlap
@ 2007-04-13 21:10 ` Sam Ravnborg
0 siblings, 0 replies; 6+ messages in thread
From: Sam Ravnborg @ 2007-04-13 21:10 UTC (permalink / raw)
To: Randy Dunlap; +Cc: lkml
On Fri, Apr 13, 2007 at 02:03:37PM -0700, Randy Dunlap wrote:
> On Fri, 13 Apr 2007 21:32:50 +0200 Sam Ravnborg wrote:
>
> > > >
> > > >
> > > > And we will visit DocBook with mrproper - but not clean.
> > > > I have no stron opinion when to delete generated files in DocBook.
> > >
> > > OK, that's fine, thanks for the info...
> > > but trying 'make mrproper' gives me:
> > >
> > > make -f scripts/Makefile.clean obj=Documentation/DocBook
> > > make -f scripts/Makefile.clean obj=Documentation/DocBook/man/
> > > make[2]: execvp: /bin/sh: Argument list too long
> > > make[2]: *** [__clean] Error 127
> > > make[1]: *** [Documentation/DocBook/man/] Error 2
> > > make: *** [_mrproper_Documentation/DocBook] Error 2
> > >
> > > DocBook/man/ contains about 2000 files.
> > > Is there some way to have scripts/Makefile.clean just do
> > > rm -rf Documentation/DocBook/man/
> > > ? or some other solution?
> >
> > Something like this should do it.
> > This deletes the man/ directory entirely so
> > I have to do that when I check in the patch.
> >
> > Let me know if this works for you.
>
> Yes, thanks.
>
> Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
Thanks, pushed out to kbuild.git.
Sam
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-04-13 21:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-04-13 16:06 make clean for DocBook Randy Dunlap
2007-04-13 16:41 ` Sam Ravnborg
2007-04-13 18:23 ` Randy Dunlap
2007-04-13 19:32 ` Sam Ravnborg
2007-04-13 21:03 ` Randy Dunlap
2007-04-13 21:10 ` Sam Ravnborg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®