From: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
To: jeff@garzik.org
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-ide@vger.kernel.org, htejun@gmail.com,
Kristen Carlson Accardi <kristen.c.accardi@intel.com>
Subject: [patch 1/7] libata: check for AN support
Date: Mon, 23 Apr 2007 16:59:43 -0700 [thread overview]
Message-ID: <20070423165943.0cc67bc5.kristen.c.accardi@intel.com> (raw)
In-Reply-To: <20070424074856.005152262@intel.com>
Check to see if an ATAPI device supports Asynchronous Notification.
If so, enable it.
Signed-off-by: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
Index: 2.6-git/drivers/ata/libata-core.c
===================================================================
--- 2.6-git.orig/drivers/ata/libata-core.c
+++ 2.6-git/drivers/ata/libata-core.c
@@ -70,6 +70,7 @@ const unsigned long sata_deb_timing_long
static unsigned int ata_dev_init_params(struct ata_device *dev,
u16 heads, u16 sectors);
static unsigned int ata_dev_set_xfermode(struct ata_device *dev);
+static unsigned int ata_dev_set_AN(struct ata_device *dev);
static void ata_dev_xfermask(struct ata_device *dev);
static unsigned int ata_print_id = 1;
@@ -1744,6 +1745,23 @@ int ata_dev_configure(struct ata_device
}
dev->cdb_len = (unsigned int) rc;
+ /*
+ * check to see if this ATAPI device supports
+ * Asynchronous Notification
+ */
+ if ((ap->flags & ATA_FLAG_AN) && ata_id_has_AN(id))
+ {
+ /* issue SET feature command to turn this on */
+ rc = ata_dev_set_AN(dev);
+ if (rc) {
+ ata_dev_printk(dev, KERN_ERR,
+ "unable to set AN\n");
+ rc = -EINVAL;
+ goto err_out_nosup;
+ }
+ dev->flags |= ATA_DFLAG_AN;
+ }
+
if (ata_id_cdb_intr(dev->id)) {
dev->flags |= ATA_DFLAG_CDB_INTR;
cdb_intr_string = ", CDB intr";
@@ -3525,6 +3543,42 @@ static unsigned int ata_dev_set_xfermode
}
/**
+ * ata_dev_set_AN - Issue SET FEATURES - SATA FEATURES
+ * with sector count set to indicate
+ * Asynchronous Notification feature
+ * @dev: Device to which command will be sent
+ *
+ * Issue SET FEATURES - SATA FEATURES command to device @dev
+ * on port @ap.
+ *
+ * LOCKING:
+ * PCI/etc. bus probe sem.
+ *
+ * RETURNS:
+ * 0 on success, AC_ERR_* mask otherwise.
+ */
+static unsigned int ata_dev_set_AN(struct ata_device *dev)
+{
+ struct ata_taskfile tf;
+ unsigned int err_mask;
+
+ /* set up set-features taskfile */
+ DPRINTK("set features - SATA features\n");
+
+ ata_tf_init(dev, &tf);
+ tf.command = ATA_CMD_SET_FEATURES;
+ tf.feature = SETFEATURES_SATA_ENABLE;
+ tf.flags |= ATA_TFLAG_ISADDR | ATA_TFLAG_DEVICE;
+ tf.protocol = ATA_PROT_NODATA;
+ tf.nsect = SATA_AN;
+
+ err_mask = ata_exec_internal(dev, &tf, NULL, DMA_NONE, NULL, 0);
+
+ DPRINTK("EXIT, err_mask=%x\n", err_mask);
+ return err_mask;
+}
+
+/**
* ata_dev_init_params - Issue INIT DEV PARAMS command
* @dev: Device to which command will be sent
* @heads: Number of heads (taskfile parameter)
Index: 2.6-git/include/linux/ata.h
===================================================================
--- 2.6-git.orig/include/linux/ata.h
+++ 2.6-git/include/linux/ata.h
@@ -194,6 +194,12 @@ enum {
SETFEATURES_WC_ON = 0x02, /* Enable write cache */
SETFEATURES_WC_OFF = 0x82, /* Disable write cache */
+ SETFEATURES_SATA_ENABLE = 0x10, /* Enable use of SATA feature */
+ SETFEATURES_SATA_DISABLE = 0x90, /* Disable use of SATA feature */
+
+ /* SETFEATURE Sector counts for SATA features */
+ SATA_AN = 0x05, /* Asynchronous Notification */
+
/* ATAPI stuff */
ATAPI_PKT_DMA = (1 << 0),
ATAPI_DMADIR = (1 << 2), /* ATAPI data dir:
@@ -299,6 +305,8 @@ struct ata_taskfile {
#define ata_id_queue_depth(id) (((id)[75] & 0x1f) + 1)
#define ata_id_removeable(id) ((id)[0] & (1 << 7))
#define ata_id_has_dword_io(id) ((id)[50] & (1 << 0))
+#define ata_id_has_AN(id) \
+ ((id[76] && (~id[76])) & ((id)[78] & (1 << 5)))
#define ata_id_iordy_disable(id) ((id)[49] & (1 << 10))
#define ata_id_has_iordy(id) ((id)[49] & (1 << 9))
#define ata_id_u32(id,n) \
Index: 2.6-git/include/linux/libata.h
===================================================================
--- 2.6-git.orig/include/linux/libata.h
+++ 2.6-git/include/linux/libata.h
@@ -136,6 +136,7 @@ enum {
ATA_DFLAG_CDB_INTR = (1 << 2), /* device asserts INTRQ when ready for CDB */
ATA_DFLAG_NCQ = (1 << 3), /* device supports NCQ */
ATA_DFLAG_FLUSH_EXT = (1 << 4), /* do FLUSH_EXT instead of FLUSH */
+ ATA_DFLAG_AN = (1 << 5), /* device supports Async notification */
ATA_DFLAG_CFG_MASK = (1 << 8) - 1,
ATA_DFLAG_PIO = (1 << 8), /* device limited to PIO mode */
@@ -174,6 +175,7 @@ enum {
ATA_FLAG_SETXFER_POLLING= (1 << 14), /* use polling for SETXFER */
ATA_FLAG_IGN_SIMPLEX = (1 << 15), /* ignore SIMPLEX */
ATA_FLAG_NO_IORDY = (1 << 16), /* controller lacks iordy */
+ ATA_FLAG_AN = (1 << 17), /* controller supports AN */
/* The following flag belongs to ap->pflags but is kept in
* ap->flags because it's referenced in many LLDs and will be
--
next parent reply other threads:[~2007-04-24 0:02 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070424074856.005152262@intel.com>
2007-04-23 23:59 ` Kristen Carlson Accardi [this message]
2007-04-24 8:03 ` Tejun Heo
2007-04-24 15:54 ` Kristen Carlson Accardi
2007-04-24 8:07 ` Alan Cox
2007-04-24 10:23 ` Olivier Galibert
2007-04-24 15:49 ` Kristen Carlson Accardi
2007-04-24 18:05 ` Olivier Galibert
2007-04-24 18:29 ` Kristen Carlson Accardi
2007-04-24 20:53 ` Kristen Carlson Accardi
2007-04-25 0:49 ` Olivier Galibert
2007-04-25 17:55 ` Kristen Carlson Accardi
2007-04-25 18:40 ` Kristen Carlson Accardi
2007-04-25 19:16 ` Matt Sealey
2007-04-25 20:34 ` Kristen Carlson Accardi
2007-04-25 20:59 ` Matt Sealey
2007-04-25 20:40 ` Olivier Galibert
2007-05-04 18:14 ` [patch 1/7] libata: check for AN support - resend Kristen Carlson Accardi
2007-04-23 23:59 ` [patch 2/7] genhd: expose AN to user space Kristen Carlson Accardi
2007-04-24 8:05 ` Tejun Heo
2007-04-24 21:30 ` Kristen Carlson Accardi
2007-05-04 18:15 ` [patch 2/7] genhd: expose AN to user space - resend Kristen Carlson Accardi
2007-04-23 23:59 ` [patch 3/7] scsi: expose AN to user space Kristen Carlson Accardi
2007-04-24 0:00 ` [patch 4/7] libata: " Kristen Carlson Accardi
2007-04-24 0:00 ` [patch 5/7] genhd: send async notification on media change Kristen Carlson Accardi
2007-04-24 8:20 ` Tejun Heo
2007-04-24 21:36 ` Kristen Carlson Accardi
2007-05-04 18:17 ` Kristen Carlson Accardi
2007-04-24 0:00 ` [patch 6/7] SCSI: save disk in scsi_device Kristen Carlson Accardi
2007-04-24 0:00 ` [patch 7/7] libata: send event when AN received Kristen Carlson Accardi
2007-04-24 8:09 ` Alan Cox
2007-04-24 21:38 ` Kristen Carlson Accardi
2007-05-04 18:18 ` [patch 7/7] libata: send event when AN received - resend Kristen Carlson Accardi
2007-05-04 18:16 ` [patch 3/7] scsi: expose AN to user space " Kristen Carlson Accardi
2007-05-04 18:16 ` [patch 4/7] libata: " Kristen Carlson Accardi
2007-05-04 18:17 ` [patch 6/7] SCSI: save disk in scsi_device " Kristen Carlson Accardi
2007-05-04 20:30 ` James Bottomley
2007-05-07 15:29 ` Kristen Carlson Accardi
2007-05-09 22:50 ` Kristen Carlson Accardi
2007-05-09 23:04 ` James Bottomley
[not found] <20070510072247.063476979@intel.com>
2007-05-09 23:38 ` [patch 1/7] libata: check for AN support Kristen Carlson Accardi
2007-05-10 5:09 ` Andrew Morton
2007-05-10 5:14 ` Jeff Garzik
2007-05-10 5:25 ` Andrew Morton
2007-05-10 15:19 ` Randy Dunlap
2007-05-10 17:02 ` Kristen Carlson Accardi
2007-05-25 3:15 ` Jeff Garzik
2007-06-11 20:20 ` Kristen Carlson Accardi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070423165943.0cc67bc5.kristen.c.accardi@intel.com \
--to=kristen.c.accardi@intel.com \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®