From: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
To: James Bottomley <James.Bottomley@SteelEye.com>, jeff@garzik.org
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-ide@vger.kernel.org, htejun@gmail.com,
akpm@linux-foundation.org
Subject: Re: [patch 6/7] SCSI: save disk in scsi_device - resend
Date: Wed, 9 May 2007 15:50:32 -0700 [thread overview]
Message-ID: <20070509155032.57c3a55d.kristen.c.accardi@intel.com> (raw)
In-Reply-To: <20070507082928.17878961.kristen.c.accardi@intel.com>
On Mon, 7 May 2007 08:29:28 -0700
Kristen Carlson Accardi <kristen.c.accardi@intel.com> wrote:
> On Fri, 04 May 2007 15:30:48 -0500
> James Bottomley <James.Bottomley@SteelEye.com> wrote:
>
> > On Fri, 2007-05-04 at 11:17 -0700, Kristen Carlson Accardi wrote:
> > > Give anyone who has access to scsi_device access to the genhd struct as well.
> > >
> > > Signed-off-by: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
> > > Index: 2.6-git/drivers/scsi/sd.c
> > > ===================================================================
> > > --- 2.6-git.orig/drivers/scsi/sd.c
> > > +++ 2.6-git/drivers/scsi/sd.c
> > > @@ -1711,6 +1711,7 @@ static int sd_probe(struct device *dev)
> > >
> > > dev_set_drvdata(dev, sdkp);
> > > add_disk(gd);
> > > + sdp->disk = gd;
> > >
> > > sdev_printk(KERN_NOTICE, sdp, "Attached scsi %sdisk %s\n",
> > > sdp->removable ? "removable " : "", gd->disk_name);
> > > Index: 2.6-git/drivers/scsi/sr.c
> > > ===================================================================
> > > --- 2.6-git.orig/drivers/scsi/sr.c
> > > +++ 2.6-git/drivers/scsi/sr.c
> > > @@ -604,6 +604,7 @@ static int sr_probe(struct device *dev)
> > > if (sdev->media_change_notify)
> > > disk->flags |= GENHD_FL_MEDIA_CHANGE_NOTIFY;
> > > add_disk(disk);
> > > + sdev->disk = disk;
> > >
> > > sdev_printk(KERN_DEBUG, sdev,
> > > "Attached scsi CD-ROM %s\n", cd->cdi.name);
> > > Index: 2.6-git/include/scsi/scsi_device.h
> > > ===================================================================
> > > --- 2.6-git.orig/include/scsi/scsi_device.h
> > > +++ 2.6-git/include/scsi/scsi_device.h
> > > @@ -138,7 +138,7 @@ struct scsi_device {
> > >
> > > struct device sdev_gendev;
> > > struct class_device sdev_classdev;
> > > -
> > > + struct gendisk *disk;
> > > struct execute_work ew; /* used to get process context on put */
> > >
> > > enum scsi_device_state sdev_state;
> >
> > If you're going to do this, you need to take on board removing the
> > struct gendisk from all the ULD structures (since it's now become
> > generic).
> >
> > James
> >
>
> Ok - I can send that as a separate patch series, or I can include it
> in this one. Which is preferred?
>
I interpret the lack of response to this question to mean that I can just
decide for myself - in which case I prefer to send this as a separate
patchset after this one is integrated.
Thanks!
Kristen
next prev parent reply other threads:[~2007-05-09 22:53 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070424074856.005152262@intel.com>
2007-04-23 23:59 ` [patch 1/7] libata: check for AN support Kristen Carlson Accardi
2007-04-24 8:03 ` Tejun Heo
2007-04-24 15:54 ` Kristen Carlson Accardi
2007-04-24 8:07 ` Alan Cox
2007-04-24 10:23 ` Olivier Galibert
2007-04-24 15:49 ` Kristen Carlson Accardi
2007-04-24 18:05 ` Olivier Galibert
2007-04-24 18:29 ` Kristen Carlson Accardi
2007-04-24 20:53 ` Kristen Carlson Accardi
2007-04-25 0:49 ` Olivier Galibert
2007-04-25 17:55 ` Kristen Carlson Accardi
2007-04-25 18:40 ` Kristen Carlson Accardi
2007-04-25 19:16 ` Matt Sealey
2007-04-25 20:34 ` Kristen Carlson Accardi
2007-04-25 20:59 ` Matt Sealey
2007-04-25 20:40 ` Olivier Galibert
2007-05-04 18:14 ` [patch 1/7] libata: check for AN support - resend Kristen Carlson Accardi
2007-04-23 23:59 ` [patch 2/7] genhd: expose AN to user space Kristen Carlson Accardi
2007-04-24 8:05 ` Tejun Heo
2007-04-24 21:30 ` Kristen Carlson Accardi
2007-05-04 18:15 ` [patch 2/7] genhd: expose AN to user space - resend Kristen Carlson Accardi
2007-04-23 23:59 ` [patch 3/7] scsi: expose AN to user space Kristen Carlson Accardi
2007-04-24 0:00 ` [patch 4/7] libata: " Kristen Carlson Accardi
2007-04-24 0:00 ` [patch 5/7] genhd: send async notification on media change Kristen Carlson Accardi
2007-04-24 8:20 ` Tejun Heo
2007-04-24 21:36 ` Kristen Carlson Accardi
2007-05-04 18:17 ` Kristen Carlson Accardi
2007-04-24 0:00 ` [patch 6/7] SCSI: save disk in scsi_device Kristen Carlson Accardi
2007-04-24 0:00 ` [patch 7/7] libata: send event when AN received Kristen Carlson Accardi
2007-04-24 8:09 ` Alan Cox
2007-04-24 21:38 ` Kristen Carlson Accardi
2007-05-04 18:18 ` [patch 7/7] libata: send event when AN received - resend Kristen Carlson Accardi
2007-05-04 18:16 ` [patch 3/7] scsi: expose AN to user space " Kristen Carlson Accardi
2007-05-04 18:16 ` [patch 4/7] libata: " Kristen Carlson Accardi
2007-05-04 18:17 ` [patch 6/7] SCSI: save disk in scsi_device " Kristen Carlson Accardi
2007-05-04 20:30 ` James Bottomley
2007-05-07 15:29 ` Kristen Carlson Accardi
2007-05-09 22:50 ` Kristen Carlson Accardi [this message]
2007-05-09 23:04 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070509155032.57c3a55d.kristen.c.accardi@intel.com \
--to=kristen.c.accardi@intel.com \
--cc=James.Bottomley@SteelEye.com \
--cc=akpm@linux-foundation.org \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®