From: Pavel Machek <pavel@ucw.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Nigel Cunningham <nigel@nigel.suspend2.net>,
Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: [PATCH -mm] PM: Separate hibernation code from suspend code
Date: Sat, 5 May 2007 23:01:39 +0200 [thread overview]
Message-ID: <20070505210139.GA26652@elf.ucw.cz> (raw)
In-Reply-To: <200705051550.53436.rjw@sisk.pl>
Hi!
> > > Power off the system instead of halting it if the 'platform' mode of
> > > hibernation
> > > has been requested, but hibernation_ops is not set.
> >
> > Ehm, unless you made a mistake in the patch then that shouldn't be
> > possible.
>
> Hmm, right, but the patch is correct nevertheless. :-)
>
> I see where the problem is. hibernation_mode is 0 by default
> (HIBERNATION_INVALID) and it's not changed to anything else later if
> defaults are used.
> Something like this is necessary, I think:
>
> ---
> From: Rafael J. Wysocki <rjw@sisk.pl>
>
> Make sure that hibernation_mode is set to a reasonable value by default.
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
ACK.
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2007-05-05 21:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-04 9:32 Rafael J. Wysocki
2007-05-04 17:22 ` Satyam Sharma
2007-05-04 22:47 ` Rafael J. Wysocki
2007-05-05 6:31 ` Andrew Morton
2007-05-05 10:16 ` Rafael J. Wysocki
2007-05-05 12:21 ` Rafael J. Wysocki
2007-05-05 12:27 ` Johannes Berg
2007-05-05 13:50 ` Rafael J. Wysocki
2007-05-05 21:01 ` Pavel Machek [this message]
2007-05-07 11:46 ` Johannes Berg
2007-05-07 11:56 ` Johannes Berg
2007-05-07 21:35 ` Rafael J. Wysocki
2007-05-08 8:41 ` Johannes Berg
2007-05-08 11:05 ` Rafael J. Wysocki
2007-05-08 20:46 ` [PATCH -mm] swsusp: Use reasonable default for hibernation_mode Rafael J. Wysocki
2007-05-05 16:55 ` [PATCH -mm] PM: Separate hibernation code from suspend code Jason L Tibbitts III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070505210139.GA26652@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@linux-foundation.org \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=nigel@nigel.suspend2.net \
--cc=penberg@cs.helsinki.fi \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®