From: Oleg Verych <olecom@flower.upol.cz>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
kbuild-devel@lists.sourceforge.net,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [kbuild-devel] [PATCH 08/19] scripts: Make cleanfile/cleanpatch warn about long lines
Date: Tue, 5 Jun 2007 15:38:34 +0200 [thread overview]
Message-ID: <20070605133834.GO7266@flower.upol.cz> (raw)
In-Reply-To: <20070605081959.GB21991@uranus.ravnborg.org>
On Tue, Jun 05, 2007 at 10:19:59AM +0200, Sam Ravnborg wrote:
[]
> If on the other hand you are proposing a script to clean whitespace
> damage in the code then git already does this nicely.
I've read that too quickly, sorry. What then all that clean scripts
are for?
> I do not recall the actual receipt but searching the git mailing list
> should reveal it. So for whitespace cleanup we should use git but maybe
> via a small helper script.
So, just to protect script from itself or similar one, here's update
(only for those, who's interested, of course).
-*- clean-whitespace.sh -*-
#!/bin/sh -e
# stdin/stdout
IFS=''
t="`printf '\t'`" ; s=' ' ; s7=' ' ; w79=79 ;
case $0 in *diff* | *patch*) p='+' ; s='';; esac
while read line
do case "$line" in
++*) echo "$line";;
$p*) line="`echo \"$line\" | expand`"
[ ${#line} -gt $w79 ] && : ${long:=line}
echo "$line" | sed "/^$p/{s_ *\$__;s_^$p$s7${s}_$p${t}_;s_$s7 _${t}_g}"
;;
*) echo "$line";;
esac
done
[ -n "$long" ] && echo "at least one line, wider than $w79 chars, found" 1>&2
-*-
next prev parent reply other threads:[~2007-06-05 13:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-03 20:47 Sam Ravnborg
2007-06-04 16:07 ` Jan Engelhardt
2007-06-05 7:33 ` [kbuild-devel] " Oleg Verych
2007-06-05 8:19 ` Sam Ravnborg
2007-06-05 12:48 ` Oleg Verych
2007-06-05 13:38 ` Oleg Verych [this message]
2007-06-05 14:12 ` Sam Ravnborg
2007-06-05 14:57 ` Oleg Verych
2007-06-05 15:11 ` Oleg Verych
2007-06-06 17:45 ` Another version of cleanfile/cleanpatch (Re: [PATCH 08/19] scripts: Make cleanfile/cleanpatch warn about long lines) Oleg Verych
2007-06-06 17:50 ` Sam Ravnborg
2007-06-06 19:14 ` Another version of cleanfile/cleanpatch Oleg Verych
2007-06-07 14:36 ` Jan Engelhardt
2007-06-07 23:06 ` Oleg Verych
2007-06-07 23:19 ` [kbuild-devel] " H. Peter Anvin
2007-06-08 1:35 ` Oleg Verych
2007-06-08 6:40 ` [patch] scripts: clean-whitespace.sh Oleg Verych
2007-06-08 6:44 ` Andrew Morton
2007-06-08 14:28 ` Sam Ravnborg
2007-06-08 15:02 ` Oleg Verych
2007-06-08 19:05 ` Sam Ravnborg
2007-06-08 21:07 ` Oleg Verych
2007-06-08 5:27 ` Another version of cleanfile/cleanpatch Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070605133834.GO7266@flower.upol.cz \
--to=olecom@flower.upol.cz \
--cc=akpm@linux-foundation.org \
--cc=kbuild-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®