From: Oleg Verych <olecom@flower.upol.cz>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Jan Engelhardt <jengelh@computergmbh.de>,
kbuild-devel@lists.sourceforge.net,
Andrew Morton <akpm@linux-foundation.org>,
Sam Ravnborg <sam@ravnborg.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: Another version of cleanfile/cleanpatch
Date: Fri, 8 Jun 2007 03:35:21 +0200 [thread overview]
Message-ID: <20070608013521.GW7266@flower.upol.cz> (raw)
In-Reply-To: <4668929C.7040209@zytor.com>
On Thu, Jun 07, 2007 at 04:19:56PM -0700, H. Peter Anvin wrote:
> Oleg Verych wrote:
> >
> > Because of that, i think, following is redundant:
> >
> > - to check for binary files
>
> find . -type f | xargs cleanfile
What about patches?
Anyway, by agreement (with myself), i've stopped on having per-file-name
division (prev. message first patch, and that was last design remaining
from cleanfile/cleanpatch). So:
for f in $*
do clean-whitespace $f 2>&1 >/dev/null
done
But this doesn't look like interactive usage, which i've concluded.
Plus copy is saved in $f.clean file, so user can `diff -u` to see any
destruction and possibly report a bug.
[]
> > - scan whole file for long lines, with useless bunch of messages about
> > ones. Useless, because script doesn't fix that, it can't do that!
>
> Still useful to let the human know what is going on, and why.
What i've done was `cleanpatch patch-2.6.21-rc4-rc5`
That's where usefulness comes from ;)
> -hpa
____
next prev parent reply other threads:[~2007-06-08 1:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-03 20:47 [PATCH 08/19] scripts: Make cleanfile/cleanpatch warn about long lines Sam Ravnborg
2007-06-04 16:07 ` Jan Engelhardt
2007-06-05 7:33 ` [kbuild-devel] " Oleg Verych
2007-06-05 8:19 ` Sam Ravnborg
2007-06-05 12:48 ` Oleg Verych
2007-06-05 13:38 ` Oleg Verych
2007-06-05 14:12 ` Sam Ravnborg
2007-06-05 14:57 ` Oleg Verych
2007-06-05 15:11 ` Oleg Verych
2007-06-06 17:45 ` Another version of cleanfile/cleanpatch (Re: [PATCH 08/19] scripts: Make cleanfile/cleanpatch warn about long lines) Oleg Verych
2007-06-06 17:50 ` Sam Ravnborg
2007-06-06 19:14 ` Another version of cleanfile/cleanpatch Oleg Verych
2007-06-07 14:36 ` Jan Engelhardt
2007-06-07 23:06 ` Oleg Verych
2007-06-07 23:19 ` [kbuild-devel] " H. Peter Anvin
2007-06-08 1:35 ` Oleg Verych [this message]
2007-06-08 6:40 ` [patch] scripts: clean-whitespace.sh Oleg Verych
2007-06-08 6:44 ` Andrew Morton
2007-06-08 14:28 ` Sam Ravnborg
2007-06-08 15:02 ` Oleg Verych
2007-06-08 19:05 ` Sam Ravnborg
2007-06-08 21:07 ` Oleg Verych
2007-06-08 5:27 ` Another version of cleanfile/cleanpatch Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070608013521.GW7266@flower.upol.cz \
--to=olecom@flower.upol.cz \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=jengelh@computergmbh.de \
--cc=kbuild-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®