mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: holzheu <holzheu@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, randy.dunlap@oracle.com,
	gregkh@suse.de, mtk-manpages@gmx.net, schwidefsky@de.ibm.com,
	heiko.carstens@de.ibm.com,
	"lf_kernel_messages@linux-foundation.org" 
	<lf_kernel_messages@linux-foundation.org>
Subject: Re: [RFC/PATCH] Documentation of kernel messages
Date: Thu, 14 Jun 2007 14:26:39 +0200	[thread overview]
Message-ID: <20070614122639.GI13141@duck.suse.cz> (raw)
In-Reply-To: <1181821661.10064.27.camel@localhost.localdomain>

On Thu 14-06-07 13:47:41, holzheu wrote:
> On Thu, 2007-06-14 at 12:38 +0200, holzheu wrote:
> > On Thu, 2007-06-14 at 11:41 +0200, Jan Kara wrote:
> > >   <snip>
> > > 
> > > > Your proposal is similar to one I made to some Japanese developers
> > > > earlier this year.  I was more modest, proposing that we
> > > > 
> > > > - add an enhanced printk
> > > > 
> > > > 	xxprintk(msgid, KERN_ERR "some text %d\n", some_number);
> > >   Maybe a stupid idea but why do we want to assign these numbers by hand?
> > > I can imagine it could introduce collisions when merging tons of patches
> > > with new messages... Wouldn't it be better to compute say, 8-byte hash
> > > from the message and use it as it's identifier? We could do this
> > > automagically at compile time.
> > 
> > Of course automatically generated message numbers would be great and
> > something like:
> > 
> > hub.4a5bcd77: Detected some problem.
> 
> Sorry, I first read: 8 characters not 8 bytes.
> 
> Indeed, "hub.d41d8cd98f00b204: Detected some problem." ... does not look
> like very beautiful.
> 
> But maybe also 4 bytes would be enough, since the hash only has to be
> unique within one component e.g. "hub".
  It depends how large components you expect. For example for 10000
messages there is already 1% probability of collision so it means sooner or
later we are going to hit it... For 1000 messages the probability is
roughly 0.1% which is still not so small that I'd be comfortable with it.
On the other hand we could use something like gperf to generate perfect
hashing function and then we don't have to worry about colisions.

									Honza
-- 
Jan Kara <jack@suse.cz>
SuSE CR Labs

  reply	other threads:[~2007-06-14 12:13 UTC|newest]

Thread overview: 133+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-13 15:06 holzheu
2007-06-13 16:37 ` Dave Hansen
2007-06-13 17:11   ` Sam Ravnborg
2007-06-13 17:42   ` holzheu
2007-06-13 16:50 ` Valdis.Kletnieks
2007-06-13 18:09   ` Rob Landley
2007-06-13 18:11   ` holzheu
2007-06-14  8:47     ` Krzysztof Halasa
2007-06-15  8:49   ` Jan Engelhardt
2007-06-13 17:16 ` Alexey Dobriyan
2007-06-13 17:46   ` holzheu
2007-06-13 17:51 ` Greg KH
2007-06-13 18:18   ` holzheu
2007-06-13 18:32     ` Greg KH
2007-06-13 18:49       ` Dave Hansen
2007-06-13 18:49       ` Kok, Auke
2007-06-14  8:17       ` Martin Schwidefsky
2007-06-13 19:04     ` Joe Perches
2007-06-14  2:54       ` Valdis.Kletnieks
2007-06-14  7:05         ` H. Peter Anvin
2007-06-15  8:51       ` Jan Engelhardt
2007-06-13 18:15 ` Andrew Morton
2007-06-14  8:31   ` Martin Schwidefsky
2007-06-14  9:41   ` Jan Kara
2007-06-14 10:38     ` holzheu
2007-06-14 11:47       ` holzheu
2007-06-14 12:26         ` Jan Kara [this message]
2007-06-14 15:22           ` holzheu
2007-06-15 18:42       ` Gerrit Huizenga
2007-06-15 18:51         ` Randy Dunlap
2007-06-15 19:27           ` Gerrit Huizenga
2007-06-15 20:01           ` Greg KH
2007-06-18 12:55         ` holzheu
2007-06-18 13:12           ` Arjan van de Ven
2007-06-18 13:33             ` Jan Kara
2007-06-18 13:53             ` holzheu
2007-06-19  1:36               ` Arjan van de Ven
2007-06-19  8:51                 ` holzheu
2007-06-19 19:24                   ` Arjan van de Ven
2007-06-19 11:31                 ` holzheu
2007-06-19  5:41           ` [Lf_kernel_messages] " Kunai, Takashi
2007-06-18 13:11         ` Sam Ravnborg
2007-06-18 15:35           ` Randy Dunlap
2007-06-19  0:13         ` Tim Bird
2007-06-19  3:52           ` Gerrit Huizenga
2007-06-15 12:40     ` Pavel Machek
2007-06-18 13:42       ` holzheu
2007-06-18 14:02         ` Pavel Machek
2007-06-25 13:48   ` Documentation of kernel messages (Summary) Michael Holzheu
2007-06-25 15:44     ` Rob Landley
2007-06-25 18:05       ` Sam Ravnborg
2007-06-27 15:11       ` Michael Holzheu
2007-07-09  5:15         ` Kunai, Takashi
2007-07-09  5:36           ` H. Peter Anvin
2007-07-09 16:48             ` Rob Landley
2007-07-09 17:18               ` Gerrit Huizenga
2007-07-10 16:12                 ` Rob Landley
2007-07-11 12:15                   ` Michael Holzheu
2007-07-11 14:26                   ` Li Yang
2007-07-11 18:13                     ` Rob Landley
2007-07-11 21:32                       ` Theodore Tso
2007-07-13 10:53                         ` Alan Cox
2007-07-13 12:49                           ` Li Yang
2007-07-13 13:43                             ` Theodore Tso
2007-07-13 13:25                           ` Stefan Richter
2007-07-13 21:10                             ` Valdis.Kletnieks
2007-07-13 18:05                           ` Rob Landley
2007-07-14  3:54                             ` Randy Dunlap
2007-07-15  1:56                               ` Rob Landley
2007-07-15 16:28                                 ` Randy Dunlap
2007-07-16 19:53                                   ` Rob Landley
2007-08-03 18:11                                     ` Randy Dunlap
2007-08-03 19:32                                       ` Rob Landley
2007-08-04  3:50                                         ` Greg KH
2007-08-04 19:02                                           ` Rob Landley
2007-08-04  3:52                                         ` Greg KH
2007-08-04 18:54                                           ` Rob Landley
2007-08-04 20:04                                             ` Stefan Richter
2007-08-06 15:50                                               ` Rob Landley
2007-07-11 21:53                       ` Valdis.Kletnieks
2007-07-12 16:56                         ` Rob Landley
2007-07-12 13:53                       ` Li Yang-r58472
2007-07-12 16:05                         ` [PATCH] Chinese Language Maintainer Rob Landley
2007-07-12 19:52                           ` Geert Uytterhoeven
2007-07-12 20:02                           ` Pavel Machek
2007-07-13  7:42                             ` Geert Uytterhoeven
2007-07-13 16:06                             ` Rob Landley
2007-07-13 12:43                           ` Li Yang
2007-07-13 17:52                             ` Rob Landley
2007-07-15 14:42                               ` Li Yang
2007-07-15 18:12                                 ` H. Peter Anvin
2007-07-15 18:50                                   ` Alan Cox
2007-07-15 19:11                                     ` H. Peter Anvin
2007-07-15 20:25                                       ` Rik van Riel
2007-07-16  4:40                                     ` Ganesan Rajagopal
2007-07-16 21:43                                       ` Alan Cox
2007-07-17  7:19                                         ` Ganesan Rajagopal
2007-07-15 18:53                                   ` Li Yang
2007-07-15 20:25                                   ` Rene Herman
2007-07-16  9:17                                   ` Dr. Keith G. Bowden
2007-07-16  2:49                                 ` Tsugikazu Shibata
2007-07-16  3:03                                   ` H. Peter Anvin
2007-07-17 16:24                                   ` Li Yang
2007-07-17 21:06                                     ` Rob Landley
2007-07-12 16:41                         ` Documentation of kernel messages (Summary) Tsugikazu Shibata
2007-07-12 17:35                         ` Rob Landley
2007-07-13  2:54                           ` Tsugikazu Shibata
2007-07-13 17:12                             ` Rob Landley
2007-07-14  1:46                               ` Tsugikazu Shibata
2007-07-15  2:12                                 ` Rob Landley
2007-07-15 16:46                                   ` Tsugikazu Shibata
2007-07-17 16:06                                     ` Rob Landley
2007-07-17 23:30                                       ` Tsugikazu Shibata
2007-07-13 11:54                           ` Li Yang
2007-07-15 20:30                             ` Rik van Riel
2007-07-09 18:33               ` Adrian Bunk
2007-07-10 16:25                 ` Rob Landley
2007-07-10 18:54                   ` Adrian Bunk
2007-07-10 19:53                     ` Rob Landley
2007-07-17  0:31                   ` Tim Bird
2007-07-17  1:17                     ` H. Peter Anvin
2007-07-17 16:42                       ` Rob Landley
2007-07-17 16:29                     ` Rob Landley
2007-07-10  7:59               ` Li Yang-r58472
2007-07-10  6:38             ` Dave Young
2007-07-09  7:01           ` Oliver Neukum
2007-07-09 22:59             ` Satyam Sharma
2007-07-10  6:15               ` Oliver Neukum
2007-07-09 18:10       ` [Lf_kernel_messages] " Theodore Tso
2007-07-09 22:12         ` Alan Cox
2007-07-10 16:50         ` Rob Landley
2007-06-13 18:23 ` [RFC/PATCH] Documentation of kernel messages David Miller
2007-06-13 18:27   ` holzheu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070614122639.GI13141@duck.suse.cz \
    --to=jack@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=gregkh@suse.de \
    --cc=heiko.carstens@de.ibm.com \
    --cc=holzheu@linux.vnet.ibm.com \
    --cc=lf_kernel_messages@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtk-manpages@gmx.net \
    --cc=randy.dunlap@oracle.com \
    --cc=schwidefsky@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®