[PATCH] XFS: Replace remaining memclear_highpage_flush() with zero_user_page().

[PATCH] XFS: Replace remaining memclear_highpage_flush() with zero_user_page().

[Robert P. J. Day]

Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>

---

  this appears to be the final occurrence of that deprecated call in
the entire tree which suggests that, if you're not concerned about
out-of-tree modules, that definition could also be removed from
include/linux/highmem.h:

static inline void __deprecated memclear_highpage_flush(struct page *page,
                        unsigned int offset, unsigned int size)
{
        zero_user_page(page, offset, size, KM_USER0);
}


diff --git a/fs/xfs/linux-2.6/xfs_lrw.c b/fs/xfs/linux-2.6/xfs_lrw.c
index 86fb671..ed90403 100644
--- a/fs/xfs/linux-2.6/xfs_lrw.c
+++ b/fs/xfs/linux-2.6/xfs_lrw.c
@@ -159,7 +159,7 @@ xfs_iozero(
 		if (status)
 			goto unlock;

-		memclear_highpage_flush(page, offset, bytes);
+		zero_user_page(page, offset, bytes, KM_USER0);

 		status = mapping->a_ops->commit_write(NULL, page, offset,
 							offset + bytes);
-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================

Re: [PATCH] XFS: Replace remaining memclear_highpage_flush() with zero_user_page().

[Christoph Hellwig]

On Mon, Jun 18, 2007 at 11:59:30AM -0400, Robert P. J. Day wrote:
> 
> Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
> 
> ---
> 
>   this appears to be the final occurrence of that deprecated call in
> the entire tree which suggests that, if you're not concerned about
> out-of-tree modules, that definition could also be removed from
> include/linux/highmem.h:
> 
> static inline void __deprecated memclear_highpage_flush(struct page *page,
>                         unsigned int offset, unsigned int size)
> {
>         zero_user_page(page, offset, size, KM_USER0);
> }

Andrew, please send this and the memclear_highpage_flush removal to Linus
for 2.6.22-rc.  The warning is really highly annoying and utterly pointless.

Re: [PATCH] XFS: Replace remaining memclear_highpage_flush() with zero_user_page().

[Hans-Peter Jansen]

Am Montag, 18. Juni 2007 20:43 schrieb Christoph Hellwig:
> On Mon, Jun 18, 2007 at 11:59:30AM -0400, Robert P. J. Day wrote:
> > Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>

FYI, this patch got attributed to Christoph in Linus' tree with commit 
700716c8468d95ec6d03566a4e4fb576c3223cbc..

Cheers,
  hp


> > ---
> >
> >   this appears to be the final occurrence of that deprecated call in
> > the entire tree which suggests that, if you're not concerned about
> > out-of-tree modules, that definition could also be removed from
> > include/linux/highmem.h:
> >
> > static inline void __deprecated memclear_highpage_flush(struct page
> > *page, unsigned int offset, unsigned int size) {
> >         zero_user_page(page, offset, size, KM_USER0);
> > }
>
> Andrew, please send this and the memclear_highpage_flush removal to Linus
> for 2.6.22-rc.  The warning is really highly annoying and utterly
> pointless. -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel"
> in the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/