mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: <gregkh@suse.de>
To: cornelia.huck@de.ibm.com, gregkh@suse.de, kay.sievers@vrfy.org,
	linux-kernel@vger.kernel.org, simon@fire.lp0.eu
Subject: patch driver-core-revert-device-link-creation-check.patch added to gregkh-2.6 tree
Date: Mon, 30 Jul 2007 12:12:24 -0700	[thread overview]
Message-ID: <20070730191231.C9D1C14458DB@imap.suse.de> (raw)
In-Reply-To: <20070725095808.09b2cc2a@gondolin.boeblingen.de.ibm.com>


This is a note to let you know that I've just added the patch titled

     Subject: driver core: revert "device" link creation check

to my gregkh-2.6 tree.  Its filename is

     driver-core-revert-device-link-creation-check.patch

This tree can be found at 
    http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/


>From cornelia.huck@de.ibm.com Wed Jul 25 00:58:00 2007
From: Cornelia Huck <cornelia.huck@de.ibm.com>
Date: Wed, 25 Jul 2007 09:58:08 +0200
Subject: driver core: revert "device" link creation check
To: "Kay Sievers" <kay.sievers@vrfy.org>
Cc: "Simon Arlott" <simon@fire.lp0.eu>, "Greg KH" <gregkh@suse.de>, "Linux  Kernel Mailing List" <linux-kernel@vger.kernel.org>
Message-ID: <20070725095808.09b2cc2a@gondolin.boeblingen.de.ibm.com>

From: Cornelia Huck <cornelia.huck@de.ibm.com>

driver core: revert "device" link creation check

Commit 2ee97caf0a6602f749ddbfdb1449e383e1212707 introduced an extra
check on when to create the "device" symlink. Unfortunately, this
breaks input, so let's revert to the old behaviour.

Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Acked-by: Kay Sievers <kay.sievers@vrfy.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>


---
 drivers/base/core.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -692,8 +692,7 @@ static int device_add_class_symlinks(str
 		if (error)
 			goto out_subsys;
 	}
-	/* only bus-device parents get a "device"-link */
-	if (dev->parent && dev->parent->bus) {
+	if (dev->parent) {
 		error = sysfs_create_link(&dev->kobj, &dev->parent->kobj,
 					  "device");
 		if (error)


Patches currently in gregkh-2.6 which might be from cornelia.huck@de.ibm.com are

driver/kobject-fix-link-error-when-config_hotplug-is-disabled.patch
driver/driver-core-revert-device-link-creation-check.patch
driver/kobject-update-documentation.patch
driver/kset-kernel-doc-cleanups.patch

      parent reply	other threads:[~2007-07-30 19:12 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-24  6:39 sysfs/udev broken in latest git? Simon Arlott
2007-07-24  7:25 ` Greg KH
2007-07-24  8:03   ` Cornelia Huck
2007-07-24  8:46     ` Greg KH
2007-07-24  9:20       ` Kay Sievers
2007-07-24 11:49         ` Simon Arlott
2007-07-24 11:55           ` Kay Sievers
2007-07-24 12:00             ` Simon Arlott
2007-07-24 12:54         ` Cornelia Huck
2007-07-24 16:28           ` sysfs/udev broken in 2.6.23-rc1 [input, i2c, ...] (Was: sysfs/udev broken in latest git?) Simon Arlott
2007-07-24 16:34             ` Kay Sievers
2007-07-24 16:57               ` Simon Arlott
2007-07-25  0:19                 ` Kay Sievers
2007-07-25  7:58                   ` Cornelia Huck
2007-07-26  0:11                     ` Greg KH
2007-07-26  0:17                       ` Kay Sievers
2007-07-30 19:12                     ` gregkh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070730191231.C9D1C14458DB@imap.suse.de \
    --to=gregkh@suse.de \
    --cc=cornelia.huck@de.ibm.com \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=simon@fire.lp0.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®