From: "Kay Sievers" <kay.sievers@vrfy.org>
To: "Simon Arlott" <simon@fire.lp0.eu>
Cc: "Cornelia Huck" <cornelia.huck@de.ibm.com>,
"Greg KH" <gregkh@suse.de>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: sysfs/udev broken in 2.6.23-rc1 [input, i2c, ...] (Was: sysfs/udev broken in latest git?)
Date: Tue, 24 Jul 2007 18:34:31 +0200 [thread overview]
Message-ID: <3ae72650707240934o68047677n97e6081ff3f42ce7@mail.gmail.com> (raw)
In-Reply-To: <46A628AC.3060900@simon.arlott.org.uk>
On 7/24/07, Simon Arlott <simon@fire.lp0.eu> wrote:
> On 24/07/07 13:54, Cornelia Huck wrote:
> > On Tue, 24 Jul 2007 11:20:02 +0200,
> > "Kay Sievers" <kay.sievers@vrfy.org> wrote:
> >
> >> It looks fine to me. "device" links must never point to anything else
> >> than a bus device.
> >
> > Hm, but then
> > 1. The patch sneaks this check in (the old code only checked for
> > dev->parent)
> > 2. The code is rather inconsistent now, since none of the other code
> > paths check for dev->parent->bus...
>
> Removing the dev->parent->bus check fixes it:
>
> [ 40.043981] serio: i8042 KBD port at 0x60,0x64 irq 1
> [ 40.044653] mice: PS/2 mouse device common for all mice
> [ 40.044792] dev->parent && !dev->parent->bus:
> [ 40.044794] dev->kobj->k_name=event0
> [ 40.044796] dev->kobj->name=event0
> [ 40.044798] dev->parent->kobj->k_name=input0
> [ 40.044800] dev->parent->kobj->name=input0
>
> [ 40.044948] dev->parent && !dev->parent->bus:
> [ 40.044951] dev->kobj->k_name=event1
> [ 40.044952] dev->kobj->name=event1
> [ 40.044954] dev->parent->kobj->k_name=input1
> [ 40.044956] dev->parent->kobj->name=input1
>
> [ 40.045075] dev->parent && !dev->parent->bus:
> [ 40.045077] dev->kobj->k_name=event2
> [ 40.045079] dev->kobj->name=event2
> [ 40.045080] dev->parent->kobj->k_name=input2
> [ 40.045082] dev->parent->kobj->name=input2
>
> [ 40.067204] input: AT Translated Set 2 keyboard as /class/input/input3
> [ 40.067368] dev->parent && !dev->parent->bus:
> [ 40.067370] dev->kobj->k_name=event3
> [ 40.067372] dev->kobj->name=event3
> [ 40.067373] dev->parent->kobj->k_name=input3
> [ 40.067375] dev->parent->kobj->name=input3
>
> [ 40.067713] i2c /dev entries driver
> [ 40.068190] dev->parent && !dev->parent->bus:
> [ 40.068193] dev->kobj->k_name=i2c-0
> [ 40.068195] dev->kobj->name=i2c-0
> [ 40.068196] dev->parent->kobj->k_name=i2c-0
> [ 40.068198] dev->parent->kobj->name=i2c-0
>
> [ 40.068386] dev->parent && !dev->parent->bus:
> [ 40.068389] dev->kobj->k_name=i2c-9191
> [ 40.068391] dev->kobj->name=i2c-9191
> [ 40.068392] dev->parent->kobj->k_name=platform
> [ 40.068394] dev->parent->kobj->name=platform
>
> [ 40.068892] dev->parent && !dev->parent->bus:
> [ 40.068895] dev->kobj->k_name=i2c-1
> [ 40.068896] dev->kobj->name=i2c-1
> [ 40.068898] dev->parent->kobj->k_name=i2c-1
> [ 40.068899] dev->parent->kobj->name=i2c-1
>
> [ 40.085201] input: Logitech USB-PS/2 Optical Mouse as /class/input/input4
> [ 40.085362] dev->parent && !dev->parent->bus:
> [ 40.085365] dev->kobj->k_name=mouse0
> [ 40.085367] dev->kobj->name=mouse0
> [ 40.085368] dev->parent->kobj->k_name=input4
> [ 40.085370] dev->parent->kobj->name=input4
>
> [ 40.085528] dev->parent && !dev->parent->bus:
> [ 40.085530] dev->kobj->k_name=event4
> [ 40.085532] dev->kobj->name=event4
> [ 40.085534] dev->parent->kobj->k_name=input4
> [ 40.085535] dev->parent->kobj->name=input4
Strange.
What's the setting of CONFIG_SYSFS_DEPRECATED? Maybe there is
something that needs to be fixed in the block patch where the code
snippet is coming from.
Thanks,
Kay
next prev parent reply other threads:[~2007-07-24 16:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-24 6:39 sysfs/udev broken in latest git? Simon Arlott
2007-07-24 7:25 ` Greg KH
2007-07-24 8:03 ` Cornelia Huck
2007-07-24 8:46 ` Greg KH
2007-07-24 9:20 ` Kay Sievers
2007-07-24 11:49 ` Simon Arlott
2007-07-24 11:55 ` Kay Sievers
2007-07-24 12:00 ` Simon Arlott
2007-07-24 12:54 ` Cornelia Huck
2007-07-24 16:28 ` sysfs/udev broken in 2.6.23-rc1 [input, i2c, ...] (Was: sysfs/udev broken in latest git?) Simon Arlott
2007-07-24 16:34 ` Kay Sievers [this message]
2007-07-24 16:57 ` Simon Arlott
2007-07-25 0:19 ` Kay Sievers
2007-07-25 7:58 ` Cornelia Huck
2007-07-26 0:11 ` Greg KH
2007-07-26 0:17 ` Kay Sievers
2007-07-30 19:12 ` patch driver-core-revert-device-link-creation-check.patch added to gregkh-2.6 tree gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ae72650707240934o68047677n97e6081ff3f42ce7@mail.gmail.com \
--to=kay.sievers@vrfy.org \
--cc=cornelia.huck@de.ibm.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=simon@fire.lp0.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®