* [PATCH -mm] add-a-rounddown_pow_of_two-routine-to-log2h.patch fix
@ 2007-09-01 5:55 Mariusz Kozlowski
2007-09-01 6:46 ` Robert P. J. Day
2007-09-12 3:43 ` Andrew Morton
0 siblings, 2 replies; 3+ messages in thread
From: Mariusz Kozlowski @ 2007-09-01 5:55 UTC (permalink / raw)
To: Andrew Morton; +Cc: Robert Day, lkml
Hello,
This patch fixes the unbalanced parenthesis inroduced by
add-a-rounddown_pow_of_two-routine-to-log2h.patch.
Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
include/linux/log2.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.23-rc4-mm1-a/include/linux/log2.h 2007-09-01 07:23:28.000000000 +0200
+++ linux-2.6.23-rc4-mm1-b/include/linux/log2.h 2007-09-01 07:29:27.000000000 +0200
@@ -186,7 +186,7 @@ unsigned long __rounddown_pow_of_two(uns
( \
__builtin_constant_p(n) ? ( \
(n == 1) ? 0 : \
- (1UL << ilog2(n)) : \
+ (1UL << ilog2(n))) : \
__rounddown_pow_of_two(n) \
)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -mm] add-a-rounddown_pow_of_two-routine-to-log2h.patch fix
2007-09-01 5:55 [PATCH -mm] add-a-rounddown_pow_of_two-routine-to-log2h.patch fix Mariusz Kozlowski
@ 2007-09-01 6:46 ` Robert P. J. Day
2007-09-12 3:43 ` Andrew Morton
1 sibling, 0 replies; 3+ messages in thread
From: Robert P. J. Day @ 2007-09-01 6:46 UTC (permalink / raw)
To: Mariusz Kozlowski; +Cc: Andrew Morton, lkml
On Sat, 1 Sep 2007, Mariusz Kozlowski wrote:
> Hello,
>
> This patch fixes the unbalanced parenthesis inroduced by
> add-a-rounddown_pow_of_two-routine-to-log2h.patch.
>
> Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
>
> include/linux/log2.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2.6.23-rc4-mm1-a/include/linux/log2.h 2007-09-01 07:23:28.000000000 +0200
> +++ linux-2.6.23-rc4-mm1-b/include/linux/log2.h 2007-09-01 07:29:27.000000000 +0200
> @@ -186,7 +186,7 @@ unsigned long __rounddown_pow_of_two(uns
> ( \
> __builtin_constant_p(n) ? ( \
> (n == 1) ? 0 : \
> - (1UL << ilog2(n)) : \
> + (1UL << ilog2(n))) : \
> __rounddown_pow_of_two(n) \
> )
>
> -
oh, crap ... how did that happen? sorry.
rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://crashcourse.ca
========================================================================
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -mm] add-a-rounddown_pow_of_two-routine-to-log2h.patch fix
2007-09-01 5:55 [PATCH -mm] add-a-rounddown_pow_of_two-routine-to-log2h.patch fix Mariusz Kozlowski
2007-09-01 6:46 ` Robert P. J. Day
@ 2007-09-12 3:43 ` Andrew Morton
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2007-09-12 3:43 UTC (permalink / raw)
To: Mariusz Kozlowski; +Cc: Robert Day, lkml
On Sat, 1 Sep 2007 07:55:36 +0200 Mariusz Kozlowski <m.kozlowski@tuxland.pl> wrote:
> Hello,
>
> This patch fixes the unbalanced parenthesis inroduced by
> add-a-rounddown_pow_of_two-routine-to-log2h.patch.
>
> Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
>
> include/linux/log2.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2.6.23-rc4-mm1-a/include/linux/log2.h 2007-09-01 07:23:28.000000000 +0200
> +++ linux-2.6.23-rc4-mm1-b/include/linux/log2.h 2007-09-01 07:29:27.000000000 +0200
> @@ -186,7 +186,7 @@ unsigned long __rounddown_pow_of_two(uns
> ( \
> __builtin_constant_p(n) ? ( \
> (n == 1) ? 0 : \
> - (1UL << ilog2(n)) : \
> + (1UL << ilog2(n))) : \
> __rounddown_pow_of_two(n) \
> )
umm, could we get some users of this thing, preferably in some code
path which people use?
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-09-12 3:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-09-01 5:55 [PATCH -mm] add-a-rounddown_pow_of_two-routine-to-log2h.patch fix Mariusz Kozlowski
2007-09-01 6:46 ` Robert P. J. Day
2007-09-12 3:43 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®