From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Dirk Hohndel <hohndel@linux.intel.com>
Cc: Jens Axboe <jens.axboe@oracle.com>, Andries Brouwer <aeb@cwi.nl>,
Al Viro <viro@ftp.linux.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] add_partition silently ignored errors
Date: Tue, 30 Oct 2007 18:31:12 +0100 [thread overview]
Message-ID: <20071030183112.7e860c23@gondolin.boeblingen.de.ibm.com> (raw)
In-Reply-To: <20071030165608.GA2601@linux.intel.com>
On Tue, 30 Oct 2007 09:56:08 -0700,
Dirk Hohndel <hohndel@linux.intel.com> wrote:
> > > IIRC, Al recently vetoed a similar patch. As far as I'm concerned, with
> > > the correct return values, the patch then looks fine to me.
> >
> > We need some kind of check concerning the kobject to avoid mysterious
> > errors (especially checking for the failed kobject_add() is needed).
> > Whether we want just to inform the user of the failure instead of
> > failing the function is another question.
>
> What are you suggesting? I'd love to make the behaviour consistent everywhere
> (and am willing to go through things in order to make that happen), but what is
> the consistent behaviour that we'd want?
I'd be fine with just propagating the error after cleanup (that is what
for example the driver core usually does), but I don't know the
surrounding code well enough for a definitive answer.
next prev parent reply other threads:[~2007-10-30 17:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-29 12:22 Dirk Hohndel
2007-10-29 13:06 ` Cornelia Huck
2007-10-29 14:24 ` Dirk Hohndel
2007-10-29 14:43 ` Cornelia Huck
2007-10-29 15:48 ` Dirk Hohndel
2007-10-29 16:47 ` Cornelia Huck
2007-10-30 8:07 ` Jens Axboe
2007-10-30 9:09 ` Cornelia Huck
2007-10-30 16:56 ` Dirk Hohndel
2007-10-30 17:31 ` Cornelia Huck [this message]
2007-10-30 22:56 ` Dirk Hohndel
2007-10-31 9:45 ` Cornelia Huck
2007-11-02 13:04 ` Jens Axboe
2007-11-02 19:29 ` Dirk Hohndel
2007-11-02 19:50 ` Bob Copeland
2007-11-02 20:29 ` Dirk Hohndel
2007-11-06 20:02 ` [PATCH] FS: " Dirk Hohndel
2007-11-06 21:38 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071030183112.7e860c23@gondolin.boeblingen.de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=aeb@cwi.nl \
--cc=hohndel@linux.intel.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®