From: Dirk Hohndel <hohndel@linux.intel.com>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>,
Andries Brouwer <aeb@cwi.nl>, Al Viro <viro@ftp.linux.org.uk>,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] add_partition silently ignored errors
Date: Fri, 2 Nov 2007 12:29:14 -0700 [thread overview]
Message-ID: <20071102192914.GA888@linux.intel.com> (raw)
In-Reply-To: <20071102130438.GC28340@kernel.dk>
On Fri, Nov 02, 2007 at 02:04:39PM +0100, Jens Axboe wrote:
> > >
> > > > > > IIRC, Al recently vetoed a similar patch. As far as I'm concerned, with
> > > > > > the correct return values, the patch then looks fine to me.
> >
> > So Al, are you ok with this one?
Still haven't seen feedback from Al...
> > [FILESYSTEM] add_partition ignores errors
>
> Looks good to me. One final return value note:
>
> > @@ -554,8 +573,11 @@ int rescan_partitions(struct gendisk *disk, struct block_device *bdev)
> > if (from + size > get_capacity(disk)) {
> > printk(" %s: p%d exceeds device capacity\n",
> > disk->disk_name, p);
> > + return -EBUSY;
> > }
>
> -EBUSY seems a bit confusing here, although I don't know what the best
> value to return would be (and it probably doesn't matter). -EOVERFLOW?
> -ENOSPC?
I was wondering about that myself - EBUSY seemed to be used in a couple of
other cases where there wasn't a clear match, but I think EOVERFLOW actually
might make more sense. Opinions?
/D
next prev parent reply other threads:[~2007-11-02 19:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-29 12:22 Dirk Hohndel
2007-10-29 13:06 ` Cornelia Huck
2007-10-29 14:24 ` Dirk Hohndel
2007-10-29 14:43 ` Cornelia Huck
2007-10-29 15:48 ` Dirk Hohndel
2007-10-29 16:47 ` Cornelia Huck
2007-10-30 8:07 ` Jens Axboe
2007-10-30 9:09 ` Cornelia Huck
2007-10-30 16:56 ` Dirk Hohndel
2007-10-30 17:31 ` Cornelia Huck
2007-10-30 22:56 ` Dirk Hohndel
2007-10-31 9:45 ` Cornelia Huck
2007-11-02 13:04 ` Jens Axboe
2007-11-02 19:29 ` Dirk Hohndel [this message]
2007-11-02 19:50 ` Bob Copeland
2007-11-02 20:29 ` Dirk Hohndel
2007-11-06 20:02 ` [PATCH] FS: " Dirk Hohndel
2007-11-06 21:38 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071102192914.GA888@linux.intel.com \
--to=hohndel@linux.intel.com \
--cc=aeb@cwi.nl \
--cc=cornelia.huck@de.ibm.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome