From: "Bob Copeland" <me@bobcopeland.com>
To: "Dirk Hohndel" <hohndel@linux.intel.com>
Cc: "Jens Axboe" <jens.axboe@oracle.com>,
"Cornelia Huck" <cornelia.huck@de.ibm.com>,
"Andries Brouwer" <aeb@cwi.nl>, "Al Viro" <viro@ftp.linux.org.uk>,
linux-kernel@vger.kernel.org,
"Linus Torvalds" <torvalds@linux-foundation.org>
Subject: Re: [PATCH] add_partition silently ignored errors
Date: Fri, 2 Nov 2007 15:50:29 -0400 [thread overview]
Message-ID: <b6c5339f0711021250w78fc420ekbc68e3c74b9939d3@mail.gmail.com> (raw)
In-Reply-To: <20071102192914.GA888@linux.intel.com>
On 11/2/07, Dirk Hohndel <hohndel@linux.intel.com> wrote:
> > > @@ -554,8 +573,11 @@ int rescan_partitions(struct gendisk *disk, struct block_device *bdev)
> > > if (from + size > get_capacity(disk)) {
> > > printk(" %s: p%d exceeds device capacity\n",
> > > disk->disk_name, p);
> > > + return -EBUSY;
[snip]
> I was wondering about that myself - EBUSY seemed to be used in a couple of
> other cases where there wasn't a clear match, but I think EOVERFLOW actually
> might make more sense. Opinions?
ISTR that some people wanted to keep going in this case rather than
return an error, e.g. for forensic purposes...
.. digging... here's a thread from last year:
http://lkml.org/lkml/2006/5/11/64
-Bob
next prev parent reply other threads:[~2007-11-02 19:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-29 12:22 Dirk Hohndel
2007-10-29 13:06 ` Cornelia Huck
2007-10-29 14:24 ` Dirk Hohndel
2007-10-29 14:43 ` Cornelia Huck
2007-10-29 15:48 ` Dirk Hohndel
2007-10-29 16:47 ` Cornelia Huck
2007-10-30 8:07 ` Jens Axboe
2007-10-30 9:09 ` Cornelia Huck
2007-10-30 16:56 ` Dirk Hohndel
2007-10-30 17:31 ` Cornelia Huck
2007-10-30 22:56 ` Dirk Hohndel
2007-10-31 9:45 ` Cornelia Huck
2007-11-02 13:04 ` Jens Axboe
2007-11-02 19:29 ` Dirk Hohndel
2007-11-02 19:50 ` Bob Copeland [this message]
2007-11-02 20:29 ` Dirk Hohndel
2007-11-06 20:02 ` [PATCH] FS: " Dirk Hohndel
2007-11-06 21:38 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6c5339f0711021250w78fc420ekbc68e3c74b9939d3@mail.gmail.com \
--to=me@bobcopeland.com \
--cc=aeb@cwi.nl \
--cc=cornelia.huck@de.ibm.com \
--cc=hohndel@linux.intel.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®