From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: davem@davemloft.net
Subject: Re: [IRDA] IRNET: Fix build when TCGETS2 is defined.
Date: Thu, 1 Nov 2007 22:30:10 +0000 [thread overview]
Message-ID: <20071101223010.6780cc98@the-village.bc.nu> (raw)
In-Reply-To: <200711011959.lA1JxPWc003735@hera.kernel.org>
On Thu, 1 Nov 2007 19:59:25 GMT
Linux Kernel Mailing List <linux-kernel@vger.kernel.org> wrote:
> Gitweb: http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=49259d34c52df6be482fefca946debe28ba9a2f6
> Commit: 49259d34c52df6be482fefca946debe28ba9a2f6
> Parent: 3b582cc14c50f71eabf1c3cada05acb8dc9f457c
> Author: David S. Miller <davem@sunset.davemloft.net>
> AuthorDate: Thu Nov 1 02:26:38 2007 -0700
> Committer: David S. Miller <davem@sunset.davemloft.net>
> CommitDate: Thu Nov 1 02:26:38 2007 -0700
>
> [IRDA] IRNET: Fix build when TCGETS2 is defined.
>
> Signed-off-by: David S. Miller <davem@davemloft.net>
NO NO NO NO NO NO NO
Line disciplines have no business touching termios ioctls. Especially
wrongly.
Nothing anywhere in the kernel but the core ioctl code should be
processing TCGET/TCSET calls.
Just delete them. It will return -ENOIOCTLCMD and the core tty layer will
process them.
Alan
next parent reply other threads:[~2007-11-01 22:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200711011959.lA1JxPWc003735@hera.kernel.org>
2007-11-01 22:30 ` Alan Cox [this message]
2007-11-01 22:41 ` David Miller
2007-11-02 12:51 ` Alan Cox
2007-11-01 22:32 ` Alan Cox
2007-11-01 22:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071101223010.6780cc98@the-village.bc.nu \
--to=alan@lxorguk.ukuu.org.uk \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®