mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: alan@lxorguk.ukuu.org.uk
Cc: linux-kernel@vger.kernel.org
Subject: Re: [IRDA] IRNET: Fix build when TCGETS2 is defined.
Date: Thu, 01 Nov 2007 15:41:23 -0700 (PDT)	[thread overview]
Message-ID: <20071101.154123.102568743.davem@davemloft.net> (raw)
In-Reply-To: <20071101223010.6780cc98@the-village.bc.nu>

From: Alan Cox <alan@lxorguk.ukuu.org.uk>
Date: Thu, 1 Nov 2007 22:30:10 +0000

> NO NO NO NO NO NO NO

Glad that got your attention, finally...

> Line disciplines have no business touching termios ioctls. Especially
> wrongly. 
> 
> Nothing anywhere in the kernel but the core ioctl code should be
> processing TCGET/TCSET calls.
> 
> Just delete them. It will return -ENOIOCTLCMD and the core tty layer will
> process them.

Ok.

  reply	other threads:[~2007-11-01 22:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200711011959.lA1JxPWc003735@hera.kernel.org>
2007-11-01 22:30 ` Alan Cox
2007-11-01 22:41   ` David Miller [this message]
2007-11-02 12:51     ` Alan Cox
2007-11-01 22:32 ` Alan Cox
2007-11-01 22:42   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071101.154123.102568743.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®