mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: David Miller <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [IRDA] IRNET: Fix build when TCGETS2 is defined.
Date: Fri, 2 Nov 2007 12:51:09 +0000	[thread overview]
Message-ID: <20071102125109.11d2efb4@the-village.bc.nu> (raw)
In-Reply-To: <20071101.154123.102568743.davem@davemloft.net>

> > Nothing anywhere in the kernel but the core ioctl code should be
> > processing TCGET/TCSET calls.
> > 
> > Just delete them. It will return -ENOIOCTLCMD and the core tty layer will
> > process them.
> 
> Ok.

One set of patches in testing.

For the irda non-tty device its almost impossible to hack up a sane
solution except to delete the junk. pppd has supported "notty" for some
years so there is no excuse for that still being present.

The ones with actual ttys can be done cleanly so I've

- split n_tty_ioctl
- used the split to create tty_mode_ioctl() which an ldisc can use for
generic mode handling
- extracted the flush method so it can be used more cleanly by ppp etc

Patches to follow shortly for review

Alan

  reply	other threads:[~2007-11-02 12:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200711011959.lA1JxPWc003735@hera.kernel.org>
2007-11-01 22:30 ` Alan Cox
2007-11-01 22:41   ` David Miller
2007-11-02 12:51     ` Alan Cox [this message]
2007-11-01 22:32 ` Alan Cox
2007-11-01 22:42   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071102125109.11d2efb4@the-village.bc.nu \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®