* [2.6 patch] kernel/ns_cgroup.c should #include <linux/nsproxy.h>
@ 2008-02-22 19:58 Adrian Bunk
2008-02-23 0:02 ` Serge E. Hallyn
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2008-02-22 19:58 UTC (permalink / raw)
To: Serge E. Hallyn; +Cc: linux-kernel
Every file should include the headers containing the externs its global
functions (in this case for ns_cgroup_clone()).
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
d3446a02068091d59425c51bde1daea777398e44 diff --git a/kernel/ns_cgroup.c b/kernel/ns_cgroup.c
index aead4d6..659f321 100644
--- a/kernel/ns_cgroup.c
+++ b/kernel/ns_cgroup.c
@@ -7,6 +7,7 @@
#include <linux/module.h>
#include <linux/cgroup.h>
#include <linux/fs.h>
+#include <linux/nsproxy.h>
struct ns_cgroup {
struct cgroup_subsys_state css;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [2.6 patch] kernel/ns_cgroup.c should #include <linux/nsproxy.h>
2008-02-22 19:58 [2.6 patch] kernel/ns_cgroup.c should #include <linux/nsproxy.h> Adrian Bunk
@ 2008-02-23 0:02 ` Serge E. Hallyn
0 siblings, 0 replies; 2+ messages in thread
From: Serge E. Hallyn @ 2008-02-23 0:02 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Serge E. Hallyn, linux-kernel
Quoting Adrian Bunk (bunk@kernel.org):
> Every file should include the headers containing the externs its global
> functions (in this case for ns_cgroup_clone()).
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
Seems fine... and a good way to ensure that the prototype and
definition match.
Acked-by: Serge Hallyn <serue@us.ibm.com>
thanks,
-serge
>
> ---
> d3446a02068091d59425c51bde1daea777398e44 diff --git a/kernel/ns_cgroup.c b/kernel/ns_cgroup.c
> index aead4d6..659f321 100644
> --- a/kernel/ns_cgroup.c
> +++ b/kernel/ns_cgroup.c
> @@ -7,6 +7,7 @@
> #include <linux/module.h>
> #include <linux/cgroup.h>
> #include <linux/fs.h>
> +#include <linux/nsproxy.h>
>
> struct ns_cgroup {
> struct cgroup_subsys_state css;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-02-23 0:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-22 19:58 [2.6 patch] kernel/ns_cgroup.c should #include <linux/nsproxy.h> Adrian Bunk
2008-02-23 0:02 ` Serge E. Hallyn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®