From: Andrew Morton <akpm@linux-foundation.org>
To: Christoph Lameter <clameter@sgi.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Torsten Kaiser <just.for.lkml@googlemail.com>,
Ingo Molnar <mingo@elte.hu>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Eric Dumazet <dada1@cosmosbay.com>
Subject: Re: Linux 2.6.25-rc2
Date: Wed, 27 Feb 2008 17:57:26 -0800 [thread overview]
Message-ID: <20080227175726.ad6bda9d.akpm@linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0802271532220.14380@schroedinger.engr.sgi.com>
On Wed, 27 Feb 2008 15:32:52 -0800 (PST) Christoph Lameter <clameter@sgi.com> wrote:
> On Tue, 19 Feb 2008, Mathieu Desnoyers wrote:
>
> > incrementing the variable with a "++" when interrupts are not disabled.
> > It's not an atomic add and it's racy. The code within stat() does
> > exactly this.
>
> Yes but that is only for used for statistics which can be racy. Note that
> the VM event statistics also can be racy.
>
Doing ++ on a u32 _is_ atomic wrt interrupts on x86 and probably lots of
other architectures, so we're OK using unsigned there. But on some other
architectures ++ on u32 is not atomic wrt interrutps, so they should use
atomic_t or some other arch-specific mechanism.
And guess what? It's already all been done: local_t.
next prev parent reply other threads:[~2008-02-28 1:58 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-15 21:23 Linus Torvalds
2008-02-16 2:08 ` Rafael J. Wysocki
2008-02-16 5:44 ` [BUG] Linux 2.6.25-rc2 - Kernel Ooops while running dbench Kamalesh Babulal
2008-02-18 12:59 ` Andrew Morton
2008-02-18 14:25 ` Jeff Garzik
2008-02-18 16:11 ` Frans Pop
2008-03-03 11:51 ` Pekka Enberg
2008-03-04 4:03 ` Kamalesh Babulal
2008-02-16 6:10 ` [BUG] Linux 2.6.25-rc2 - Regression from 2.6.24-rc1-git1 softlockup while bootup on powerpc Kamalesh Babulal
2008-02-17 19:29 ` Jens Axboe
2008-02-19 8:04 ` KAMEZAWA Hiroyuki
2008-02-19 8:36 ` Jens Axboe
2008-02-19 8:47 ` KAMEZAWA Hiroyuki
2008-02-19 8:58 ` Jens Axboe
2008-02-19 9:07 ` KAMEZAWA Hiroyuki
2008-02-19 9:09 ` Jens Axboe
2008-02-19 9:02 ` KAMEZAWA Hiroyuki
2008-02-19 9:01 ` Jens Axboe
2008-02-19 13:19 ` Kamalesh Babulal
2008-02-22 7:24 ` Andrew Morton
2008-02-22 7:40 ` Jens Axboe
2008-02-17 20:08 ` Rafael J. Wysocki
2008-02-16 16:52 ` Linux 2.6.25-rc2 Jan Engelhardt
2008-02-16 19:14 ` Linux 2.6.25-rc2 regression: LVM cannot find volume group Tilman Schmidt
2008-02-16 20:12 ` Alan Cox
2008-02-16 22:37 ` Jiri Slaby
2008-02-18 0:57 ` Tilman Schmidt
2008-02-18 1:22 ` Jeff Chua
2008-02-18 10:35 ` Tilman Schmidt
2008-02-19 1:53 ` Alasdair G Kergon
2008-02-19 8:56 ` Tilman Schmidt
2008-02-16 21:38 ` Linux 2.6.25-rc2 Torsten Kaiser
2008-02-17 20:25 ` Rafael J. Wysocki
2008-02-17 21:32 ` Torsten Kaiser
2008-02-18 23:54 ` Linus Torvalds
2008-02-19 6:44 ` Torsten Kaiser
2008-02-19 6:11 ` Ingo Molnar
2008-02-19 6:54 ` Torsten Kaiser
2008-02-19 7:21 ` Pekka Enberg
2008-02-19 10:27 ` Ingo Molnar
2008-02-19 10:45 ` Pekka Enberg
2008-02-19 13:02 ` Mathieu Desnoyers
2008-02-19 14:00 ` Ingo Molnar
2008-02-19 14:02 ` Mathieu Desnoyers
2008-02-19 14:21 ` Pekka Enberg
2008-02-19 14:38 ` Pekka Enberg
2008-02-19 14:55 ` Ingo Molnar
2008-02-19 14:57 ` Ingo Molnar
2008-02-19 15:54 ` Pekka Enberg
2008-02-19 15:52 ` Pekka Enberg
2008-02-20 0:36 ` Zhang, Yanmin
2008-02-20 2:08 ` Zhang, Yanmin
2008-02-20 6:53 ` Zhang, Yanmin
2008-02-20 7:10 ` Pekka Enberg
2008-02-19 16:20 ` Linus Torvalds
2008-02-19 16:45 ` Ingo Molnar
2008-02-19 16:48 ` Ingo Molnar
2008-02-19 19:27 ` Torsten Kaiser
2008-02-19 20:08 ` Mathieu Desnoyers
2008-02-27 23:32 ` Christoph Lameter
2008-02-28 1:57 ` Andrew Morton [this message]
2008-02-28 2:43 ` Christoph Lameter
2008-02-28 8:14 ` Ingo Molnar
2008-02-28 11:15 ` Alan Cox
2008-02-28 11:13 ` Jiri Kosina
2008-02-19 16:27 ` Eric Dumazet
2008-02-19 16:38 ` Linus Torvalds
2008-02-19 20:03 ` Mathieu Desnoyers
2008-02-27 23:34 ` Christoph Lameter
2008-02-28 5:55 ` [PATCH] Implement slub fastpath in terms of freebase and freeoffset Mathieu Desnoyers
2008-02-28 19:08 ` Christoph Lameter
2008-02-28 23:25 ` Mathieu Desnoyers
2008-02-29 0:57 ` Christoph Lameter
2008-02-29 1:56 ` Mathieu Desnoyers
2008-02-29 2:12 ` Christoph Lameter
2008-02-29 3:32 ` Mathieu Desnoyers
2008-02-29 5:11 ` Christoph Lameter
2008-02-29 13:03 ` Mathieu Desnoyers
2008-02-29 19:57 ` Christoph Lameter
2008-02-29 13:28 ` [PATCH] Slub Freeoffset check overflow Mathieu Desnoyers
2008-03-04 6:17 ` [PATCH] Slub Freeoffset check overflow (updated) Mathieu Desnoyers
2008-03-04 7:15 ` Christoph Lameter
2008-02-27 23:32 ` Linux 2.6.25-rc2 Christoph Lameter
2008-02-19 18:39 ` Torsten Kaiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080227175726.ad6bda9d.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=dada1@cosmosbay.com \
--cc=just.for.lkml@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=penberg@cs.helsinki.fi \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome