* [PATCH] x86: fix miscompile
@ 2008-04-03 14:53 James Bottomley
2008-04-03 18:14 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: James Bottomley @ 2008-04-03 14:53 UTC (permalink / raw)
To: Ingo Molnar, Thomas Gleixner; +Cc: linux-kernel
This patch local to the x86 tree introduced a fairly obvious compile
fault:
commit f22fc9998497af6c271385e2025e2fe71c6f15b0
Author: Ingo Molnar <mingo@elte.hu>
Date: Wed Apr 2 12:20:18 2008 +0200
x86: allocate FPU context to init task
I've attached the fix below (INIT_THREAD is a #defined initializer, not
an actual structure). However, if you get this tree into linux-next,
they'll do a much better job of shaking out bugs like this than I could.
James
---
diff --git a/include/asm-x86/processor.h b/include/asm-x86/processor.h
index d4686cf..2fad98d 100644
--- a/include/asm-x86/processor.h
+++ b/include/asm-x86/processor.h
@@ -828,7 +828,7 @@ extern union thread_xstate init_xstate;
.sysenter_cs = __KERNEL_CS, \
.io_bitmap_ptr = NULL, \
.fs = __KERNEL_PERCPU, \
- .xstate = &init_xstate;
+ .xstate = &init_xstate, \
}
/*
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] x86: fix miscompile
2008-04-03 14:53 [PATCH] x86: fix miscompile James Bottomley
@ 2008-04-03 18:14 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-04-03 18:14 UTC (permalink / raw)
To: James Bottomley; +Cc: Thomas Gleixner, linux-kernel
* James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
> This patch local to the x86 tree introduced a fairly obvious compile
> fault:
thanks - i already pulled the original change.
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-04-03 18:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-04-03 14:53 [PATCH] x86: fix miscompile James Bottomley
2008-04-03 18:14 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®