mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johannes Weiner <hannes@saeurebad.de>
To: linux-kernel@vger.kernel.org
Cc: Andi Kleen <ak@suse.de>, Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	Yinghai Lu <yhlu.kernel@gmail.com>,
	Yasunori Goto <y-goto@jp.fujitsu.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Christoph Lameter <clameter@sgi.com>
Subject: [patch 0/2] bootmem: Fix node-setup agnostic free_bootmem()
Date: Sun, 13 Apr 2008 00:33:19 +0200	[thread overview]
Message-ID: <20080412223319.372887160@symbol.fehenstaub.lan> (raw)

[the first send didn't make it to lkml, so here it is again]

Hi,

as I was doing some clean-ups in the bootmem allocator, I noticed the
patch

    5a982cbc7b3fe6cf72266f319286f29963c71b9e
    mm: fix boundary checking in free_bootmem_core

which seems to implement the opposite of what the subject promises.

It makes input arguments acceptable if they are `a bit wrong' and
silently aborts if they are completely off the whack.

Please have a look at the two patches I propose: one to revert the
original and the other one to reimplement what the whole thing was
really about: having free_bootmem() itself look up the node holding
the specified address range.

Note also that the reverted patch changed a helper function and
therefore also affected free_bootmem_node(), making the latter paper
over bugs as well.

	Hannes

Original version:

 mm/bootmem.c |   25 +++++++++++++++++++------
 1 files changed, 19 insertions(+), 6 deletions(-)

New version:

 bootmem.c |   10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

             reply	other threads:[~2008-04-13 10:36 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-12 22:33 Johannes Weiner [this message]
2008-04-12 22:33 ` [patch 1/2] bootmem: Revert "mm: fix boundary checking in free_bootmem_core" Johannes Weiner
2008-04-13  1:55   ` Yinghai Lu
2008-04-12 22:33 ` [patch 2/2] bootmem: Node-setup agnostic free_bootmem() Johannes Weiner
2008-04-13  1:59   ` Yinghai Lu
2008-04-13 10:57     ` Johannes Weiner
2008-04-13 16:56   ` Andi Kleen
2008-04-15  6:23     ` Andrew Morton
2008-04-15  7:04       ` Yinghai Lu
2008-04-15  7:15         ` Andrew Morton
2008-04-15  7:28           ` Yinghai Lu
2008-04-15  7:36             ` Andrew Morton
2008-04-15 11:51               ` Johannes Weiner
2008-04-15 18:52                 ` Yinghai Lu
2008-04-15 19:43                   ` Johannes Weiner
2008-04-15  7:46       ` Andi Kleen
2008-04-15 11:53         ` Johannes Weiner
2008-04-15 18:44           ` Yinghai Lu
2008-04-15 19:51             ` Johannes Weiner
2008-04-15 19:57               ` Yinghai Lu
2008-04-15 20:05                 ` Johannes Weiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080412223319.372887160@symbol.fehenstaub.lan \
    --to=hannes@saeurebad.de \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=clameter@sgi.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=y-goto@jp.fujitsu.com \
    --cc=yhlu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®