From: "Yinghai Lu" <yhlu.kernel@gmail.com>
To: "Johannes Weiner" <hannes@saeurebad.de>
Cc: linux-kernel@vger.kernel.org, "Andi Kleen" <ak@suse.de>,
"Ingo Molnar" <mingo@elte.hu>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Yasunori Goto" <y-goto@jp.fujitsu.com>,
"KAMEZAWA Hiroyuki" <kamezawa.hiroyu@jp.fujitsu.com>,
"Christoph Lameter" <clameter@sgi.com>
Subject: Re: [patch 1/2] bootmem: Revert "mm: fix boundary checking in free_bootmem_core"
Date: Sat, 12 Apr 2008 18:55:41 -0700 [thread overview]
Message-ID: <86802c440804121855g2a8da2yee02c64daddad9a5@mail.gmail.com> (raw)
In-Reply-To: <20080412225850.411927887@symbol.fehenstaub.lan>
On Sat, Apr 12, 2008 at 3:33 PM, Johannes Weiner <hannes@saeurebad.de> wrote:
> This reverts commit 5a982cbc7b3fe6cf72266f319286f29963c71b9e.
>
> The intention behind this patch was to make the free_bootmem()
> interface more robust with regards to the specified range and to let
> it operate on multiple node setups as well.
>
> However, it made free_bootmem_core()
>
> 1. handle bogus node/memory-range combination input by just
> returning early without informing the callsite or screaming BUG()
> as it did before
> 2. round slightly out of node-range values to the node boundaries
> instead of treating them as the invalid parameters they are
>
> This was partially done to abuse free_bootmem_core() for node
> iteration in free_bootmem (just feeding it every node on the box and
> let it figure out what it wants to do with it) instead of looking up
> the proper node before the call to free_bootmem_core().
it seems intel having one box the [0, 4G), [8, 12G] on node 0, and
[4G, 8G) and [12G, 16) on node 1.
YH
next prev parent reply other threads:[~2008-04-13 1:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-12 22:33 [patch 0/2] bootmem: Fix node-setup agnostic free_bootmem() Johannes Weiner
2008-04-12 22:33 ` [patch 1/2] bootmem: Revert "mm: fix boundary checking in free_bootmem_core" Johannes Weiner
2008-04-13 1:55 ` Yinghai Lu [this message]
2008-04-12 22:33 ` [patch 2/2] bootmem: Node-setup agnostic free_bootmem() Johannes Weiner
2008-04-13 1:59 ` Yinghai Lu
2008-04-13 10:57 ` Johannes Weiner
2008-04-13 16:56 ` Andi Kleen
2008-04-15 6:23 ` Andrew Morton
2008-04-15 7:04 ` Yinghai Lu
2008-04-15 7:15 ` Andrew Morton
2008-04-15 7:28 ` Yinghai Lu
2008-04-15 7:36 ` Andrew Morton
2008-04-15 11:51 ` Johannes Weiner
2008-04-15 18:52 ` Yinghai Lu
2008-04-15 19:43 ` Johannes Weiner
2008-04-15 7:46 ` Andi Kleen
2008-04-15 11:53 ` Johannes Weiner
2008-04-15 18:44 ` Yinghai Lu
2008-04-15 19:51 ` Johannes Weiner
2008-04-15 19:57 ` Yinghai Lu
2008-04-15 20:05 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86802c440804121855g2a8da2yee02c64daddad9a5@mail.gmail.com \
--to=yhlu.kernel@gmail.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=hannes@saeurebad.de \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®