[PATCH] RxRPC: Fix a regression in the RXKAD security module

[PATCH] RxRPC: Fix a regression in the RXKAD security module

[David Howells]

Fix a regression in the RXKAD security module introduced in:

	commit 91e916cffec7c0153c5cbaa447151862a7a9a047
	Author: Al Viro <viro@ftp.linux.org.uk>
	Date:   Sat Mar 29 03:08:38 2008 +0000

	net/rxrpc trivial annotations

A variable was declared as a 16-bit type rather than a 32-bit type.

Signed-off-by: David Howells <dhowells@redhat.com>
---

 net/rxrpc/rxkad.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/net/rxrpc/rxkad.c b/net/rxrpc/rxkad.c
index 6d38a81..ba3f6e4 100644
--- a/net/rxrpc/rxkad.c
+++ b/net/rxrpc/rxkad.c
@@ -493,8 +493,8 @@ static int rxkad_verify_packet(const struct rxrpc_call *call,
 		__be32 x[2];
 	} tmpbuf __attribute__((aligned(8))); /* must all be in same page */
 	__be32 x;
-	u16 y;
 	__be16 cksum;
+	u32 y;
 	int ret;
 
 	sp = rxrpc_skb(skb);

Re: [PATCH] RxRPC: Fix a regression in the RXKAD security module

[Al Viro]

On Thu, Apr 24, 2008 at 08:38:56PM +0100, David Howells wrote:
> Fix a regression in the RXKAD security module introduced in:
> 
> 	commit 91e916cffec7c0153c5cbaa447151862a7a9a047
> 	Author: Al Viro <viro@ftp.linux.org.uk>
> 	Date:   Sat Mar 29 03:08:38 2008 +0000
> 
> 	net/rxrpc trivial annotations
> 
> A variable was declared as a 16-bit type rather than a 32-bit type.

ACK with apologies

Re: [PATCH] RxRPC: Fix a regression in the RXKAD security module

[Linus Torvalds]

On Thu, 24 Apr 2008, David Howells wrote:
>
> Fix a regression in the RXKAD security module introduced in:
> 
> 	commit 91e916cffec7c0153c5cbaa447151862a7a9a047
> 	Author: Al Viro <viro@ftp.linux.org.uk>
> 	Date:   Sat Mar 29 03:08:38 2008 +0000
> 
> 	net/rxrpc trivial annotations
> 
> A variable was declared as a 16-bit type rather than a 32-bit type.

Ok, that looks stupid, and should even have had a warning (shifting a u16 
right by 16 should warn about it being pointless, but doesn't, because the 
compiler quietly expands it to "int" in the meantime).

Hmm. I could do something to sparse that warns about that too. 

		Linus