Re: [GIT PULL] kbuild fixes

[Adrian Bunk <bunk@kernel.org>]

On Sat, Apr 26, 2008 at 09:37:01PM +0200, Sam Ravnborg wrote:
> On Sat, Apr 26, 2008 at 10:20:37PM +0300, Adrian Bunk wrote:
> > On Sat, Apr 26, 2008 at 09:12:56PM +0200, Sam Ravnborg wrote:
> > > Hi Linus.
> > > 
> > > Please apply the following two fixes by pulling from:
> > > 
> > >    master.kernel.org/pub/scm/linux/kernel/git/sam/kbuild.git
> > > 
> > > 
> > > The MODULE_LICENSE fix is neded to get an allmodconfig
> > > build fixed.
> > 
> > Which one is this?
> > 
> > http://lkml.org/lkml/2008/3/31/50 ?
> > (my allmod build is not yet finished)
> 
> The changelog was actually bad for this one.

It was not a build error when I sent it one month ago, and that was the 
changelog in all such patches I sent.

> I saw two classes of problems:
> 
> 1) I got report about broken builds - fbdev was the culprint.
> 2) a "make CONFIG_DEBUG_SECTION_MISMATCH=y" build broke
>    immediately.

OK, I never tried 2).

As long as this problem exists even a warning shouldn't be issued.

> I made it non-fatal because we had at least one module that
> was not yet fixed.

I had this patch in my test compiles for some time.

Considering that I had a new such bug to fix during this merge window
"at least one unfixed module" is a bad prerequisite for making it an 
error since new bugs always get added.  ;-)

> 	Sam

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed