mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Américo Wang" <xiyou.wangcong@gmail.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: Sam Ravnborg <sam@ravnborg.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	lkml <linux-kernel@vger.kernel.org>,
	linux-kbuild <linux-kbuild@vger.kernel.org>
Subject: Re: [GIT PULL] kbuild fixes
Date: Tue, 13 Oct 2009 23:10:19 +0800	[thread overview]
Message-ID: <2375c9f90910130810w2d887dd2uea0f4bc88ac2d894@mail.gmail.com> (raw)
In-Reply-To: <4AD2EBC6.1000505@msgid.tls.msk.ru>

On Mon, Oct 12, 2009 at 4:41 PM, Michael Tokarev <mjt@tls.msk.ru> wrote:
> Sam Ravnborg wrote:
>>
>> Hi Linus.
>>
>> A few kbuild related fixes.
>
> []
>>
>> - Fix use of echo -ne. Is caused issues for ubuntu (IIRC) users
>
> As has been discussed previously (and Sam has been CC'ed), the fix
> is still incorrect.  It replaces "echo -ne" with "/bin/echo -ne",
> but neither of the two are guaranteed to support the necessary
> arguments and necessary (hexadecimal) escape sequences.  What should
> be used here is printf(1).  The trivial patch below (on top of these
> kbuild changes) fixes this issue.
>
> Thanks.
>
> /mjt
>
> Signed-Off-By: Michael Tokarev <mjt@tls.msk.ru>
>

Sorry, I just saw this email.

Hmm, printf(1) should be more portable than echo(1), I checked your patch,
how about using 'printf "%b" ' instead?

Thanks!

  reply	other threads:[~2009-10-13 15:11 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-11 22:18 Sam Ravnborg
2009-10-12  8:41 ` Michael Tokarev
2009-10-13 15:10   ` Américo Wang [this message]
2009-10-13 18:58   ` Sam Ravnborg
2009-10-13 19:19     ` Michael Tokarev
2009-10-13 20:20       ` Sam Ravnborg
2009-10-14  6:43         ` Michael Tokarev
  -- strict thread matches above, loose matches on Subject: below --
2008-08-06 20:27 Sam Ravnborg
2008-08-07  9:18 ` Russell King
2008-08-04 21:01 Sam Ravnborg
2008-05-25  7:12 Sam Ravnborg
2008-05-25 18:31 ` Sam Ravnborg
2008-05-25 21:10   ` Sam Ravnborg
2008-05-04 19:13 Sam Ravnborg
2008-04-26 19:12 Sam Ravnborg
2008-04-26 19:20 ` Adrian Bunk
2008-04-26 19:37   ` Sam Ravnborg
2008-04-26 19:49     ` Sam Ravnborg
2008-04-26 19:55       ` Adrian Bunk
2008-04-26 20:05     ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2375c9f90910130810w2d887dd2uea0f4bc88ac2d894@mail.gmail.com \
    --to=xiyou.wangcong@gmail.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjt@tls.msk.ru \
    --cc=sam@ravnborg.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®