From: Sam Ravnborg <sam@ravnborg.org>
To: Linus Torvalds <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-kbuild <linux-kbuild@vger.kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Jike Song <albcamus@gmail.com>,
Gabriel C <nix.or.die@googlemail.com>
Subject: Re: [GIT PULL] kbuild fixes
Date: Sun, 25 May 2008 23:10:10 +0200 [thread overview]
Message-ID: <20080525211010.GA19126@uranus.ravnborg.org> (raw)
In-Reply-To: <20080525183136.GA12806@uranus.ravnborg.org>
Hi Linus.
I wrote:
> > Sam Ravnborg (1):
> > Kconfig: add KBUILD_DEFCONFIG to DEFCONFIG_LIST
>
> And this commit caused my make to enter an
> infinite looke calling scripts/kconfig/conf -s arch/x86/Kconfig
> Reproduceable by:
> make defconfig
> make
The problem was that the environment variable KBUILD_DEFCONFIG
in some cases were not defined and in other cases it was defined.
Fixing this is non-trivial.
So I reverted back to a solution where we have one config symbol
defined in the ARCH specific Kconfig file.
For now only x86 uses this.
Please pull from:
ssh://master.kernel.org/pub/scm/linux/kernel/git/sam/kbuild-fixes.git
to receive the following updates:
Gabriel C (1):
scripts/ver_linux use 'gcc -dumpversion'
Jike Song (1):
.gitignore: match ncscope.out
Sam Ravnborg (1):
Kconfig: introduce ARCH_DEFCONFIG to DEFCONFIG_LIST
.gitignore | 1 +
arch/x86/Kconfig | 13 +++----------
init/Kconfig | 1 +
scripts/ver_linux | 5 +----
4 files changed, 6 insertions(+), 14 deletions(-)
diff --git a/.gitignore b/.gitignore
index 9c0d650..d24ad50 100644
--- a/.gitignore
+++ b/.gitignore
@@ -52,6 +52,7 @@ series
# cscope files
cscope.*
+ncscope.*
*.orig
*~
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index fe361ae..dcbec34 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -26,17 +26,10 @@ config X86
select HAVE_KVM if ((X86_32 && !X86_VOYAGER && !X86_VISWS && !X86_NUMAQ) || X86_64)
select HAVE_ARCH_KGDB if !X86_VOYAGER
-config DEFCONFIG_LIST
+config ARCH_DEFCONFIG
string
- depends on X86_32
- option defconfig_list
- default "arch/x86/configs/i386_defconfig"
-
-config DEFCONFIG_LIST
- string
- depends on X86_64
- option defconfig_list
- default "arch/x86/configs/x86_64_defconfig"
+ default "arch/x86/configs/i386_defconfig" if X86_32
+ default "arch/x86/configs/x86_64_defconfig" if X86_64
config GENERIC_LOCKBREAK
diff --git a/init/Kconfig b/init/Kconfig
index 6135d07..6199d11 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -13,6 +13,7 @@ config DEFCONFIG_LIST
default "/lib/modules/$UNAME_RELEASE/.config"
default "/etc/kernel-config"
default "/boot/config-$UNAME_RELEASE"
+ default "$ARCH_DEFCONFIG"
default "arch/$ARCH/defconfig"
menu "General setup"
diff --git a/scripts/ver_linux b/scripts/ver_linux
index ab69ece..7ac0e30 100755
--- a/scripts/ver_linux
+++ b/scripts/ver_linux
@@ -12,12 +12,9 @@ echo ' '
uname -a
echo ' '
-gcc --version 2>&1| head -n 1 | grep -v gcc | awk \
+gcc -dumpversion 2>&1| awk \
'NR==1{print "Gnu C ", $1}'
-gcc --version 2>&1| grep gcc | awk \
-'NR==1{print "Gnu C ", $3}'
-
make --version 2>&1 | awk -F, '{print $1}' | awk \
'/GNU Make/{print "Gnu make ",$NF}'
next prev parent reply other threads:[~2008-05-25 21:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-25 7:12 Sam Ravnborg
2008-05-25 18:31 ` Sam Ravnborg
2008-05-25 21:10 ` Sam Ravnborg [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-10-11 22:18 Sam Ravnborg
2009-10-12 8:41 ` Michael Tokarev
2009-10-13 15:10 ` Américo Wang
2009-10-13 18:58 ` Sam Ravnborg
2009-10-13 19:19 ` Michael Tokarev
2009-10-13 20:20 ` Sam Ravnborg
2009-10-14 6:43 ` Michael Tokarev
2008-08-06 20:27 Sam Ravnborg
2008-08-07 9:18 ` Russell King
2008-08-04 21:01 Sam Ravnborg
2008-05-04 19:13 Sam Ravnborg
2008-04-26 19:12 Sam Ravnborg
2008-04-26 19:20 ` Adrian Bunk
2008-04-26 19:37 ` Sam Ravnborg
2008-04-26 19:49 ` Sam Ravnborg
2008-04-26 19:55 ` Adrian Bunk
2008-04-26 20:05 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080525211010.GA19126@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@linux-foundation.org \
--cc=albcamus@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nix.or.die@googlemail.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome